From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792774217; b=Y2lscIA104KAKf7y16cTWTTnLa+3mE0faqu5wrinyF9MErmgW0RbOb66lj0MsDX/dUmY ScW5wwiUrn1cHKZBXfJEGKiZbxD+Zw82J4bQ8HGeBiUEMmJKu9riBfCS8WWQm/WDTke3X Mivxapqz/Gpc67LZuM8nFBUOtpqvpUPrMpf+FgT1mUy/8qMtEKP7LOoOdvOf1gsZRqpiu 7W7hVReW5gnMVbrnqX8bmmRdXfPHPHivhoQJv1y+mKLjpVoxUyGn+aiztJJyJ9wgK/neM WbLR73RXFs4Kc0PMqJbWQXYVGGGJ6CQajbg1rtY6hBrD/nGgK/2xyUu/y2FkYnvgPAA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792774217; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=1qUwTH/bsJjUqhjjhD13n85ORrCtfHYfdh5FQYQ59Lo=; b=enul8BjW71l1nEmY5H6dSaEjWcuRdn35hgwLkBql/VNbhsle4t1wnLrVvH69yj4Rylra /cobcL+uqt2gOkRBe55Qv2dBtXMwily3BoSFyD2zj7LbJdiaYrfrnXT738P5PEvBT9dY3 pHcT4Fx7OKcFkvrRBpf53KofvYLP4nd6yUubderOQddZHC/zQjRE4Kj12YAlHTwcW/XBp dyahJG/gsgQzTywIh58UJgvQaKBZnEQapD8/mQYMEaK5/F4SccdvOIsSKb0nliHtDAmd0 IVCjLMb1/Y1fNSDSgW5Doh2uY7B+AU44rmeZrq37xuRwFmtMbwLF+DmBV87OAiR4PJw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Q2t6n57t; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE94606A31A; Fri, 23 Oct 2026 16:50:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=Q2t6n57t Received: by smtp.kernel.org (Postfix) with ESMTPSA id 289BC1F01828; Fri, 23 Oct 2026 16:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1792774216; bh=1qUwTH/bsJjUqhjjhD13n85ORrCtfHYfdh5FQYQ59Lo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Q2t6n57t50iDk0X1KxciSanVj79kCH/e08QdOI2QRJBhiKbeX/SYR7Qd1E3frkDnh SSv7xeEBKQnQKzLCgy+kKLbFWjUhfbaLjjGTib46q54nh7fpwL8pDsJLu99/HzRI1U GLjGA6pKFk9isBf5yaWqwXsFZoo3YaAHKwqe/9uU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dingisoul , Laurence Oberman , "Martin K. Petersen (Oracle)" Subject: [PATCH 6.18 160/193] scsi: st: Fix use-after-free race between st_remove() and st_open() Date: Fri, 23 Oct 2026 18:37:17 +0200 Message-ID: <20261023163717.993712803@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261023163714.201276352@linuxfoundation.org> References: <20261023163714.201276352@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Laurence Oberman commit 71caf7f84bd62a4bf91cc95abd2de690afb8d15f upstream. st_remove() drops the probe reference on the scsi_tape with kref_put() and only afterwards removes its index from st_index_idr. If that was the last reference, scsi_tape_release() frees the structure while it is still published in the idr. scsi_tape_get(), called from st_open(), looks up the tape in st_index_idr and takes a reference under st_ref_mutex and st_index_lock. remove_cdevs() does not wait for opens that are already past chrdev_open(), so an open that is blocked on st_ref_mutex while st_remove() holds it can take the mutex as soon as st_remove() drops it, find the freed tpnt in the idr and call kref_get() on it: BUG: KASAN: slab-use-after-free in st_open Write of size 4 ... st_open (drivers/scsi/st.c:254 drivers/scsi/st.c:1291) chrdev_open ... Freed by task ...: kfree st_remove (drivers/scsi/st.c:4512) Remove the index from the idr before dropping the reference, all under st_ref_mutex. A concurrent scsi_tape_get() now either runs first and holds a valid reference that keeps the tape alive, or runs afterwards and finds nothing, so st_open() fails with -ENXIO. This restores the ordering st_remove() had before the conversion to st_index_idr, where the tape was unpublished from scsi_tapes[] before the final kref_put(). Fixes: 6c648d95a6af ("[SCSI] st: get rid of scsi_tapes array") Cc: stable@vger.kernel.org Reported-by: Dingisoul Closes: https://lore.kernel.org/linux-scsi/20261007211520.1428497-1-dingiso.kernel@gmail.com/ Tested-by: Dingisoul Signed-off-by: Laurence Oberman Link: https://patch.msgid.link/20261013202548.249628-1-loberman@redhat.com Signed-off-by: Martin K. Petersen (Oracle) [ loberman: st_remove() still returns int in 6.18; context adjusted ] Signed-off-by: Laurence Oberman Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/st.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -4471,11 +4471,11 @@ static int st_remove(struct device *dev) remove_cdevs(tpnt); mutex_lock(&st_ref_mutex); - kref_put(&tpnt->kref, scsi_tape_release); - mutex_unlock(&st_ref_mutex); spin_lock(&st_index_lock); idr_remove(&st_index_idr, index); spin_unlock(&st_index_lock); + kref_put(&tpnt->kref, scsi_tape_release); + mutex_unlock(&st_ref_mutex); return 0; }