From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792774982; b=SpmPQQSZRsTbhxBCTv9+9RWDGBQ6cllod76c1DKRJIe5mxzYKTwZ03Yk5AoGYn3QoKNM lhOm2vEaUkuvP2k0Bb+Oy3dRudsPY4Z8EdZFD6CbKXxazX1F0FnWhinVl1LGrwnrYi6AZ FLMCCurGUP+dX/nCmqVLw/daHa6eOKtEwaJPeImqOfM6rcl+QRhsQ9wFawD6HTRahDxmO 8lFGBm16cOUQkIIuGCUYFLRhPVKKvaq3UjwOniz9shYupjhg6ECUN22I8iAkqHfJ5csCE lMwNg08JUtC4cDCiy2Lb8dp4FhWCokjwdt3poCseIBJ26uPTVL7kKjIaakLRAhF+utg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792774982; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=hX376NTabXvdEdJ9zbiYIsKwB8a0bzoG3eiMusreXdQ=; b=yRuPCmZRmm9OCEdCwfnZ38HSsnvCHYoMgQVuuPc5f+Rh540FKCFxQVvaJaSHvJK3c+fr 27w1evFh3Vxf1D+iNNWPzdBPaWk/36yKIw3zqkTMv5TZQ4kUK07U17eYEq75qjXVbXXml W3P0XhepWYEP70+NQAZt1MXbjGtHm6BPUJA6z/ay+xiMAktOC5lGUtyxM5q8Hsp1Txc+c f0g+W+YCFdqAIjihWj/FXYJSbJmDd+Y3kGIIU/j6UpyFMfV2Se48AQvQHybUI3Scs5ub6 Y7sHZhT3xdJocE5bkSt4R/gVjOqfLCwv3VishRIUzZ+gBqxbFClAbMduxt9LQ8UgpoQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rJsQ98qG; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E8F7606A31A; Fri, 23 Oct 2026 17:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=rJsQ98qG Received: by smtp.kernel.org (Postfix) with ESMTPSA id B87801F01825; Fri, 23 Oct 2026 17:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1792774982; bh=hX376NTabXvdEdJ9zbiYIsKwB8a0bzoG3eiMusreXdQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=rJsQ98qGRIAYNoP36bteV1qnf2ve6Vipmz865TXMcbNw9T4whECXdNuFpb+qj0v2r 2fVMjOZYg7tGyllDtng3qoObN+IJqbWXwyirNB0ePgP5I+s3TjfA9ksz7DBvI7Bqjf /uRawMnjAZV41kSufdWoltaXuXhx6uwrQu/cfOPQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yunpeng Tian , Mingda Zhang , Gongming Wang , Qinrun Dai , Namjae Jeon , Paulo Alcantara Subject: [PATCH 7.2 223/242] smb: client: reject SetEA requests that do not fit the request buffer Date: Fri, 23 Oct 2026 18:41:05 +0200 Message-ID: <20261023163719.106416014@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261023163713.816071858@linuxfoundation.org> References: <20261023163713.816071858@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yunpeng Tian commit 4aa2c106aef4bf3dfd97c30842db0767b26e8428 upstream. CIFSSMBSetEA() copies the caller's extended attribute value into the SMB request buffer without checking that it fits. The requirement is stated in the source but was never implemented: /*BB add length check to see if it would fit in negotiated SMB buffer size BB */ /* if (ea_value_len > buffer_size - 512 (enough for header)) */ if (ea_value_len) memcpy(parm_data->list.name + name_len + 1, ea_value, ea_value_len); The only bound applied on the way in is in cifs_xattr_set(): #define MAX_EA_VALUE_SIZE CIFSMaxBufSize ... if (size > MAX_EA_VALUE_SIZE) CIFSMaxBufSize is the full payload capacity of the buffer, so a value of exactly that size leaves no room for the SMB header, the TRANS2 parameter block, the fealist header and the EA name that are written ahead of it in the same object. SendReceive() already enforces the correct limit on this very length: if (in_len > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE) but it is called after the copy has taken place. An unprivileged setxattr(2) on an SMB1 mount with a 250-byte name and a 16384-byte value writes 16384 bytes starting 345 bytes into a 16588-byte cifs_request object, ending 141 bytes past it: BUG: KASAN: slab-out-of-bounds in CIFSSMBSetEA+0xabc/0xde0 Write of size 16384 at addr ffff888003aa0159 by task init/68 __asan_memcpy+0x3c/0x60 CIFSSMBSetEA+0xabc/0xde0 cifs_xattr_set+0xd3a/0xff0 __vfs_setxattr+0x13e/0x1a0 The buggy address is located 345 bytes inside of allocated 16588-byte region Apply SendReceive()'s limit to the assembled request before the copy rather than after it, and widen the byte counters so the sum cannot wrap before it is tested. byte_count is also tested against U16_MAX, because it is stored in the 16-bit pSMB->ByteCount. That becomes reachable when CIFSMaxBufSize is raised at module load, where it may be set as high as 1024*127: with a 5-byte EA name and a 65521-byte value, count is exactly U16_MAX while byte_count is 65556, and cpu_to_le16() would truncate it to 20 and transmit a frame whose ByteCount does not match its length. Testing byte_count covers count as well, since byte_count is the larger of the two and count's only 16-bit consumer is written after this point. check_add_overflow() is evaluated first so that total_len is assigned before it is reported. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Yunpeng Tian Reported-by: Mingda Zhang Reported-by: Gongming Wang Reported-by: Qinrun Dai Cc: stable@vger.kernel.org Signed-off-by: Yunpeng Tian Reviewed-by: Namjae Jeon Signed-off-by: Paulo Alcantara Signed-off-by: Greg Kroah-Hartman --- fs/smb/client/cifssmb.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) --- a/fs/smb/client/cifssmb.c +++ b/fs/smb/client/cifssmb.c @@ -6350,8 +6350,10 @@ CIFSSMBSetEA(const unsigned int xid, str int name_len; int rc = 0; int bytes_returned = 0; - __u16 params, param_offset, byte_count, offset, count; + __u16 params, param_offset; + unsigned int byte_count, offset, count; int remap = cifs_remap(cifs_sb); + unsigned int total_len; cifs_dbg(FYI, "In SetEA\n"); SetEARetry: @@ -6403,6 +6405,13 @@ SetEARetry: pSMB->Reserved3 = 0; pSMB->SubCommand = cpu_to_le16(TRANS2_SET_PATH_INFORMATION); byte_count = 3 /* pad */ + params + count; + if (check_add_overflow(in_len, byte_count, &total_len) || + byte_count > U16_MAX || + total_len > CIFSMaxBufSize + MAX_CIFS_HDR_SIZE) { + cifs_dbg(VFS, "EA request too large: %u bytes\n", total_len); + cifs_buf_release(pSMB); + return -E2BIG; + } pSMB->DataCount = cpu_to_le16(count); parm_data->list_len = cpu_to_le32(count); parm_data->list.EA_flags = 0;