From: Simon Horman <horms@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: mhun512@gmail.com, netdev@vger.kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, ae878000@gmail.com,
daniel.machon@microchip.com
Subject: Re: [PATCH net v3 2/2] net: nixge: wait for DMA reset before releasing buffers
Date: Fri, 23 Oct 2026 18:23:09 +0100 [thread overview]
Message-ID: <20261023172309.GC888721@horms.kernel.org> (raw)
In-Reply-To: <179237585255.3135.18388695192416186276@kernel.org>
Hi Myeonghun,
On Mon, Oct 19, 2026 at 02:10:52AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 (3) · Medium: 1 (2) · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The patch only partly closes the hole it describes.
I believe the issue above was covered in your response to the AI-generated
review of v1.
https://lore.kernel.org/netdev/179108725013.434549.7036380491047031962@kernel.org/
> - [Medium] One reset timeout in nixge_stop() now disables the port for
> good, and nothing in the driver can recover it.
And I tend to think the above is an intentional implementation trade-off.
But could you comment on it?
> - [Low] On reset timeout, nixge_stop() now returns the error from
> ndo_stop (line 959).
>
> Pre-existing issues:
...
next prev parent reply other threads:[~2026-10-23 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 2:08 [PATCH net v3 0/2] net: nixge: fix tasklet and DMA teardown Myeonghun Pak
2026-10-18 2:08 ` [PATCH net v3 1/2] net: nixge: free IRQs before killing the DMA error tasklet Myeonghun Pak
2026-10-19 2:10 ` netdev-bot+sashiko
2026-10-23 17:09 ` Simon Horman
2026-10-18 2:08 ` [PATCH net v3 2/2] net: nixge: wait for DMA reset before releasing buffers Myeonghun Pak
2026-10-19 2:10 ` netdev-bot+sashiko
2026-10-23 17:23 ` Simon Horman [this message]
2026-10-23 21:03 ` [PATCH net v3 0/2] net: nixge: fix tasklet and DMA teardown Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023172309.GC888721@horms.kernel.org \
--to=horms@kernel.org \
--cc=ae878000@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhun512@gmail.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.