From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792776792; b=YKkGlDEAlGONCktlwMTqUwocPy8i9r6ScQccNjUzsNzfMKDlhFSgaQJzbL1a9mLA4JKX s9wIA4fyOlNoodbr/w8ZJM6EpA/XlmhUrOcK4eksXWHcEodOjyj0jb/J3EHeu5mKmDRwT AdYuAB1kOy2nNQjLW4H+ugtGjEqiclH6+giZqBbejtuFmbID88ew67fSzhcN57sXPCGTG aFLB956RgB/WIBnkyb4Zt68ieCpqMxDveHJbk1fSGF6IT017yIqUsbYpGJpm9aCSViNz7 +JPj2HnDVHG1ZFZtLdcJ4idrZqsEtrIdduKX2zcPbg4t3ZlKGOWSsOk17J9QTuuOpwg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792776792; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Gm-Message-State:X-Gm-Gg:X-Received:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=wVmcYJCgQUHgv9ve3Sep7nP9fPToz32x4tM/1yCBFOw=; b=y/p7cBtM0TB0PJpAILeISOIRlHhksaz2Pk8FkvNTg+Do72ILxYLa1hFdA1/1C8VBvAtR d3t8c7bV8bL8twJBTSlArG9i6xhSC+6R2CuwsEKdntiEvJi5pI81Q5Jcz/8JtH9i3KXqz bsf00+jFzHQbr80MbSp5FN87jjRS28DEiTvpoYSPDnW38P1k/9wFIUi0Ux+iUs7Cw6ihI iRatvQCDsJ/GJLP8RJbqoWyEnPoLazMBf4aBR7W9Jenzle6MOwDdGOmuOp4lZJ8kaod0a PQGyoSiRDfh1MeVsBQKjmHDsiZgOl9me5Ppc0KWJmrGSnKld04NLpxMNlV5JjXoDmNw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=zabbo.net; spf=pass smtp.mailfrom=zabbo.net; dkim=pass header.d=zabbo.net header.i=@zabbo.net header.a=rsa-sha256 header.s=google header.b=AY+oFCrv; arc=none smtp.remote-ip=209.85.216.42 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1883606A31E for ; Fri, 23 Oct 2026 17:33:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org A1883606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zabbo.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zabbo.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=zabbo.net header.i=@zabbo.net header.a=rsa-sha256 header.s=google header.b=AY+oFCrv Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3a7cfe8f761so1277344a91.1 for ; Fri, 23 Oct 2026 10:33:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zabbo.net; s=google; t=1792776791; x=1793381591; darn=lists.linux.dev; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=wVmcYJCgQUHgv9ve3Sep7nP9fPToz32x4tM/1yCBFOw=; b=AY+oFCrvSUzxGfs+dClhJ0TPfTuRnLjAxHZsqt5xX4m323M9Y4SOuEZRqW16Xj+DJF 59MheU9TW0Vmx0ah56sFElKNR7IfsPfmJWiEVIpENm4EZ9GTGiRH0iOw42DkDyyDsxSK 5IkY2Md8St9+49kcbItPpgMaP+C0PDgZQSEYA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792776791; x=1793381591; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=wVmcYJCgQUHgv9ve3Sep7nP9fPToz32x4tM/1yCBFOw=; b=zXCFewHaDaGF716e8qK0Ke8fdUqywty8BIwpyunbrpq1kE22z5Q1wfNdhqEF6s9Xz5 1TsWxMpwH7zaydnZAhntuVIqOFmpQEaGSVkbgjOkha872f2OjP6T69EN9C8H4nhoaH0g 0UmnF4pJNkJ19DwzTdDUMeT0erYRbKG0HJ6jDHJdV2KWpxz1gdNqo+aXIhIana+M6Fq3 uCk9GU4SSC0+vE3tzW3mVYJIP5WF5tpu0K12RSusx2TXpgWxqHUnBOUDCmGc/KoeLn44 j5a32c7Gy7i9tPD0HhQZGKbyLnerwa/RErud2xgDYzpjaqehErdh3sqR7D1scQRsfIIY z/pg== X-Gm-Message-State: AFq9FYJka4lF83z3E0xsiGDl2FH+hsXn75MOHezRMSWgHX6aupMH+OKW 9pnKE2CMoA+aFwRcloQvfBKOABGlYfy6bqPCeodXMpgPMpSCQe7ppXuGsMlrJl/NI5o= X-Gm-Gg: AYBFou35ZPKrwXRpWNscE3F07AqqYaEL0epAZ3arX5riNIktSm2tZ6NqQ9wIa2W28wZ FadglzBDtRtPK/k1VgA/rSWc/eNR8+MsW9Z4Imr/LGmF8wJTMjpNJBSkoMkt76px2Q4/R4hUoIy KDlTZ2EOWfaPdYVODCQHXUuODQ2ium2PiB2LJ1FjldxQCYHsEVhPS40pNZlI9fxQBw4keraMH3C M8JLBcK2rDqP1vk1oR459ZL5BBBEmNmBAe2fPNkKAkEUB68OQUfhWk6FLdByrklnUq/oi9HiTAG 0YHmJsKNShzWQSUiL8HzhIHylHkr3Wz5IE2fw2f3pZiedjth+Ob/KINDkGmjXjX4SsNFkSoQEHh qXb0dkO5vm5VnVVwzNfhArMuo3FeLZqd3WjFiWTnYwwFRLyBCHoY2KwylK10CrDzL5y8iFP+APX GtsVDljn3DSPolQ0NlgoTbnbmp4k4bzZlRMiCgWaa+aM+AiprThnUb0ChkUvfS8Gxfwfjc7rQBS uhJ/VthOCE9ecFiuT83kD44IbDUYkzqLT7kOtM/4A== X-Received: by 2002:a17:90a:e70c:b0:3ac:b3c7:de04 with SMTP id 98e67ed59e1d1-3adea57a99fmr20402a91.34.1792776790835; Fri, 23 Oct 2026 10:33:10 -0700 (PDT) Received: from localhost ([50.39.133.72]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ade3ed5753sm395126a91.2.2026.10.23.10.33.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2026 10:33:10 -0700 (PDT) Date: Fri, 23 Oct 2026 10:33:09 -0700 From: Zach Brown To: Chris Kirby Cc: rpdfs-devel@lists.linux.dev Subject: Re: [PATCH 1/1] Lock both inodes in rpdfs_unlink() Message-ID: <20261023173309.GC1408936@localhost.localdomain> References: <4012f89c8690987b6796af44d595138f3fa21ce3.1792433682.git.ckirby@versity.com> X-Mailing-List: rpdfs-devel@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4012f89c8690987b6796af44d595138f3fa21ce3.1792433682.git.ckirby@versity.com> On Mon, Oct 19, 2026 at 06:15:36PM +0000, Chris Kirby wrote: > The code was only locking the parent directory inode. We also need to > lock the inode being unlinked using rpdfs_inode_rlock_refresh_many(). Applied, thanks! - z