Re: [PATCH rtw-next] wifi: rtw88: 8723d: add iface combination

[Carl Quist <equalizerjr@gmail.com>]

Hi Ping-Ke,

Thanks for the review.

Ping-Ke Shih wrote:
> As you confirmed RTL8723DE work well, it is okay to me.
>
> Did you setup an air sniffer to capture packets? I suggest you can have
> one to check AP behavior including:

No, I have not. I only have this one RTL8723DE laptop and no second
Wi-Fi adapter that can capture in monitor mode, so I cannot check the
five points you listed over the air (beacon interval, DTIM behavior, the
TIM bit for a sleeping station, and broadcast/multicast after the
beacon).

What I did test on the RTL8723DE (kernel 7.2.5, hostapd 2.12, station
and AP on 2.4 GHz channel 1):

- With v1, the AP served a phone beside the station for about four
  hours, and the station re-associated within one second each of four
  times I disconnected it with the AP running.
- With the LPS PG patch, beacons of 192, 312 and 592 bytes were built
  and downloaded without any "rsvd page over size" error (a 312 byte
  beacon failed without it), and a 639 byte beacon was still rejected,
  as calculated.

That last test only shows that the driver builds and downloads the
beacon. It does not show what is transmitted over the air.

Would you be fine with sending v2 as it is, with the commit message
stating exactly what was and was not tested? Or would you rather wait
until someone with a sniffer can run your checks? If there is a way to
check any of those points with a single adapter, I am happy to try it.

Best regards,
Carl