From: Sasha Levin <sashal@kernel.org>
To: Madhavan Srinivasan <maddy@linux.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: [PATCH] powerpc/irq: Fix build with CONFIG_PROC_FS=n
Date: Fri, 23 Oct 2026 17:15:03 -0400 [thread overview]
Message-ID: <20261023211503.3764302-1-sashal@kernel.org> (raw)
In-Reply-To: <2331292e-1a40-44ef-8776-9155e8e41f03@linux.ibm.com>
Commit fbb22ceaaf8f ("powerpc/irq: Make irqstats array based") made
arch_show_interrupts() call irq_proc_emit_counts(). That function lives
in kernel/irq/proc.c, which is only built with CONFIG_PROC_FS, so
kernels without procfs no longer link:
powerpc64-linux-ld: arch/powerpc/kernel/irq.o: in function `arch_show_interrupts':
arch/powerpc/kernel/irq.c:134:(.text+0x4b8c): undefined reference to `irq_proc_emit_counts'
arch_show_interrupts() is only called from irq_seq_show(), which is in
kernel/irq/proc.c as well, so build it only with CONFIG_PROC_FS, as x86
already does.
Fixes: fbb22ceaaf8f ("powerpc/irq: Make irqstats array based")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202609271531.8kf2NTjK-lkp@intel.com/
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
fbb22ceaaf8f came in with bb2235894a8a ("Merge tag 'powerpc-7.4-1' of
git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux"), so
mainline is affected now. Build-tested with the ppc64 randconfig from the
report, a ppc32 tinyconfig with LD_DEAD_CODE_DATA_ELIMINATION disabled
(it hides the error otherwise) and ppc64_defconfig.
arch/powerpc/kernel/irq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index bce546931a13b..55bcf0326f5a9 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -122,6 +122,7 @@ void inc_irq_stat_and_enable(enum irq_stat_counts which)
set_bit(which, irq_stat_count_show);
}
+#ifdef CONFIG_PROC_FS
int arch_show_interrupts(struct seq_file *p, int prec)
{
const struct irq_stat_info *info = irq_stat_info;
@@ -155,6 +156,7 @@ int arch_show_interrupts(struct seq_file *p, int prec)
#endif
return 0;
}
+#endif /* CONFIG_PROC_FS */
static int __init irq_init_stats(void)
{
--
2.53.0
next prev parent reply other threads:[~2026-10-23 21:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 4:49 [GIT PULL] Please pull powerpc/linux.git powerpc-7.4-1 tag Madhavan Srinivasan
2026-10-22 18:31 ` pr-tracker-bot
2026-10-23 21:15 ` Sasha Levin [this message]
2026-10-23 23:50 ` [PATCH] powerpc/irq: Fix build with CONFIG_PROC_FS=n Linus Torvalds
2026-10-26 4:26 ` Madhavan Srinivasan
2026-10-24 0:09 ` Ritesh Harjani
2026-10-24 7:30 ` Shrikanth Hegde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261023211503.3764302-1-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=ritesh.list@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.