From: Greg KH <gregkh@linuxfoundation.org>
To: Alex Elder <elder@riscstar.com>
Cc: pavankumaryalagada@gmail.com, greybus-dev@lists.linaro.org,
outreachy@lists.linux.dev, pure.logic@nexus-software.ie,
johan@kernel.org, elder@kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: greybus: loopback: Use fsleep() for delay
Date: Fri, 23 Oct 2026 15:04:01 +0200 [thread overview]
Message-ID: <2026102338-rack-garland-2a29@gregkh> (raw)
In-Reply-To: <a411ee0e-22c4-4797-9fdc-3ac11fa20d60@riscstar.com>
On Fri, Oct 23, 2026 at 07:48:54AM -0500, Alex Elder wrote:
> On 10/22/26 3:24 PM, pavankumaryalagada@gmail.com wrote:
> > From: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
> >
> > In the loopback function, usleep_range() is used for short delays
> > and msleep() for longer delays. This requires choosing the delay
> > function based on the requested time and converting microseconds
> > to milliseconds when using msleep().
> >
> > Replace both functions with fsleep(), which chooses a delay
> > delay method based on the requested time. For short delays,
>
> s/delay delay/delay/
>
> I think "checkpatch.pl" would have caught this.
>
> Maybe Greg can fix this up.
Nope, not for staging patches, this is for "learning" :)
thanks.
greg k-h
next prev parent reply other threads:[~2026-10-23 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 20:24 [PATCH v2] staging: greybus: loopback: Use fsleep() for delay pavankumaryalagada
2026-10-23 12:48 ` Alex Elder
2026-10-23 13:04 ` Greg KH [this message]
2026-10-23 13:18 ` Alex Elder
2026-10-23 14:14 ` Yalagada Pavan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026102338-rack-garland-2a29@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=elder@riscstar.com \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=pavankumaryalagada@gmail.com \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.