From: Greg KH <gregkh@linuxfoundation.org>
To: Timofey Zakharcuk <timofey.zakharchuk.research@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Ahmet Sezgin Duran <ahmet@sezginduran.net>
Subject: Re: [PATCH v2] staging: sm750fb: fix resource leaks on probe error
Date: Fri, 23 Oct 2026 15:34:41 +0200 [thread overview]
Message-ID: <2026102351-activist-quantum-3e31@gregkh> (raw)
In-Reply-To: <CAOm0KL_gbV=PY9DzjcsgqUOUjRK=vc--3q0c6LD_uDfbD0AFNQ@mail.gmail.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Mon, Oct 19, 2026 at 02:46:35PM +0300, Timofey Zakharcuk wrote:
> hi Greg,
> it was found by manual code inspection by noticing the asymmetry
> between the resources
> allocated pci probe (and freed in pci remove ) versus the cleanup
> performed in the release_fb error path:
>
> it was verified with checkpatch.pl
That verifies style only, not anything else.
> i don't have access to the physical sm750 hardware to test on real silicon.
I will have to drop this until it can be tested on real hardware as
obviously you are changing the existing logic here.
thanks,
greg k-h
prev parent reply other threads:[~2026-10-23 13:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 17:50 [PATCH v2] staging: sm750fb: fix resource leaks on probe error Tymofiy Zakharchuk
2026-10-13 13:39 ` Greg KH
2026-10-19 11:46 ` Timofey Zakharcuk
2026-10-23 13:34 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026102351-activist-quantum-3e31@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ahmet@sezginduran.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=timofey.zakharchuk.research@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.