All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mehmet Fide <mehmet.fide@gmail.com>
To: Francesco Dolcini <francesco.dolcini@toradex.com>
Cc: Tom Rini <trini@konsulko.com>,
	Mattijs Korpershoek <mkorpershoek@kernel.org>,
	Lukasz Majewski <lukma@nabladev.com>,
	u-boot@lists.u-boot-project.org, mehmet.fide@screeningeagle.com
Subject: [PATCH] colibri_vf: separate the partition numbers in dfu_alt_info with a space
Date: Sat, 24 Oct 2026 13:34:59 +0200	[thread overview]
Message-ID: <20261024113459.3259910-1-mehmet.fide@gmail.com> (raw)

From: Mehmet Fide <mehmet.fide@screeningeagle.com>

Since commit 53b406369e9d ("DFU: Check the number of arguments and
argument string strictly") the NAND backend takes an entry as
"<name> part <dev> <part>", three arguments. The default dfu_alt_info
of colibri_vf still uses the older "part 0,1" form, two arguments, so
its first entry already fails with -EINVAL and "dfu 0 nand 0" returns
at once, before the gadget starts.

Separate the device and the partition number with a space. The
partitions stay the same: vf-bcb, u-boot and ubi.

Fixes: 53b406369e9d ("DFU: Check the number of arguments and argument string strictly")
Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
---

Notes:
    Tested on a Colibri VF50 with the ehci-vf series [1] applied, which
    the gadget on usb0 needs to start at all: after "env default -f
    dfu_alt_info", "dfu 0 nand 0 list" shows vf-bcb, u-boot and ubi, and
    "dfu 0 nand 0" enumerates on a host and stops at Ctrl-C. With the old
    value the list fails at once.
    
    [1] https://lore.kernel.org/u-boot/20261023111559.4081795-1-mehmet.fide@gmail.com/

 include/configs/colibri_vf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/colibri_vf.h b/include/configs/colibri_vf.h
index 60f31389fd4..060e0ac3fe2 100644
--- a/include/configs/colibri_vf.h
+++ b/include/configs/colibri_vf.h
@@ -45,7 +45,7 @@
 #undef BOOTENV_RUN_NET_USB_START
 #define BOOTENV_RUN_NET_USB_START ""
 
-#define DFU_ALT_NAND_INFO "vf-bcb part 0,1;u-boot part 0,2;ubi part 0,4"
+#define DFU_ALT_NAND_INFO "vf-bcb part 0 1;u-boot part 0 2;ubi part 0 4"
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	BOOTENV \

base-commit: f97bb5c1ad78e95856917b92c7270c82d4b11e21
-- 
2.55.0


             reply	other threads:[~2026-10-24 11:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 11:34 Mehmet Fide [this message]
2026-10-25 18:33 ` [PATCH] colibri_vf: separate the partition numbers in dfu_alt_info with a space Francesco Dolcini
2026-10-26  9:48 ` Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024113459.3259910-1-mehmet.fide@gmail.com \
    --to=mehmet.fide@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=lukma@nabladev.com \
    --cc=mehmet.fide@screeningeagle.com \
    --cc=mkorpershoek@kernel.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.