All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen-Yu Yeh <chenyou910331@gmail.com>
To: Minas Harutyunyan <hminas@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Inochi Amaoto <inochiama@gmail.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chen-Yu Yeh <chenyou910331@gmail.com>
Subject: [PATCH] usb: dwc2: Disable gadget descriptor DMA for Sophgo CV18XX/SG200X
Date: Sat, 24 Oct 2026 19:52:20 +0800	[thread overview]
Message-ID: <20261024115220.823159-1-chenyou910331@gmail.com> (raw)

dwc2_set_cv1800_params() disables gadget DMA (g_dma) but leaves
g_dma_desc at its default, which dwc2_set_default_params() takes from
the hardware capability. Descriptor DMA requires g_dma, so
dwc2_check_params() rejects the combination at probe time:

  dwc2 4340000.usb: dwc2_check_params: Invalid parameter g_dma_desc=1

The check then clears g_dma_desc, so the final configuration is
already correct and only the warning is spurious. Disable g_dma_desc
together with g_dma in the platform parameters instead.

The gadget parameters are only set up when dr_mode is "peripheral" or
"otg". All in-tree CV18XX/SG200X boards use "host", which is why this
has gone unnoticed.

Tested on Milk-V Duo 256M (SG2002) with CONFIG_USB_DWC2_DUAL_ROLE=y and
dr_mode = "peripheral": the warning is gone.

Fixes: 63aa7ab955e7 ("usb: dwc2: add support for Sophgo CV18XX/SG200X series SoC")
Signed-off-by: Chen-Yu Yeh <chenyou910331@gmail.com>
---
 drivers/usb/dwc2/params.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index 091bfcfef753..6941705e426d 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -226,6 +226,7 @@ static void dwc2_set_cv1800_params(struct dwc2_hsotg *hsotg)
 	p->otg_caps.srp_support = false;
 	p->host_dma = false;
 	p->g_dma = false;
+	p->g_dma_desc = false;
 	p->speed = DWC2_SPEED_PARAM_HIGH;
 	p->phy_type = DWC2_PHY_TYPE_PARAM_UTMI;
 	p->phy_utmi_width = 16;
-- 
2.43.0


             reply	other threads:[~2026-10-24 11:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24 11:52 Chen-Yu Yeh [this message]
2026-10-24 11:56 ` [PATCH] usb: dwc2: Disable gadget descriptor DMA for Sophgo CV18XX/SG200X sashiko-bot
2026-11-05  0:26 ` Thinh Nguyen
  -- strict thread matches above, loose matches on Subject: below --
2026-10-29  7:32 Vadim Yuzifovich
     [not found] <CAH_=YdA5Rff14pbjoLp-Mg-n1yLqN0wQMUK5Xj2dB1OdR9-4RQ@mail.gmail.com>
2026-11-02 12:12 ` 葉宸佑

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024115220.823159-1-chenyou910331@gmail.com \
    --to=chenyou910331@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hminas@synopsys.com \
    --cc=inochiama@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.