From: Aditya Nagar <dev.adityanagar@gmail.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Aditya Nagar <dev.adityanagar@gmail.com>
Subject: [PATCH] staging: sm750fb: constify the pointer array g_fbmode
Date: Sat, 24 Oct 2026 19:00:37 +0530 [thread overview]
Message-ID: <20261024133037.160112-1-dev.adityanagar@gmail.com> (raw)
Make g_fbmode a const array of const pointers since the pointers
are never reassigned after initialization.
This fixes the following checkpatch warning:
static const char * array should probably be static const char * const
Signed-off-by: Aditya Nagar <dev.adityanagar@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 8b93bfeb2..c3f391cdd 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -12,7 +12,7 @@
static int g_hwcursor = 1;
static int g_noaccel __ro_after_init;
static int g_nomtrr __ro_after_init;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview __ro_after_init;
--
2.56.0
next reply other threads:[~2026-10-24 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 13:30 Aditya Nagar [this message]
2026-10-25 0:17 ` [PATCH] staging: sm750fb: constify the pointer array g_fbmode kernel test robot
[not found] ` <CAHLX7j4HHBsBZnPbP2mRMV_7t1Hwai6fLMD6sy_BDG7LnSgoCw@mail.gmail.com>
2026-10-25 4:04 ` Aditya Nagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261024133037.160112-1-dev.adityanagar@gmail.com \
--to=dev.adityanagar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.