Re: [PATCH net] octeontx2-af: Fix npc_delete_flow counter read for cn20k

[kernel test robot <lkp@intel.com>]

Hi vmukunda,

kernel test robot noticed the following build errors:

[auto build test ERROR on net/main]

url:    https://github.com/intel-lab-lkp/linux/commits/vmukunda/octeontx2-af-Fix-npc_delete_flow-counter-read-for-cn20k/20261023-100112
base:   net/main
patch link:    https://lore.kernel.org/r/20261023100112.3402726-1-vmukunda%40marvell.com
patch subject: [PATCH net] octeontx2-af: Fix npc_delete_flow counter read for cn20k
config: s390-allyesconfig (https://download.01.org/0day-ci/archive/20261024/202610241814.S7V8CsQq-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 16.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261024/202610241814.S7V8CsQq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610241814.S7V8CsQq-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/net/ethernet/marvell/octeontx2/af/rvu.h:13,
                    from drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:11:
   drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c: In function 'rvu_mbox_handler_npc_delete_flow':
>> drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:1962:58: error: 'rvu_pdev' undeclared (first use in this function)
    1962 |                                 if (blkaddr && !is_cn20k(rvu_pdev))
         |                                                          ^~~~~~~~
   include/linux/soc/marvell/silicons.h:22:41: note: in definition of macro 'is_cn20k'
      22 | #define is_cn20k(pdev)          ((void)(pdev), 0)
         |                                         ^~~~
   drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:1962:58: note: each undeclared identifier is reported only once for each function it appears in
   include/linux/soc/marvell/silicons.h:22:41: note: in definition of macro 'is_cn20k'
      22 | #define is_cn20k(pdev)          ((void)(pdev), 0)
         |                                         ^~~~
   include/linux/soc/marvell/silicons.h:22:46: warning: left-hand operand of comma expression has no effect [-Wunused-value]
      22 | #define is_cn20k(pdev)          ((void)(pdev), 0)
         |                                              ^
   drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:1962:49: note: in expansion of macro 'is_cn20k'
    1962 |                                 if (blkaddr && !is_cn20k(rvu_pdev))
         |                                                 ^~~~~~~~


vim +/rvu_pdev +1962 drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c

  1932	
  1933	int rvu_mbox_handler_npc_delete_flow(struct rvu *rvu,
  1934					     struct npc_delete_flow_req *req,
  1935					     struct npc_delete_flow_rsp *rsp)
  1936	{
  1937		struct npc_mcam *mcam = &rvu->hw->mcam;
  1938		struct rvu_npc_mcam_rule *iter, *tmp;
  1939		u16 pcifunc = req->hdr.pcifunc;
  1940		struct list_head del_list;
  1941		int blkaddr;
  1942	
  1943		req->entry = npc_cn20k_vidx2idx(req->entry);
  1944		req->start = npc_cn20k_vidx2idx(req->start);
  1945		req->end = npc_cn20k_vidx2idx(req->end);
  1946	
  1947		INIT_LIST_HEAD(&del_list);
  1948	
  1949		mutex_lock(&mcam->lock);
  1950		list_for_each_entry_safe(iter, tmp, &mcam->mcam_rules, list) {
  1951			if (iter->owner == pcifunc) {
  1952				/* All rules */
  1953				if (req->all) {
  1954					list_move_tail(&iter->list, &del_list);
  1955				/* Range of rules */
  1956				} else if (req->end && iter->entry >= req->start &&
  1957					   iter->entry <= req->end) {
  1958					list_move_tail(&iter->list, &del_list);
  1959				/* single rule */
  1960				} else if (req->entry == iter->entry) {
  1961					blkaddr = rvu_get_blkaddr(rvu, BLKTYPE_NPC, 0);
> 1962					if (blkaddr && !is_cn20k(rvu_pdev))
  1963						rsp->cntr_val = rvu_read64(rvu, blkaddr,
  1964									   NPC_AF_MATCH_STATX(iter->cntr));
  1965					list_move_tail(&iter->list, &del_list);
  1966					break;
  1967				}
  1968			}
  1969		}
  1970		mutex_unlock(&mcam->lock);
  1971	
  1972		list_for_each_entry_safe(iter, tmp, &del_list, list) {
  1973			u16 entry = iter->entry;
  1974	
  1975			/* clear the mcam entry target pcifunc */
  1976			mcam->entry2target_pffunc[entry] = 0x0;
  1977			if (npc_delete_flow(rvu, iter, pcifunc))
  1978				dev_err(rvu->dev, "rule deletion failed for entry:%u",
  1979					entry);
  1980		}
  1981	
  1982		return 0;
  1983	}
  1984	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki