All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Steve Bayless <steve_bayless@keysight.com>,
	Guido Kiener <guido@kiener-muenchen.de>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Mathias Nyman <mathias.nyman@intel.com>
Subject: Re: [PATCH 0/4] usb: usbtmc: fix undersized high-speed bulk packets on xHCI
Date: Sat, 24 Oct 2026 22:23:51 +0200	[thread overview]
Message-ID: <20261024222351.396b0c8c.michal.pecio@gmail.com> (raw)
In-Reply-To: <bc5865736052c55683b2d3f2eeca0e01@tipi-net.de>

On Sat, 24 Oct 2026 13:17:11 +0200, Nicolai Buchwitz wrote:
> On 23.10.2026 20:26, Michal Pecio wrote:
> > I don't have any out of spec device, so I tunned a Cypress FX2 into
> > one - it exactly replays every received packet back to the host. I
> > found that power of two sizes from 1 to 512 work, except on Etron
> > HCs which only take 512. Guess we could have an exception for those.
> > 
> > So this seems very viable. I will turn it into a proper patch and
> > see what the maintainers think. Seems better than patching class
> > drivers.  
> 
> Thanks! If you need something testing with the devices I have at
> hand, please let me know.

Hmm, I blamed existing code and found that it actually solved some
reported compatibility issues. Devices that specify bogus packet size
(that they don't really care about) do exist. Somebody had a problem
similar to what I see with Etron (maybe it was Etron), somebody's AMD
chip didn't like packet size of 4. Using legal sizes helped them.

I think I will restrict this to plausible values and default to 512.

Testing which could help is to check various xHCI controllers if they
support those 64 byte endpoints or not. Just because Microsoft and
Chinese TE vendors do something doesn't necessarily mean it's good ;)

The Etron issue is real and Windows seems to have no solution for it
(instant yellow exclamation mark on connection). Better to avoid such
drama with devices that don't care. Hopefully it's unique to Etron.

Regards,
Michal

      reply	other threads:[~2026-10-24 20:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 14:33 [PATCH 0/4] usb: usbtmc: fix undersized high-speed bulk packets on xHCI Nicolai Buchwitz
2026-10-20 14:33 ` [PATCH 1/4] usb: usbtmc: handle undersized high-speed bulk IN packets Nicolai Buchwitz
2026-10-20 14:46   ` sashiko-bot
2026-10-20 14:33 ` [PATCH 2/4] usb: usbtmc: handle undersized high-speed bulk OUT packets Nicolai Buchwitz
2026-10-20 14:39   ` sashiko-bot
2026-10-20 14:33 ` [PATCH 3/4] usb: usbtmc: add Rigol DP800 and DS1000Z to the packet I/O quirk table Nicolai Buchwitz
2026-10-20 14:41   ` sashiko-bot
2026-10-20 14:33 ` [PATCH 4/4] usb: usbtmc: send a ZLP after a full last packet in packet I/O mode Nicolai Buchwitz
2026-10-20 14:46   ` sashiko-bot
2026-10-20 16:42 ` [PATCH 0/4] usb: usbtmc: fix undersized high-speed bulk packets on xHCI Michal Pecio
2026-10-20 18:33   ` Nicolai Buchwitz
2026-10-20 21:12     ` guido
2026-10-21  7:46       ` Nicolai Buchwitz
2026-10-21 12:29         ` Guido Kiener
2026-10-20 22:56     ` Michal Pecio
2026-10-21  7:42       ` Nicolai Buchwitz
2026-10-21  9:34       ` Nicolai Buchwitz
2026-10-23 18:26         ` Michal Pecio
2026-10-24 11:17           ` Nicolai Buchwitz
2026-10-24 20:23             ` Michal Pecio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261024222351.396b0c8c.michal.pecio@gmail.com \
    --to=michal.pecio@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guido@kiener-muenchen.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=nb@tipi-net.de \
    --cc=stable@vger.kernel.org \
    --cc=steve_bayless@keysight.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.