From: Aditya Nagar <dev.adityanagar@gmail.com>
To: Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Aditya Nagar <dev.adityanagar@gmail.com>
Subject: [PATCH] staging: fbtft: remove unused argument from FBTFT_SPI_DRIVER()
Date: Sun, 25 Oct 2026 10:51:36 +0530 [thread overview]
Message-ID: <20261025052136.389541-1-dev.adityanagar@gmail.com> (raw)
The _compatible argument of FBTFT_SPI_DRIVER() is never used in the
macro body. The device tree match table is created separately by
FBTFT_DT_TABLE() in both callers, FBTFT_REGISTER_DRIVER() and
FBTFT_REGISTER_SPI_DRIVER().
Drop the argument and update both callers. No functional change.
The argument has been unused since the macro was introduced in commit
c222ea5d2f33 ("staging: fbtft: Deduplicate driver registration macros").
Found with checkpatch.pl (MACRO_ARG_UNUSED). The change was prepared
with the help of an AI coding assistant (Claude); I reviewed it and
build-tested all fbtft drivers with W=1.
Signed-off-by: Aditya Nagar <dev.adityanagar@gmail.com>
---
drivers/staging/fbtft/fbtft.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 40a7567df..62d5c39d7 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -279,7 +279,7 @@ static const struct of_device_id dt_ids[] = { \
}; \
MODULE_DEVICE_TABLE(of, dt_ids);
-#define FBTFT_SPI_DRIVER(_name, _compatible, _display, _spi_ids) \
+#define FBTFT_SPI_DRIVER(_name, _display, _spi_ids) \
\
static int fbtft_driver_probe_spi(struct spi_device *spi) \
{ \
@@ -319,7 +319,7 @@ static void fbtft_driver_remove_pdev(struct platform_device *pdev) \
\
FBTFT_DT_TABLE(_compatible) \
\
-FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL) \
+FBTFT_SPI_DRIVER(_name, _display, NULL) \
\
static struct platform_driver fbtft_driver_platform_driver = { \
.driver = { \
@@ -363,7 +363,7 @@ static const struct spi_device_id spi_ids[] = { \
}; \
MODULE_DEVICE_TABLE(spi, spi_ids); \
\
-FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids) \
+FBTFT_SPI_DRIVER(_name, _display, spi_ids) \
\
module_spi_driver(fbtft_driver_spi_driver);
base-commit: 4a177d5e688e8e82113f7a32d6f75f0bab9658c4
--
2.56.0
next reply other threads:[~2026-10-25 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 5:21 Aditya Nagar [this message]
2026-10-25 5:55 ` [PATCH] staging: fbtft: remove unused argument from FBTFT_SPI_DRIVER() Greg Kroah-Hartman
2026-10-25 6:00 ` Aditya Nagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261025052136.389541-1-dev.adityanagar@gmail.com \
--to=dev.adityanagar@gmail.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.