From: Shawn Lin <shawn.lin@linux.dev>
To: Ulf Hansson <ulfh@kernel.org>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH] mmc: core: Fix wrong comments in the regulator helpers
Date: Mon, 26 Oct 2026 15:00:29 +0800 [thread overview]
Message-ID: <20261026070029.1108506-1-shawn.lin@linux.dev> (raw)
From: Shawn Lin <shawn.lin@rock-chips.com>
mmc_ocrbitnum_to_vdd() stores the voltage range in microvolts, as the
min_uV and max_uV argument names say, but its kernel-doc documents the
unit as mV. Fix the unit.
mmc_regulator_disable_vqmmc() returns void, but its kernel-doc claims
that it returns 0 or an errno. Drop that sentence.
No functional change.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/core/regulator.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/core/regulator.c b/drivers/mmc/core/regulator.c
index a85179f1a4de..bbc773c647fa 100644
--- a/drivers/mmc/core/regulator.c
+++ b/drivers/mmc/core/regulator.c
@@ -19,8 +19,8 @@
/**
* mmc_ocrbitnum_to_vdd - Convert a OCR bit number to its voltage
* @vdd_bit: OCR bit number
- * @min_uV: minimum voltage value (mV)
- * @max_uV: maximum voltage value (mV)
+ * @min_uV: minimum voltage value (uV)
+ * @max_uV: maximum voltage value (uV)
*
* This function returns the voltage range according to the provided OCR
* bit number. If conversion is not possible a negative errno value returned.
@@ -418,7 +418,7 @@ EXPORT_SYMBOL_GPL(mmc_regulator_enable_vqmmc);
* mmc_regulator_disable_vqmmc - disable VQMMC regulator for a host
* @mmc: the host to regulate
*
- * Returns 0 or errno. Disables the regulator for vqmmc.
+ * Disables the regulator for vqmmc.
* Keeps track of the enable status for ensuring that calls to
* regulator_enable/disable are balanced.
*/
--
2.25.1
next reply other threads:[~2026-10-26 7:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 7:00 Shawn Lin [this message]
2026-10-28 17:15 ` [PATCH] mmc: core: Fix wrong comments in the regulator helpers Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026070029.1108506-1-shawn.lin@linux.dev \
--to=shawn.lin@linux.dev \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.