From: Adriano Cordova <adrianox@gmail.com>
To: Serge Hallyn <serge@hallyn.com>
Cc: Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
linux-security-module@vger.kernel.org,
Adriano Cordova <adrianox@gmail.com>
Subject: [PATCH v3] security: commoncap: drop stale CAP_FS_MASK FIXME
Date: Mon, 26 Oct 2026 10:10:10 -0300 [thread overview]
Message-ID: <20261026131010.1822069-1-adrianox@gmail.com> (raw)
CAP_FS_SET is exactly the set of capabilities that an fsuid of 0
historically granted (see CAP_FS_MASK in include/linux/capability.h),
so cap_task_fix_setuid() drops that set from the effective set when
fsuid leaves 0. Remove the stale FIXME.
Signed-off-by: Adriano Cordova <adrianox@gmail.com>
---
v3: just drop the FIXME instead of replacing it with another explanation.
security/commoncap.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/security/commoncap.c b/security/commoncap.c
index 3399535808fe..484d2b9256e9 100644
--- a/security/commoncap.c
+++ b/security/commoncap.c
@@ -1171,9 +1171,6 @@ int cap_task_fix_setuid(struct cred *new, const struct cred *old, int flags)
case LSM_SETID_FS:
/* juggle the capabilities to follow FSUID changes, unless
* otherwise suppressed
- *
- * FIXME - is fsuser used for all CAP_FS_MASK capabilities?
- * if not, we might be a bit too harsh here.
*/
if (!issecure(SECURE_NO_SETUID_FIXUP)) {
kuid_t root_uid = make_kuid(old->user_ns, 0);
--
2.51.0
next reply other threads:[~2026-10-26 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 13:10 Adriano Cordova [this message]
2026-10-26 13:12 ` [PATCH v3] security: commoncap: drop stale CAP_FS_MASK FIXME sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026131010.1822069-1-adrianox@gmail.com \
--to=adrianox@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.