All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jimmy Zuber <jamz@amazon.com>
To: NeilBrown <neil@brown.name>
Cc: Miklos Szeredi <miklos@szeredi.hu>, <fuse-devel@lists.linux.dev>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
	"Bernd Schubert" <bernd@bsbernd.com>,
	Jim Harris <jiharris@nvidia.com>,
	"Horst Birthelmer" <horst@birthelmer.de>,
	Luis Henriques <luis@igalia.com>
Subject: Re: [PATCH 1/3] fuse: add FUSE_OPEN_ATOMIC
Date: Mon, 26 Oct 2026 17:07:44 +0000	[thread overview]
Message-ID: <20261026170744.948701-1-jamz@amazon.com> (raw)
In-Reply-To: <179264679002.1724252.4479504779598097455@noble.neil.brown.name>

On Thu, 22 Oct 2026, NeilBrown wrote:
> Almost all other filesystems use d_tmpfile() for tmp-files (which calls
> d_instantiate). Is there a reason that fuse cannot use d_tmpfile()?

fuse_tmpfile() follows a slightly different pattern than d_tmpfile(). A
fuse tmpfile shows up in /proc as "<dir>// (deleted)", whereas d_tmpfile()
renames the dentry so that it shows up as "<dir>/#<ino> (deleted)". Also,
fuse gets nlink for the tmpfile from the server, while d_tmpfile()
decrements it. Reusing d_tmpfile() seems like it would be a behavior
change, which I'd like to avoid.

  reply	other threads:[~2026-10-26 17:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 14:16 [PATCH 0/3] fuse: atomic open jamz
2026-10-20 14:16 ` [PATCH 1/3] fuse: add FUSE_OPEN_ATOMIC jamz
2026-10-20 23:23   ` NeilBrown
2026-10-22  1:45     ` Jimmy Zuber
2026-10-22  5:26       ` NeilBrown
2026-10-26 17:07         ` Jimmy Zuber [this message]
2026-10-20 14:16 ` [PATCH 2/3] fuse: open cached files with FUSE_OPEN_ATOMIC jamz
2026-10-20 14:16 ` [PATCH 3/3] selftests/fuse: add test for FUSE_OPEN_ATOMIC jamz
2026-10-20 23:33 ` [PATCH 0/3] fuse: atomic open NeilBrown
2026-10-22  1:46   ` Jimmy Zuber
2026-10-22  5:30     ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026170744.948701-1-jamz@amazon.com \
    --to=jamz@amazon.com \
    --cc=bernd@bsbernd.com \
    --cc=fuse-devel@lists.linux.dev \
    --cc=horst@birthelmer.de \
    --cc=jiharris@nvidia.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luis@igalia.com \
    --cc=miklos@szeredi.hu \
    --cc=neil@brown.name \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.