All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Watt <jpewhacker@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Joshua Watt <JPEWhacker@gmail.com>
Subject: [OE-core][PATCH 1/3] lib/oe/license.py: Fix documentation of parse_legacy_license()
Date: Mon, 26 Oct 2026 16:06:33 -0600	[thread overview]
Message-ID: <20261026220751.2480577-2-JPEWhacker@gmail.com> (raw)
In-Reply-To: <20261026220751.2480577-1-JPEWhacker@gmail.com>

The function documentation was incorrect in that it doesn't check if the
license text exists. This must be done with get_license_path()

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
---
 meta/lib/oe/license.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/lib/oe/license.py b/meta/lib/oe/license.py
index bd1d85ad5f..e2a2bcc47d 100644
--- a/meta/lib/oe/license.py
+++ b/meta/lib/oe/license.py
@@ -425,8 +425,8 @@ def parse_legacy_license(d, licensestr):
     once legacy licenses are not longer allowed.
 
     Unknown license IDs in the string are automatically converted to
-    LicenseRefs, assuming that they are provided as either a common license
-    file or a NO_GENERIC_LICENSE
+    LicenseRefs. To check if a LicenseRef actually exists, use
+    get_license_path()
     """
     licensestr = _substitute_legacy_license(licensestr)
     if licensestr is None:
-- 
2.56.0


  reply	other threads:[~2026-10-26 22:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 22:06 [OE-core][PATCH 0/3] Fix incomplete license expressions being preferred over complete ones Joshua Watt
2026-10-26 22:06 ` Joshua Watt [this message]
2026-10-26 22:06 ` [OE-core][PATCH 2/3] lib/oe/sbom.py: Fix partial licenses masking " Joshua Watt
2026-10-26 22:06 ` [OE-core][PATCH 3/3] lib/oe/sbom.py: Split deduplication of CreationInfo Joshua Watt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026220751.2480577-2-JPEWhacker@gmail.com \
    --to=jpewhacker@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.