From: Eric Biggers <ebiggers@kernel.org>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
keyrings@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Benjamin Marzinski <bmarzins@redhat.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Shuah Khan <shuah@kernel.org>,
Christian Brauner <brauner@kernel.org>,
"open list:DEVICE-MAPPER (LVM)" <dm-devel@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>,
"open list:FSVERITY: READ-ONLY FILE-BASED AUTHENTICITY PRO..."
<fsverity@lists.linux.dev>,
"open list:RHASHTABLE" <linux-crypto@vger.kernel.org>,
"open list:SECURITY SUBSYSTEM"
<linux-security-module@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH v3 4/6] KEYS: Introduce keyring_is_empty()
Date: Mon, 26 Oct 2026 16:55:28 -0700 [thread overview]
Message-ID: <20261026235528.GA2395@quark> (raw)
In-Reply-To: <20261025001105.1824178-5-jarkko@kernel.org>
On Sun, Oct 25, 2026 at 03:10:12AM +0300, Jarkko Sakkinen wrote:
> +/**
> + * keyring_is_empty - Check whether a keyring contains any links
> + * @keyring: The keyring to check.
> + */
"contains any links" => "contains no links"? Or even just "is empty".
Otherwise it sounds backwards.
Note that another "is the keyring empty" check just showed up in
mainline in kernel/bpf/keys.c. So a new version of this patch will be
needed to update that one too.
Otherwise this patch looks good.
- Eric
next prev parent reply other threads:[~2026-10-26 23:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 0:10 [PATCH v3 0/6] KEYS: Replace assoc_array with rhashtable Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 1/6] KEYS: Expand key->{datalen,quotalen} to unsigned int Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 2/6] KEYS: Reject descriptions larger than KEY_MAX_DESC_SIZE Jarkko Sakkinen
2026-10-25 0:53 ` sashiko-bot
2026-10-25 0:10 ` [PATCH v3 3/6] KEYS: Verify the key identity in __key_unlink_begin Jarkko Sakkinen
2026-10-25 0:53 ` sashiko-bot
2026-10-25 0:10 ` [PATCH v3 4/6] KEYS: Introduce keyring_is_empty() Jarkko Sakkinen
2026-10-25 0:51 ` sashiko-bot
2026-10-26 23:55 ` Eric Biggers [this message]
2026-10-27 0:01 ` Jarkko Sakkinen
2026-10-25 0:10 ` [PATCH v3 5/6] KEYS: Replace assoc_array with rhashtable Jarkko Sakkinen
2026-10-25 1:05 ` sashiko-bot
2026-10-25 3:35 ` Jarkko Sakkinen
2026-10-25 16:08 ` Jarkko Sakkinen
2026-10-27 1:29 ` Eric Biggers
2026-10-27 2:56 ` Jarkko Sakkinen
2026-10-27 3:00 ` Jarkko Sakkinen
2026-10-28 7:28 ` kernel test robot
2026-10-28 20:13 ` Jarkko Sakkinen
2026-10-29 8:43 ` kernel test robot
2026-10-25 0:10 ` [PATCH v3 6/6] lib: Remove assoc_array Jarkko Sakkinen
2026-10-26 23:57 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261026235528.GA2395@quark \
--to=ebiggers@kernel.org \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bmarzins@redhat.com \
--cc=brauner@kernel.org \
--cc=dhowells@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=fsverity@lists.linux.dev \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
--cc=snitzer@kernel.org \
--cc=tgraf@suug.ch \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.