From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793091433; b=IURHBThmA7DVUhjS2h1JSn13MxwT4x6wjCDeypkMeGYXhabRqYtM7QO/SxS0oBee093X jaOt3YX3uvXxDYQIXPhKliFrpA4rI4BhjE+Rll7oB/wHExw2ZK2S62Dwoci+NDNud7ydO DY74za93aLdCmjp/KjXiLrQjo+QQ4JWcT/mFoWJJh+DtvKFfmisKxXeNonpxTw6RcW9Ov /dr18p4WpGhi/Wi/n1muqgntouta5ZeLzFzeMTAgaQ5DtEf1UdIW3/e62ljGyI+X7PSIb vOBiTWFZChezr6Bdh/rXx0sb6D13YRWcmnzCaiHwUnZQCv2XTJaa+5o/n3W5gIDjSXg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793091433; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=rQvPpajMEW3Pt0vqDNzVq8Uql9PTHirPe5iQ59zrcc0=; b=kh2oMIVb9MCNz+skklkx6GQ43Q8ij4S2CQOOf85paZgjG6LB03WBhcNydgpSXEYB0Xg+ +gCpDS/F32leDFiUciCtEMeaJEyWVPzQ5jrcgahGovd+7on6+2tro5h/IKXFoaG5HaSoy Abu7sXw3KUSwTp/oqTn6y6WpJtCZ0t/tR/eifrEsehskczFNBfW7nWjrw2Xu8c/vOuWID aqpYViX+Sfp+1Jmy2hBNpNgaAqQ2+9CY9irnSc5DtwcPwvE9w0ERPR+D8uIKBVXpH/UGC fsosN7JZXQObVbp6Z9ZsUnbYvNNQKO2kXEiTNltLJzen5lX3m7sxSgap10/8Moja5nQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=Oer+bUen; arc=none smtp.remote-ip=209.85.216.42 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4932C606A31A for ; Tue, 27 Oct 2026 08:57:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 4932C606A31A Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=Oer+bUen Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3ac6794fe45so2873206a91.0 for ; Tue, 27 Oct 2026 01:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1793091433; x=1793696233; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rQvPpajMEW3Pt0vqDNzVq8Uql9PTHirPe5iQ59zrcc0=; b=Oer+bUenZvvRQVR1jmGGc8r09Eh5uvcNUQ//3ybQfEqDA245e5l1S5dJJ186dM9pC0 VnN2CKtc/Cix4HWdkbUTjGrsKTx/W4G3QwS5BWEuHdzMc9E0BqryTFTHXZPHpzThmHMp E3hiiw9LRHlEBfKyubWFiG+kP/xVb+Q5BSMYwJHVZg2PXmB9s7niihWx1ZSLgAud2ITU 1K8vkqBL2/1YeuxbKfB5DTjnRLv7Xl9wyvFyqB2sUVnbXDaGmW1kp5igUyyl06pcVaI5 /rYcStD14swBtGbA8PnMqCi6p08Cu4zlo8fMCSGrbIOAjbmFBaeKKIPsbgnG1tv8fIVP 5lYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793091433; x=1793696233; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=rQvPpajMEW3Pt0vqDNzVq8Uql9PTHirPe5iQ59zrcc0=; b=AOStusLLhC0MbTPF5uwfG242Jvka8iriNtsilM6JUOT7p8wE4uGCrHKfQjxikIEcV0 BOvgff4RNAq2Pb3stAe4IhQyQ6ZKzbvke0GjTRbW3ygtq76sOz1MBjcQRhZmwx53mDuG 5UWziTZ1AT/SisRJzKCD799Fr0zR5eW1WWQNBzjiHbSqecTXwhZXw0irEd7cqGONTk+x 7cdOk+/3t9nRIldQx0gYvQUsH5Brn5M297niWx9OmxQL107UyCP+6Sa+pDcBtZkcGKb2 pzoV5k11JEgz7ZZjM+Lhi13yjOpEjOXTBDxaPZ+xwUDKrIuCFTayUvecZVRu4j8/gtCV JZNQ== X-Forwarded-Encrypted: i=1; AKwUvBz8/+oZRuxjH6Uc/UeHEZanGEz2oakmBZgo39yE/CCuzlT13CxM7TRGS0/c/Bq2wrFy35CULc15Np+M@vger.kernel.org X-Gm-Message-State: AFq9FYLB481Zha4rhCtD6gM9ENaeQ9aJpGlDI24ugux8O0hMhng/E28C putA49gAKkLGAlNoxxSXNC73y9AjxQbAIzQ1UiPg2gx93qfgJn6h/dTz X-Gm-Gg: AYBFou2ENpMNQNhStVWNXbGiHxYsymkI66npQC7ROcaDeiKgz2r7gdH9p1klyeI+KLv JyZvc/H1GRtG5GEHgXWAAT9Bggc6aIBtUcdy/wQS2BwQxaoX3ecYuwg/Jb783kzvNc6lHDMPhE3 7NK4kBhlzsLeqFCGzE5HsMRAm/lnEBQmo5m86Nu3UZx6qeRQOyczsY1gHwmrKtFPhNvoC9JX31O XSi5PT+GYY6w0RkmuYKZ742ZkNG7j1dhiX4kkZAX36e6AmZluQODCGFgxvJxahhm9cVFqT6ivfT HpoZjzyA4BkO58PDdJ9GfGwCfeeCjk7+7qztq9TRiN9lagZHUmgmUWtcR7smVieRbMamYLrJzV1 F/emWa3VWR4eNUPSVbSJMjfmWkx1MjIko9iZkB5b7kxcKpXp7fXNWbzVHBVcTpQ9jzNoU3viqm7 XuNPKT04z/Y7a/cT4Y3LZill9wSFWtZk9NYXW79+FsgS9QZSNYLQ3AlrRQDID32YIskRDY6FFxs MJ0KuaFRAQkyrwODlluIcGctvDr2BzYxsoGYEddc6WS2woIviDwJFeGgOXgCm+U3RqzPzXMvVBD MBIQnkuCHudu1EzNwAfesvmUZG6AhuOYku5+JylkrfivEHz5K0yQyL9h0KZPMv2AoCtjOxF13/x TJYjSmWAWCZsjKnIKiaIyF9D75ZqjwCg9zh2WVGWWscyeerCzLg9eilKyUXCeiV7Z233/Dmi5I8 q7Cw== X-Received: by 2002:a17:90b:2789:b0:3ac:adce:60be with SMTP id 98e67ed59e1d1-3adeaae6efcmr8052880a91.21.1793091432575; Tue, 27 Oct 2026 01:57:12 -0700 (PDT) Received: from EAIT-H54D9Q2FJQ.eait.uq.edu.au ([130.102.10.17]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ae4066aec8sm2794713a91.15.2026.10.27.01.57.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 27 Oct 2026 01:57:11 -0700 (PDT) From: Yu Zhang To: Bartosz Golaszewski , Linus Walleij Cc: Koichiro Den , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yu Zhang Subject: [PATCH v2] gpio: sim: fix the configfs lockup racing with mkdir/rmdir Date: Tue, 27 Oct 2026 18:56:53 +1000 Message-ID: <20261027085653.90471-1-yuz08559@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261026060049.60599-1-yuz08559@gmail.com> References: <20261026060049.60599-1-yuz08559@gmail.com> X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gpio_sim_device_lockup_configfs() depends (on activation) and undepends (on deactivation) the leaf configfs entries of a device. It walks dev->bank_list and bank->line_list without dev->lock, while the lists are modified and their nodes freed under dev->lock by the configfs make/release callbacks. It also walks the lists twice, once to depend and once to undepend, and the two walks can see different entries: - A hog created while the device is live is never depended on, but it is undepended on deactivation, hitting BUG_ON(sd->s_dependent_count < 1) in configfs_undepend_item(). The following is enough to trigger it: mkdir $G/dev $G/dev/bank0 $G/dev/bank0/line0 echo 1 > $G/dev/live mkdir $G/dev/bank0/line0/hog echo 0 > $G/dev/live - An entry that is being created or removed when the device goes live cannot be depended on (the WARN_ON() fires), but it is undepended later, hitting the same BUG_ON(). If it has already been unlinked, configfs_depend_item_unlocked() dereferences its NULL ci_group. Toggling "live" while concurrently creating and removing line and hog directories hits the WARN_ON() and then the BUG_ON() within a second. Hold the configfs subsystem mutex and dev->lock across the whole live transition. The subsystem mutex is what configfs holds when it links and unlinks entries and when it calls the make_group()/make_item() callbacks, which then take dev->lock, so the lock order is the same. Record the entries that were actually depended on and undepend exactly those. If an entry cannot be depended on because it is being created or removed, undo the dependencies already taken and fail with -EBUSY instead of warning. configfs_depend_item_unlocked() and configfs_undepend_item_unlocked() only take configfs_dirent_lock for an item of the caller's own subsystem, so calling them under these locks is fine. Fixes: 8bd76b3d3f3a ("gpio: sim: lock up configfs that an instantiated device depends on") Cc: stable@vger.kernel.org Signed-off-by: Yu Zhang --- drivers/gpio/gpio-sim.c | 109 +++++++++++++++++++++++++++++++--------- 1 file changed, 85 insertions(+), 24 deletions(-) diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c index 0c73bec..ad4affc 100644 --- a/drivers/gpio/gpio-sim.c +++ b/drivers/gpio/gpio-sim.c @@ -560,6 +560,10 @@ struct gpio_sim_device { struct mutex lock; struct list_head bank_list; + + /* Leaf entries depended on while the device is live. */ + struct config_item **deps; + unsigned int num_deps; }; static struct gpio_sim_device *to_gpio_sim_device(struct config_item *item) @@ -974,31 +978,81 @@ static void gpio_sim_device_deactivate(struct gpio_sim_device *dev) gpio_sim_remove_swnode_recursive(swnode); } -static void -gpio_sim_device_lockup_configfs(struct gpio_sim_device *dev, bool lock) +static void gpio_sim_device_unlock_configfs(struct gpio_sim_device *dev) +{ + unsigned int i; + + lockdep_assert_held(&dev->lock); + + for (i = 0; i < dev->num_deps; i++) + configfs_undepend_item_unlocked(dev->deps[i]); + + kfree(dev->deps); + dev->deps = NULL; + dev->num_deps = 0; +} + +static int gpio_sim_device_lockup_configfs(struct gpio_sim_device *dev) { struct configfs_subsystem *subsys = dev->group.cg_subsys; struct gpio_sim_bank *bank; struct gpio_sim_line *line; struct config_item *item; + unsigned int num = 0; + int ret; + + lockdep_assert_held(&subsys->su_mutex); + lockdep_assert_held(&dev->lock); /* * The device only needs to depend on leaf entries. This is * sufficient to lock up all the configfs entries that the * instantiated, alive device depends on. + * + * dev->lock keeps the bank and line lists stable and the subsystem + * mutex keeps the entries' ci_group stable. An entry that is still + * being created or removed cannot be depended on, in which case the + * device is not brought up. The entries that were actually depended + * on are recorded, so that exactly those are undepended when the + * device goes down. */ + list_for_each_entry(bank, &dev->bank_list, siblings) + list_for_each_entry(line, &bank->line_list, siblings) + num++; + + if (!num) + return 0; + + dev->deps = kzalloc_objs(*dev->deps, num); + if (!dev->deps) + return -ENOMEM; + list_for_each_entry(bank, &dev->bank_list, siblings) { list_for_each_entry(line, &bank->line_list, siblings) { item = line->hog ? &line->hog->item : &line->group.cg_item; - if (lock) - WARN_ON(configfs_depend_item_unlocked(subsys, - item)); - else - configfs_undepend_item_unlocked(item); + /* Already unlinked by a concurrent rmdir(). */ + if (!item->ci_group) { + ret = -EBUSY; + goto err_unlock; + } + + ret = configfs_depend_item_unlocked(subsys, item); + if (ret) { + ret = -EBUSY; + goto err_unlock; + } + + dev->deps[dev->num_deps++] = item; } } + + return 0; + +err_unlock: + gpio_sim_device_unlock_configfs(dev); + return ret; } static ssize_t @@ -1013,26 +1067,32 @@ gpio_sim_device_config_live_store(struct config_item *item, if (ret) return ret; - if (live) - gpio_sim_device_lockup_configfs(dev, true); - - scoped_guard(mutex, &dev->lock) { - if (live == gpio_sim_device_is_live(dev)) - ret = -EPERM; - else if (live) - ret = gpio_sim_device_activate(dev); - else - gpio_sim_device_deactivate(dev); - } - /* - * Undepend is required only if device disablement (live == 0) - * succeeds or if device enablement (live == 1) fails. + * Lock order: subsystem mutex, then dev->lock. This is the same + * order as in the make_group()/make_item() callbacks. */ - if (live == !!ret) - gpio_sim_device_lockup_configfs(dev, false); + guard(mutex)(&dev->group.cg_subsys->su_mutex); + guard(mutex)(&dev->lock); + + if (live == gpio_sim_device_is_live(dev)) + return -EPERM; + + if (live) { + ret = gpio_sim_device_lockup_configfs(dev); + if (ret) + return ret; - return ret ?: count; + ret = gpio_sim_device_activate(dev); + if (ret) { + gpio_sim_device_unlock_configfs(dev); + return ret; + } + } else { + gpio_sim_device_deactivate(dev); + gpio_sim_device_unlock_configfs(dev); + } + + return count; } CONFIGFS_ATTR(gpio_sim_device_config_, live); @@ -1546,6 +1606,7 @@ static void gpio_sim_device_config_group_release(struct config_item *item) mutex_destroy(&dev->lock); ida_free(&gpio_sim_ida, dev->id); + kfree(dev->deps); kfree(dev); } -- 2.43.0