From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BB77606A335 for ; Tue, 27 Oct 2026 09:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=PyD/s7RX; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KZiXeWzH DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=9KR4tQKKoouZdOn8TLp6tmMbElIQ1dBoDCjoVtfVPwU=; b=PyD/s7RX+8/1FhLaiQjN3wUHo8 W0FsOB6GLZzE1teJYIQho3DnUYZ2EP19Rc2C7QOhZX5i1XaMjrBqCXSdqwVCUw3p0sJ6oAzFmvFhS JkUzzeCgcvtwmUAs/vE/kiH7AejoJTPNwsXU6qYKzq1lCu79hicD9x+dbrEb/mmvtXbX89UGj9YjA X/SNXHgJtnEPIBKrQB7Cr6gksVGz1AlsqhbyyJzc61W7UaFOhFBBMBR5dahY1QkKCSz2E/BWkhPSU 7gRY0KsmdBCBJB/IejxXGyUtx7l3i2wTIQ5W3WIx513EWpvjjxa9jxYyEz/TdQkN7N2gaLtrn+xVk 4EdHZGzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLdSj-000000049lO-41Ef; Tue, 27 Oct 2026 09:27:21 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLdSj-000000049kt-12iu; Tue, 27 Oct 2026 09:27:21 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A3014601FB; Tue, 27 Oct 2026 09:27:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9670C1F01828; Tue, 27 Oct 2026 09:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793093240; bh=9KR4tQKKoouZdOn8TLp6tmMbElIQ1dBoDCjoVtfVPwU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KZiXeWzHGXuM3OWjZ9ZZmKwmS8io1B07UgzhX+UL//aC9IJce1cAv/G31tLlAqztV ViI2uZ2NoO1/vLNx7FvJuVWDrtTpIT1jWBuZXgAvRdGcu9HYkiXhnGtnD5JIkJYTA3 lAMomG+lUtjQfxw/m5Fz+hYLY1rHcqlvIoSE9tsYVRvjwBBkKu4ergTnoHykQGz5xD xwnYU9hIQxeABBklziX2I+QlAwse406Le/AcKBJ1GTYOKJmB4jfBuRpzzg+RAI/Fql uab6CyyjdeXEt5UiwQOu5bDTrr45h4M7ab5oAjloQs5LvgESUo6QhFs7jJcOZ5v8eS 3A+MqK6uEjapA== Date: Tue, 27 Oct 2026 09:27:14 +0000 From: Lee Jones To: Yaozhong Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Zhong , Zhang Qing , Joseph Chen , Sebastian Reichel , mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] dt-bindings: mfd: rk8xx: add board level power hold GPIOs Message-ID: <20261027092714.GH2195460@google.com> References: <20261027084511.1992-1-yaozhonguwl@gmail.com> <20261027084511.1992-2-yaozhonguwl@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261027084511.1992-2-yaozhonguwl@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Tue, 27 Oct 2026, Yaozhong Li wrote: > Some boards route "power hold" lines from the SoC into the board's power > circuitry. Those lines have to be held asserted while the system is > running and released before the PMIC shutdown request is written, > otherwise the rails can drop and come back up instead of staying off. > > Add power-hold-gpios to describe those lines and power-hold-delay-ms for > the settle time. The driver reads them for every RK8xx variant that is > the system power controller, so add them to all seven RK8xx schemas. > > The array is bounded at two entries. Firefly's vendor kernel handles > exactly two such lines, pmic,hold-gpio and pmic,stby-gpio, and its board > files use one or both of them, with an RK808 and with an RK818. > > The lines are released from the PMIC's power-off path, so they are only > meaningful when the PMIC is the system power controller. Require that. > A board adding these lines is expected to switch to the generic > system-power-controller property at the same time, so the deprecated > rockchip,system-power-controller spelling is not accepted here. > > Assisted-by: LLM > Signed-off-by: Yaozhong Li > --- > .../bindings/mfd/rockchip,rk801.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk805.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk806.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk808.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk816.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk817.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk818.yaml | 24 +++++++++++++++++++ Whoa! Is duplicating 200 lines really the best solution? -- Lee Jones From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 077F4606A327 for ; Tue, 27 Oct 2026 09:27:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TXww8yxm; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KZiXeWzH DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=k+tMS2TZUvR3y+zhQu5QilbA1j7Chq7dnIOE+xq3+4g=; b=TXww8yxmOEbLBQUlYPNOgz3hC6 SmM/9HKJ2w+GUku4XRliA9I7Fuixyfk11Ib+RL/L5WKfmqYPycokUYnAQM/rRGfQd6QdSF2d4snqX S7mIuNygEzWAS/Kcg20ZDDMW8iwPCcmzY78TVZ96682cYDI9SLlJRu7Spa0QJ5gR/4IFnYe0Qk7x6 e/gvxjXNxeITCZSY7FkRrwhEg4xkoQVitdgc6rri3T5oeMeZvprajZzjRIJGrfGCg7A+rYG5nNTKZ ykqUihyDa2WaU5Bv53vbRgNh9Gi1gv4nDAHYwGhj03AcrdM4eLR4aZuNiC+LRd8E8DEe+Yo1gLhfm H0Djzu2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLdSk-000000049li-0E3s; Tue, 27 Oct 2026 09:27:22 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLdSj-000000049kt-12iu; Tue, 27 Oct 2026 09:27:21 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A3014601FB; Tue, 27 Oct 2026 09:27:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9670C1F01828; Tue, 27 Oct 2026 09:27:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793093240; bh=9KR4tQKKoouZdOn8TLp6tmMbElIQ1dBoDCjoVtfVPwU=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=KZiXeWzHGXuM3OWjZ9ZZmKwmS8io1B07UgzhX+UL//aC9IJce1cAv/G31tLlAqztV ViI2uZ2NoO1/vLNx7FvJuVWDrtTpIT1jWBuZXgAvRdGcu9HYkiXhnGtnD5JIkJYTA3 lAMomG+lUtjQfxw/m5Fz+hYLY1rHcqlvIoSE9tsYVRvjwBBkKu4ergTnoHykQGz5xD xwnYU9hIQxeABBklziX2I+QlAwse406Le/AcKBJ1GTYOKJmB4jfBuRpzzg+RAI/Fql uab6CyyjdeXEt5UiwQOu5bDTrr45h4M7ab5oAjloQs5LvgESUo6QhFs7jJcOZ5v8eS 3A+MqK6uEjapA== Date: Tue, 27 Oct 2026 09:27:14 +0000 From: Lee Jones To: Yaozhong Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Zhong , Zhang Qing , Joseph Chen , Sebastian Reichel , mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] dt-bindings: mfd: rk8xx: add board level power hold GPIOs Message-ID: <20261027092714.GH2195460@google.com> References: <20261027084511.1992-1-yaozhonguwl@gmail.com> <20261027084511.1992-2-yaozhonguwl@gmail.com> X-Archived-By: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20261027084511.1992-2-yaozhonguwl@gmail.com> X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Tue, 27 Oct 2026, Yaozhong Li wrote: > Some boards route "power hold" lines from the SoC into the board's power > circuitry. Those lines have to be held asserted while the system is > running and released before the PMIC shutdown request is written, > otherwise the rails can drop and come back up instead of staying off. > > Add power-hold-gpios to describe those lines and power-hold-delay-ms for > the settle time. The driver reads them for every RK8xx variant that is > the system power controller, so add them to all seven RK8xx schemas. > > The array is bounded at two entries. Firefly's vendor kernel handles > exactly two such lines, pmic,hold-gpio and pmic,stby-gpio, and its board > files use one or both of them, with an RK808 and with an RK818. > > The lines are released from the PMIC's power-off path, so they are only > meaningful when the PMIC is the system power controller. Require that. > A board adding these lines is expected to switch to the generic > system-power-controller property at the same time, so the deprecated > rockchip,system-power-controller spelling is not accepted here. > > Assisted-by: LLM > Signed-off-by: Yaozhong Li > --- > .../bindings/mfd/rockchip,rk801.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk805.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk806.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk808.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk816.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk817.yaml | 24 +++++++++++++++++++ > .../bindings/mfd/rockchip,rk818.yaml | 24 +++++++++++++++++++ Whoa! Is duplicating 200 lines really the best solution? -- Lee Jones _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip