From: kernel test robot <lkp@intel.com>
To: "Chen-Yu Tsai" <wenst@chromium.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [wens:random-stuff 1/10] drivers/clk/meson/meson8b.c:3636:14: warning: unused variable 'notifier_clk'
Date: Tue, 27 Oct 2026 14:34:05 +0100 [thread overview]
Message-ID: <202610271406.SnQrnGTr-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/wens/linux.git random-stuff
head: 6c5d9e149cf308ead35a6bd9016a5f1c74a33cea
commit: 040fc32d92a1a50000f1c4cad511ce2148a53e89 [1/10] clk: meson: meson8b: Simplify notifier clock lookup
config: arm-randconfig-2001-20261027 (https://download.01.org/0day-ci/archive/20261027/202610271406.SnQrnGTr-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261027/202610271406.SnQrnGTr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610271406.SnQrnGTr-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/clk/meson/meson8b.c: In function 'meson8b_clkc_init_common':
>> drivers/clk/meson/meson8b.c:3636:14: warning: unused variable 'notifier_clk' [-Wunused-variable]
struct clk *notifier_clk;
^~~~~~~~~~~~
vim +/notifier_clk +3636 drivers/clk/meson/meson8b.c
5e4e480466e611f Neil Armstrong 2023-06-12 3630
cce433e6bc53b39 Martin Blumenstingl 2018-12-08 3631 static void __init meson8b_clkc_init_common(struct device_node *np,
5e4e480466e611f Neil Armstrong 2023-06-12 3632 struct meson_clk_hw_data *hw_clks)
189621726bc2f66 Martin Blumenstingl 2017-07-28 3633 {
189621726bc2f66 Martin Blumenstingl 2017-07-28 3634 struct meson8b_clk_reset *rstc;
89ab396d712f7c9 Liang He 2022-06-28 3635 struct device_node *parent_np;
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 @3636 struct clk *notifier_clk;
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3637 struct regmap *map;
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3638 int i, ret;
189621726bc2f66 Martin Blumenstingl 2017-07-28 3639
89ab396d712f7c9 Liang He 2022-06-28 3640 parent_np = of_get_parent(np);
89ab396d712f7c9 Liang He 2022-06-28 3641 map = syscon_node_to_regmap(parent_np);
89ab396d712f7c9 Liang He 2022-06-28 3642 of_node_put(parent_np);
bb6eddd1d28c9c4 Martin Blumenstingl 2018-10-28 3643 if (IS_ERR(map)) {
40e977400d21aab Martin Blumenstingl 2020-12-21 3644 pr_err("failed to get HHI regmap - Trying obsolete regs\n");
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3645 return;
bb6eddd1d28c9c4 Martin Blumenstingl 2018-10-28 3646 }
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3647
bf4afc53b77aeaa Linus Torvalds 2026-02-21 3648 rstc = kzalloc_obj(*rstc);
189621726bc2f66 Martin Blumenstingl 2017-07-28 3649 if (!rstc)
189621726bc2f66 Martin Blumenstingl 2017-07-28 3650 return;
189621726bc2f66 Martin Blumenstingl 2017-07-28 3651
189621726bc2f66 Martin Blumenstingl 2017-07-28 3652 /* Reset Controller */
93c873d68646165 Martin Blumenstingl 2018-07-21 3653 rstc->regmap = map;
189621726bc2f66 Martin Blumenstingl 2017-07-28 3654 rstc->reset.ops = &meson8b_clk_reset_ops;
189621726bc2f66 Martin Blumenstingl 2017-07-28 3655 rstc->reset.nr_resets = ARRAY_SIZE(meson8b_clk_reset_bits);
189621726bc2f66 Martin Blumenstingl 2017-07-28 3656 rstc->reset.of_node = np;
189621726bc2f66 Martin Blumenstingl 2017-07-28 3657 ret = reset_controller_register(&rstc->reset);
189621726bc2f66 Martin Blumenstingl 2017-07-28 3658 if (ret) {
189621726bc2f66 Martin Blumenstingl 2017-07-28 3659 pr_err("%s: Failed to register clkc reset controller: %d\n",
189621726bc2f66 Martin Blumenstingl 2017-07-28 3660 __func__, ret);
189621726bc2f66 Martin Blumenstingl 2017-07-28 3661 return;
189621726bc2f66 Martin Blumenstingl 2017-07-28 3662 }
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3663
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3664 /*
40e977400d21aab Martin Blumenstingl 2020-12-21 3665 * register all clks and start with the first used ID (which is
40e977400d21aab Martin Blumenstingl 2020-12-21 3666 * CLKID_PLL_FIXED)
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3667 */
5e4e480466e611f Neil Armstrong 2023-06-12 3668 for (i = CLKID_PLL_FIXED; i < hw_clks->num; i++) {
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3669 /* array might be sparse */
5e4e480466e611f Neil Armstrong 2023-06-12 3670 if (!hw_clks->hws[i])
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3671 continue;
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3672
5e4e480466e611f Neil Armstrong 2023-06-12 3673 ret = of_clk_hw_register(np, hw_clks->hws[i]);
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3674 if (ret)
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3675 return;
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3676 }
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3677
5e4e480466e611f Neil Armstrong 2023-06-12 3678 meson8b_cpu_nb_data.cpu_clk = hw_clks->hws[CLKID_CPUCLK];
cce433e6bc53b39 Martin Blumenstingl 2018-12-08 3679
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3680 /*
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3681 * FIXME we shouldn't program the muxes in notifier handlers. The
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3682 * tricky programming sequence will be handled by the forthcoming
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3683 * coordinated clock rates mechanism once that feature is released.
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3684 */
040fc32d92a1a50 Chen-Yu Tsai 2023-03-15 3685 ret = clk_notifier_register(meson8b_cpu_scale_out_sel.hw.clk, &meson8b_cpu_nb_data.nb);
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3686 if (ret) {
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3687 pr_err("%s: failed to register the CPU clock notifier\n",
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3688 __func__);
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3689 return;
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3690 }
7dc7eeb8c0875c4 Martin Blumenstingl 2018-11-15 3691
5e4e480466e611f Neil Armstrong 2023-06-12 3692 ret = of_clk_add_hw_provider(np, meson_clk_hw_get, hw_clks);
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3693 if (ret)
6291b8c5ac67d0f Martin Blumenstingl 2018-07-21 3694 pr_err("%s: failed to register clock provider\n", __func__);
189621726bc2f66 Martin Blumenstingl 2017-07-28 3695 }
189621726bc2f66 Martin Blumenstingl 2017-07-28 3696
:::::: The code at line 3636 was first introduced by commit
:::::: 7dc7eeb8c0875c4bb7607509d9270ad3fd726b6b clk: meson: meson8b: run from the XTAL when changing the CPU frequency
:::::: TO: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
:::::: CC: Neil Armstrong <narmstrong@baylibre.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-10-27 13:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202610271406.SnQrnGTr-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.