From: Christoph Hellwig <hch@lst.de>
To: shao.mingyin@zte.com.cn
Cc: mst@redhat.com, jasowangio@gmail.com,
virtualization@lists.linux.dev, pbonzini@redhat.com,
stefanha@redhat.com, eperezma@redhat.com, hch@lst.de,
dlemoal@kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: Fix zone append sector reporting in batched completion
Date: Tue, 27 Oct 2026 16:06:55 +0100 [thread overview]
Message-ID: <20261027150654.GA14436@lst.de> (raw)
In-Reply-To: <202610261955196384aSLGuy3_0MiTvlYXVdiC@zte.com.cn>
On Mon, Oct 26, 2026 at 07:55:19PM +0800, shao.mingyin@zte.com.cn wrote:
> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>
> For zone append, the block layer copies req->__sector back into the
> bio in blk_zone_append_update_request_bio(), so the driver must update
> req->__sector with the sector reported by the device.
> virtblk_request_done() does that, but the batched completion path used
> by virtblk_poll() only unmaps and cleans up the requests before calling
> blk_mq_end_request_batch().
>
> A zone append completed through polling therefore keeps the sector that
> was assigned at submission time, and the file system or application sees
> the wrong LBA for the written data.
>
> Move the sector update into a helper and call it from both completion
> paths.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Can you add something to blktests to exercises this?
next prev parent reply other threads:[~2026-10-27 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-26 11:55 [PATCH] virtio-blk: Fix zone append sector reporting in batched completion shao.mingyin
2026-10-26 12:11 ` sashiko-bot
2026-10-27 15:06 ` Christoph Hellwig [this message]
2026-10-27 19:17 ` Stefan Hajnoczi
2026-10-27 19:19 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027150654.GA14436@lst.de \
--to=hch@lst.de \
--cc=dlemoal@kernel.org \
--cc=eperezma@redhat.com \
--cc=jasowangio@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=shao.mingyin@zte.com.cn \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.