All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@kernel.org>
To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Cc: "Masami Hiramatsu" <mhiramat@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Vineeth Pillai" <vineeth@bitbyteword.org>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Aaron Conole" <aconole@redhat.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Anna-Maria Behnsen" <anna-maria@linutronix.de>,
	"Borislav Petkov" <bp@alien8.de>,
	"Chanwoo Choi" <cw00.choi@samsung.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Danilo Krummrich" <dakr@kernel.org>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"David Airlie" <airlied@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eelco Chaudron" <echaudro@redhat.com>,
	"Eric Dumazet" <edumazet@kernel.org>,
	"Frederic Weisbecker" <frederic@kernel.org>,
	"Ilya Maximets" <i.maximets@ovn.org>,
	"Ingo Molnar" <mingo@kernel.org>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Jon Maloy" <jmaloy@redhat.com>,
	"Koby Elbaz" <koby.elbaz@intel.com>,
	"Konstantin Sinyuk" <konstantin.sinyuk@intel.com>,
	"Kyungmin Park" <kyungmin.park@samsung.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
	"Martin K. Petersen" <mkp@kernel.org>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"MyungJoo Ham" <myungjoo.ham@samsung.com>,
	"Oded Gabbay" <ogabbay@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Philipp Stanner" <phasta@kernel.org>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Thomas Gleixner" <tglx@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	tipc-discussion@lists.sourceforge.net,
	"Tung Quang Nguyen" <tung.quang.nguyen@est.tech>,
	"Xin Long" <lucien.xin@gmail.com>,
	x86@kernel.org, amd-gfx@lists.freedesktop.org,
	bpf@vger.kernel.org, dev@openvswitch.org,
	dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 1/9] net: Use trace_call__##name() at guarded tracepoint call sites
Date: Tue, 27 Oct 2026 11:36:59 -0400	[thread overview]
Message-ID: <20261027154412.637514479@kernel.org> (raw)
In-Reply-To: 20261027153658.703730257@kernel.org

From: Vineeth Pillai <vineeth@bitbyteword.org>

Replace trace_foo() with the new trace_call__foo() at sites already
guarded by trace_foo_enabled(), avoiding a redundant
static_branch_unlikely() re-evaluation inside the tracepoint.
trace_call__foo() calls the tracepoint callbacks directly without
utilizing the static branch again.

Original v2 series:
https://lore.kernel.org/linux-trace-kernel/20260323160052.17528-1-vineeth@bitbyteword.org/

Parts of the original v2 series have already been merged in mainline.
This patch is being reposted as a follow-up cleanup for the remaining
unmerged pieces.

Link: https://patch.msgid.link/20260515135909.2238774-1-vineeth@bitbyteword.org
Suggested-by: Steven Rostedt <rostedt@goodmis.org>
Suggested-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Vineeth Pillai (Google) <vineeth@bitbyteword.org>
Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 net/core/dev.c             | 2 +-
 net/core/xdp.c             | 2 +-
 net/openvswitch/actions.c  | 2 +-
 net/openvswitch/datapath.c | 2 +-
 net/sctp/outqueue.c        | 2 +-
 net/tipc/node.c            | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 1a09e7869118..447894e09239 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6685,7 +6685,7 @@ void netif_receive_skb_list(struct list_head *head)
 		return;
 	if (trace_netif_receive_skb_list_entry_enabled()) {
 		list_for_each_entry(skb, head, list)
-			trace_netif_receive_skb_list_entry(skb);
+			trace_call__netif_receive_skb_list_entry(skb);
 	}
 	netif_receive_skb_list_internal(head);
 	trace_netif_receive_skb_list_exit(0);
diff --git a/net/core/xdp.c b/net/core/xdp.c
index 1d679e8fd649..d6296d59f8e3 100644
--- a/net/core/xdp.c
+++ b/net/core/xdp.c
@@ -362,7 +362,7 @@ int xdp_rxq_info_reg_mem_model(struct xdp_rxq_info *xdp_rxq,
 		xsk_pool_set_rxq_info(allocator, xdp_rxq);
 
 	if (trace_mem_connect_enabled() && xdp_alloc)
-		trace_mem_connect(xdp_alloc, xdp_rxq);
+		trace_call__mem_connect(xdp_alloc, xdp_rxq);
 	return 0;
 }
 
diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c
index 12e339cbf791..044feae58e6f 100644
--- a/net/openvswitch/actions.c
+++ b/net/openvswitch/actions.c
@@ -1278,7 +1278,7 @@ static int do_execute_actions(struct datapath *dp, struct sk_buff *skb,
 		int err = 0;
 
 		if (trace_ovs_do_execute_action_enabled())
-			trace_ovs_do_execute_action(dp, skb, key, a, rem);
+			trace_call__ovs_do_execute_action(dp, skb, key, a, rem);
 
 		/* Actions that rightfully have to consume the skb should do it
 		 * and return directly.
diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c
index b2a0b09fd4a5..11b438c7e039 100644
--- a/net/openvswitch/datapath.c
+++ b/net/openvswitch/datapath.c
@@ -336,7 +336,7 @@ int ovs_dp_upcall(struct datapath *dp, struct sk_buff *skb,
 	int err;
 
 	if (trace_ovs_dp_upcall_enabled())
-		trace_ovs_dp_upcall(dp, skb, key, upcall_info);
+		trace_call__ovs_dp_upcall(dp, skb, key, upcall_info);
 
 	if (upcall_info->portid == 0) {
 		err = -ENOTCONN;
diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
index e92fb9da4647..e3d7be7009e3 100644
--- a/net/sctp/outqueue.c
+++ b/net/sctp/outqueue.c
@@ -1268,7 +1268,7 @@ int sctp_outq_sack(struct sctp_outq *q, struct sctp_chunk *chunk)
 	/* SCTP path tracepoint for congestion control debugging. */
 	if (trace_sctp_probe_path_enabled()) {
 		list_for_each_entry(transport, transport_list, transports)
-			trace_sctp_probe_path(transport, asoc);
+			trace_call__sctp_probe_path(transport, asoc);
 	}
 
 	sack_ctsn = ntohl(sack->cum_tsn_ack);
diff --git a/net/tipc/node.c b/net/tipc/node.c
index 53b0993c2c23..6c32618cc625 100644
--- a/net/tipc/node.c
+++ b/net/tipc/node.c
@@ -1953,7 +1953,7 @@ static bool tipc_node_check_state(struct tipc_node *n, struct sk_buff *skb,
 
 	if (trace_tipc_node_check_state_enabled()) {
 		trace_tipc_skb_dump(skb, false, "skb for node state check");
-		trace_tipc_node_check_state(n, true, " ");
+		trace_call__tipc_node_check_state(n, true, " ");
 	}
 	l = n->links[bearer_id].link;
 	if (!l)
-- 
2.53.0

  reply	other threads:[~2026-10-27 15:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-27 15:36 [PATCH 0/9] tracing: Use trace_call__FOO() for tracepoints behind trace_FOO_enabled() Steven Rostedt
2026-10-27 15:36 ` Steven Rostedt [this message]
2026-10-27 15:37 ` [PATCH 2/9] accel/habanalabs: Use trace_call__##name() at guarded tracepoint call sites Steven Rostedt
2026-10-27 15:37 ` [PATCH 3/9] devfreq: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 4/9] dma-buf: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 5/9] drm: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 6/9] scsi: ufs: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 7/9] net: devlink: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 8/9] kernel: time, trace: " Steven Rostedt
2026-10-27 15:37 ` [PATCH 9/9] x86: msr: " Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261027154412.637514479@kernel.org \
    --to=rostedt@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=aconole@redhat.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=anna-maria@linutronix.de \
    --cc=ast@kernel.org \
    --cc=bp@alien8.de \
    --cc=bpf@vger.kernel.org \
    --cc=christian.koenig@amd.com \
    --cc=cw00.choi@samsung.com \
    --cc=dakr@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=echaudro@redhat.com \
    --cc=edumazet@kernel.org \
    --cc=frederic@kernel.org \
    --cc=hawk@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=jiri@resnulli.us \
    --cc=jmaloy@redhat.com \
    --cc=john.fastabend@gmail.com \
    --cc=koby.elbaz@intel.com \
    --cc=konstantin.sinyuk@intel.com \
    --cc=kuba@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=matthew.brost@intel.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=mkp@kernel.org \
    --cc=mripard@kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogabbay@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peterz@infradead.org \
    --cc=phasta@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=sumit.semwal@linaro.org \
    --cc=tglx@kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=tung.quang.nguyen@est.tech \
    --cc=tzimmermann@suse.de \
    --cc=vineeth@bitbyteword.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.