[android-common:android14-6.1 20/20] fs/kernfs/dir.c:482: warning: Excess function parameter 'drop_supers' description in 'kernfs_drain'

[kernel test robot <lkp@intel.com>]

tree:   https://android.googlesource.com/kernel/common android14-6.1
head:   b83ca11f560a414ae30f680b4c212094f6abdf19
commit: d9c80a173a8ce60e5b86601a231209002e313be6 [20/20] UPSTREAM: kernfs: Add missing documentation for kernfs_put_active's drop_supers argument
config: i386-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20261027/202610271913.8BhjHDtU-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261027/202610271913.8BhjHDtU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610271913.8BhjHDtU-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/kernfs/dir.c:482: warning: Excess function parameter 'drop_supers' description in 'kernfs_drain'


vim +482 fs/kernfs/dir.c

fd7b9f7b9776b11 Tejun Heo    2013-11-28  468  
fd7b9f7b9776b11 Tejun Heo    2013-11-28  469  /**
81c173cb5e87fbb Tejun Heo    2014-02-03  470   * kernfs_drain - drain kernfs_node
81c173cb5e87fbb Tejun Heo    2014-02-03  471   * @kn: kernfs_node to drain
d9c80a173a8ce60 T.J. Mercier 2026-03-13  472   * @drop_supers: Set to true if this function is called with the
d9c80a173a8ce60 T.J. Mercier 2026-03-13  473   *               kernfs_supers_rwsem locked.
fd7b9f7b9776b11 Tejun Heo    2013-11-28  474   *
2b052bf46e870da Randy Dunlap 2022-11-11  475   * Drain existing usages and nuke all existing mmaps of @kn.  Multiple
81c173cb5e87fbb Tejun Heo    2014-02-03  476   * removers may invoke this function concurrently on @kn and all will
81c173cb5e87fbb Tejun Heo    2014-02-03  477   * return after draining is complete.
fd7b9f7b9776b11 Tejun Heo    2013-11-28  478   */
81c173cb5e87fbb Tejun Heo    2014-02-03  479  static void kernfs_drain(struct kernfs_node *kn)
393c3714081a537 Minchan Kim  2021-11-18  480  	__releases(&kernfs_root(kn)->kernfs_rwsem)
393c3714081a537 Minchan Kim  2021-11-18  481  	__acquires(&kernfs_root(kn)->kernfs_rwsem)
fd7b9f7b9776b11 Tejun Heo    2013-11-28 @482  {
abd54f028ec3097 Tejun Heo    2014-02-03  483  	struct kernfs_root *root = kernfs_root(kn);
fd7b9f7b9776b11 Tejun Heo    2013-11-28  484  
393c3714081a537 Minchan Kim  2021-11-18  485  	lockdep_assert_held_write(&root->kernfs_rwsem);
81c173cb5e87fbb Tejun Heo    2014-02-03  486  	WARN_ON_ONCE(kernfs_active(kn));
abd54f028ec3097 Tejun Heo    2014-02-03  487  
2d7f9f8c1815707 Tejun Heo    2022-08-27  488  	/*
2d7f9f8c1815707 Tejun Heo    2022-08-27  489  	 * Skip draining if already fully drained. This avoids draining and its
2d7f9f8c1815707 Tejun Heo    2022-08-27  490  	 * lockdep annotations for nodes which have never been activated
2d7f9f8c1815707 Tejun Heo    2022-08-27  491  	 * allowing embedding kernfs_remove() in create error paths without
2d7f9f8c1815707 Tejun Heo    2022-08-27  492  	 * worrying about draining.
2d7f9f8c1815707 Tejun Heo    2022-08-27  493  	 */
2d7f9f8c1815707 Tejun Heo    2022-08-27  494  	if (atomic_read(&kn->active) == KN_DEACTIVATED_BIAS &&
2d7f9f8c1815707 Tejun Heo    2022-08-27  495  	    !kernfs_should_drain_open_files(kn))
2d7f9f8c1815707 Tejun Heo    2022-08-27  496  		return;
2d7f9f8c1815707 Tejun Heo    2022-08-27  497  
393c3714081a537 Minchan Kim  2021-11-18  498  	up_write(&root->kernfs_rwsem);
35beab0635f3cdd Tejun Heo    2014-02-03  499  
182fd64b6634221 Tejun Heo    2014-02-03  500  	if (kernfs_lockdep(kn)) {
35beab0635f3cdd Tejun Heo    2014-02-03  501  		rwsem_acquire(&kn->dep_map, 0, 0, _RET_IP_);
35beab0635f3cdd Tejun Heo    2014-02-03  502  		if (atomic_read(&kn->active) != KN_DEACTIVATED_BIAS)
324a56e16e44bae Tejun Heo    2013-12-11  503  			lock_contended(&kn->dep_map, _RET_IP_);
35beab0635f3cdd Tejun Heo    2014-02-03  504  	}
abd54f028ec3097 Tejun Heo    2014-02-03  505  
abd54f028ec3097 Tejun Heo    2014-02-03  506  	wait_event(root->deactivate_waitq,
abd54f028ec3097 Tejun Heo    2014-02-03  507  		   atomic_read(&kn->active) == KN_DEACTIVATED_BIAS);
fd7b9f7b9776b11 Tejun Heo    2013-11-28  508  
182fd64b6634221 Tejun Heo    2014-02-03  509  	if (kernfs_lockdep(kn)) {
324a56e16e44bae Tejun Heo    2013-12-11  510  		lock_acquired(&kn->dep_map, _RET_IP_);
5facae4f3549b5c Qian Cai     2019-09-19  511  		rwsem_release(&kn->dep_map, _RET_IP_);
fd7b9f7b9776b11 Tejun Heo    2013-11-28  512  	}
35beab0635f3cdd Tejun Heo    2014-02-03  513  
bdb2fd7fc56e197 Tejun Heo    2022-08-27  514  	if (kernfs_should_drain_open_files(kn))
0e67db2f9fe9193 Tejun Heo    2016-12-27  515  		kernfs_drain_open_files(kn);
ccf02aaf8167bb8 Tejun Heo    2014-02-03  516  
393c3714081a537 Minchan Kim  2021-11-18  517  	down_write(&root->kernfs_rwsem);
a6607930b6cd829 Tejun Heo    2014-02-03  518  }
fd7b9f7b9776b11 Tejun Heo    2013-11-28  519  

:::::: The code at line 482 was first introduced by commit
:::::: fd7b9f7b9776b11df629e9dd3865320bf57ce588 sysfs, kernfs: move dir core code to fs/kernfs/dir.c

:::::: TO: Tejun Heo <tj@kernel.org>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki