Re: [PATCH v2 09/13] PCI/TSM: Use generic VF iterators

[Bjorn Helgaas <helgaas@kernel.org>]

On Tue, Oct 27, 2026 at 05:04:42PM +0100, Lukasz Laguna wrote:
> pci_tsm_walk_fns() and pci_tsm_walk_fns_reverse() implement their own VF
> iteration logic. Replace it with for_each_pci_vf() and
> for_each_pci_vf_reverse().

This and the rest of the series seems like nice, relatively simple
cleanup that could be done earlier, e.g., after [02/13] "PCI/IOV:
Introduce VF iterators".  Those look fairly straightforward and maybe
could be merged earlier to get them out of the way.

> Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
> ---
>  drivers/pci/tsm.c | 25 ++++---------------------
>  1 file changed, 4 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/pci/tsm.c b/drivers/pci/tsm.c
> index 5fdcd7f2e820..01fa6149e481 100644
> --- a/drivers/pci/tsm.c
> +++ b/drivers/pci/tsm.c
> @@ -84,6 +84,7 @@ static void pci_tsm_walk_fns(struct pci_dev *pdev,
>  	for (int i = 0; i < 8; i++) {
>  		struct pci_dev *pf __free(pci_dev_put) = pci_get_slot(
>  			pdev->bus, PCI_DEVFN(PCI_SLOT(pdev->devfn), i));
> +		struct pci_dev *vf;
>  
>  		if (!pf)
>  			continue;
> @@ -93,18 +94,8 @@ static void pci_tsm_walk_fns(struct pci_dev *pdev,
>  			cb(pf, data);
>  
>  		/* walk virtual functions of each pf */
> -		for (int j = 0; j < pci_num_vf(pf); j++) {
> -			struct pci_dev *vf __free(pci_dev_put) =
> -				pci_get_domain_bus_and_slot(
> -					pci_domain_nr(pf->bus),
> -					pci_iov_virtfn_bus(pf, j),
> -					pci_iov_virtfn_devfn(pf, j));
> -
> -			if (!vf)
> -				continue;
> -
> +		for_each_pci_vf(pf, vf)
>  			cb(vf, data);
> -		}
>  	}
>  
>  	/*
> @@ -128,22 +119,14 @@ static void pci_tsm_walk_fns_reverse(struct pci_dev *pdev,
>  	for (int i = 7; i >= 0; i--) {
>  		struct pci_dev *pf __free(pci_dev_put) = pci_get_slot(
>  			pdev->bus, PCI_DEVFN(PCI_SLOT(pdev->devfn), i));
> +		struct pci_dev *vf;
>  
>  		if (!pf)
>  			continue;
>  
>  		/* reverse walk virtual functions */
> -		for (int j = pci_num_vf(pf) - 1; j >= 0; j--) {
> -			struct pci_dev *vf __free(pci_dev_put) =
> -				pci_get_domain_bus_and_slot(
> -					pci_domain_nr(pf->bus),
> -					pci_iov_virtfn_bus(pf, j),
> -					pci_iov_virtfn_devfn(pf, j));
> -
> -			if (!vf)
> -				continue;
> +		for_each_pci_vf_reverse(pf, vf)
>  			cb(vf, data);
> -		}
>  
>  		/* on exit, caller will run @cb on function 0 */
>  		if (i > 0)
> -- 
> 2.43.0
>