From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=62.149.156.102 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793129158; b=ucV+79rD9lCEf4tJYYCeAf5ij1ZyB31rxWoTVdaRekEHTh+8IX+uwIlRhFk7wp4dnw1e Sittgn4+gbvjX1Ly9+/4zZW9iOZO1KuJ7CqE0vxJPpeqR9Upu5M5XZIoNJXBMmq47I6B+ upAoUqPl64A6mqLjQ+Qm3ydZJw7lK27Pmc6FgSxjqIyJ0rEPN6+VKJSVX/R+KHRGxsxge W6Dhmw3gKfIq7S5U3WidbaktiPHtwumTdQI1OlQFv97AFBrhUEbXcXhmlaldJZdcQU5V+ AoP6ZTFUiRpPVxqkhJMQPWRg7PgL95b22itLAecxZvi+RchOrPEdjP8C3EwiPXOio1Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793129158; h=DMARC-Filter:Received:DKIM-Signature:Date:From:To:Cc:Subject: Message-ID:In-Reply-To:References:X-Mailer:MIME-Version:Content-Type: Content-Transfer-Encoding:X-CMAE-Envelope; bh=tEogqM6cDAZusNLmJc5Pb9iz70oEFEFrHnh7w79Hiwk=; b=aKbnHzRR2WXwDqIzENKaX110vBFym+/u0O311NIEUOmknV1RbaDXR77UltLw3jhBT2JF ljt9nJaOb8kg6kXbPGGoPDU27RA5R6CXy5K26FtJ7rC1vHQJDVUwNDLsAURNDZHMaSF3/ MIxxQajGpv+24CnBcfM/AJQXLoBOcTq5Ccg7WZ15HnDUkt/P9tkl2Lu9Rt2D7JPMwj+Mn RtuE0eXwHrXSrKmZlQ6EJ0Lg561G3m/dJc7YMF3VgP2be0dASZR6px6HqGV5EcVNR0NRk Fr4frMjIZAEPAvYlPHFtnq23NedMuRLtMsE4xiJdvnsHxKu2rEDImSh71c0WSNpGboA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=mythread.it; spf=pass smtp.mailfrom=mythread.it; dkim=pass header.d=mythread.it header.i=@mythread.it header.a=rsa-sha256 header.s=a1 header.b=PX017VZB; arc=none smtp.remote-ip=62.149.156.102 Received: from smtpcmd10102.aruba.it (smtpcmd10102.aruba.it [62.149.156.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57780606A31E for ; Tue, 27 Oct 2026 19:25:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 57780606A31E Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=mythread.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mythread.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=mythread.it header.i=@mythread.it header.a=rsa-sha256 header.s=a1 header.b=PX017VZB Received: from fedora ([94.34.125.0]) by Aruba SMTP with ESMTPSA id Lmntx3q1VW41bLmntxqI5u; Tue, 27 Oct 2026 20:25:49 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mythread.it; s=a1; t=1793129149; bh=GDOI0xW3OjzJgooa36QpDQuuemC8QFwMBSGIM4ayZdI=; h=Date:From:To:Subject:MIME-Version:Content-Type; b=PX017VZBdHtuwgydU+pi0Jb/DqzK+cj1xCHoxJ69yoHDnjbuXSu7cQ3uu5BPfwVZ6 DDgQLLVzvDrkFfpw1dY73AoEnOmcQDrzQx4RuFt7AGleERiy9ssdsV80hKQu/DCgJ9 dWP2OZgW9jFSZ4u7ocDb5bjlg63aYWoOyyyJPggF/lc6ZJcyEbE8HYOnXV5s+Sbw7k mHvKB4M9Q7K4FlRWy0xDeA9K7N5tTYfo6y+zkD9jFEYrNfoRo4MXcohcJWyirry7sc ygJhEsqi71dXemfmzh+OERef/Z0C52Pz1H2M0mqU45PHKRb9yg0DYZcFdOiNd8vtjC cJ/T90Yuu1YHw== Date: Tue, 27 Oct 2026 20:25:48 +0100 From: Alessio Ferri To: Andreas Wendleder Cc: julian.calaby@gmail.com, kvalo@kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, b43-dev@lists.infradead.org, Michael Buesch , Johannes Berg Subject: Re: [PATCH wireless-next 1/2] wifi: b43: reprogram the MAC filter after an interface restart Message-ID: <20261027202548.704378e9@fedora> In-Reply-To: <20261027202151.7dcdfe4e@fedora> References: <20261014143225.82149-1-gonsolo@gmail.com> <20261014143225.82149-2-gonsolo@gmail.com> <20261027202151.7dcdfe4e@fedora> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4xfPlu6URVniRZ4SPGlOnRS2FmnTO9SM12PPiq9x5/EKVvirC3WRbMvkUS4PHV3wSmPIyyiOflRoYooILKKBXuLQedXOkpTK8pOwLO+obzca1VSoMRrc4s mQ74Sfl2VWhVpMUpCqXjna8Yj439uNznjJk9GafkxMNJzDtwmdIeMO4srNgjVYzzZRQ34IghwfQr/inkALn9LMrWMcV0DHYsvIkold8QfkToPwZDVzTjZDHh OnsrXLjQruPtesXyx/w5Jjab+tdLbA8RPLuC10PWAdh2Xysu4WRO473bWSWPMiBsMcNhnncwCjEtzdkD4ukNUfKVu6dppZIMtP/49ZEKEITIkusi3GYf0/JS IGU5ZxZSJI2iAYPllaWgWe7HgxiE7FEtwgQPlD3LH1SNll3AVamE5l/DNHrleELgG8tdPxhI Il giorno Tue, 27 Oct 2026 20:21:51 +0100 Alessio Ferri ha scritto: > Il giorno Wed, 14 Oct 2026 16:32:24 +0200 > Andreas Wendleder ha scritto: > > > b43_op_start() clears wl->filter_flags, but mac80211 computes > > @changed for b43_op_configure_filter() against the flags it cached > > from the previous run. After a down/up it can report no change, so > > b43_adjust_opmode() is not called and MACCTL keeps the cleared > > filter. > > > > Compare the requested flags with what the hardware was programmed > > with and add the difference to @changed. > > > > Signed-off-by: Andreas Wendleder > > --- > > drivers/net/wireless/broadcom/b43/main.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/net/wireless/broadcom/b43/main.c > > b/drivers/net/wireless/broadcom/b43/main.c index 8f4aff3..57a5935 > > 100644 --- a/drivers/net/wireless/broadcom/b43/main.c > > +++ b/drivers/net/wireless/broadcom/b43/main.c > > @@ -4318,6 +4318,14 @@ static void b43_op_configure_filter(struct > > ieee80211_hw *hw, FIF_OTHER_BSS | > > FIF_BCN_PRBRESP_PROMISC; > > > > + /* > > + * b43_op_start() zeroes wl->filter_flags, but mac80211 > > computes > > + * @changed against its own cached flags, so after an > > interface > > + * restart it reports no change and MACCTL kept the zeroed > > filter. > > + * Compare against what the hardware was actually > > programmed with. > > + */ > > + if (wl->filter_flags != *fflags) > > + changed |= wl->filter_flags ^ *fflags; > > wl->filter_flags = *fflags; > > > > if (changed && b43_status(dev) >= B43_STAT_INITIALIZED) > > Tested on DSL 3580L, with 4352 chip on 5Ghz, the chip transmit and no > dma error arise. Without the patch the dma engine report an error on > the descriptor. Earlier in June i wrongly asserted that the DMA on AC > chips was needing 64 Kb segments, it was a wrong conclusion: going > 64kb did stop the error, but for the wrong reason. > > Tested-by: Alessio Ferri > > _______________________________________________ > b43-dev mailing list > b43-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/b43-dev Ops, i meant to send it for PATCH 2/2, sorry to all Sorry again Alessio From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4831606A31F for ; Tue, 27 Oct 2026 19:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=ow9fOdvT; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=mythread.it header.i=@mythread.it header.a=rsa-sha256 header.s=a1 header.b=PX017VZB DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=durVlR2SSWY9PpYH8/yzRODvinFK9/st7UXvz2Nea00=; b=ow9fOdvTuHJUN4LopdvHg919Fh h2fv1iV9nIKWnurtGS1L914ALa8kTBFULophxRlUYT0+o/y2OqER2OPww0a/nSjeUBZvOHbmGrZHX k9Qv4NGDGQCTVz/xph8jABR6rBk3wmCvyilP18In2E1Ylp5CLFc++wsqM3sABk5o/GZTj2C9/fESm Z7bcdBSMTv2Wszl9QZLgmBa01TsFNiNwqKRo92bTuRhxAbxmUr7lmVyLQXlP527+C9LPBUoMWa/6N Y4A6guVYgR+ervYzYTfo3EYjUibx/hHNRsmi1HOntB1/EuPE57hs5imSBcrM7aBTV9x65Ug44pCcF QRe39eTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLmnz-00000005eEQ-0qu3; Tue, 27 Oct 2026 19:25:55 +0000 Received: from smtpcmd10102.aruba.it ([62.149.156.102]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLmnw-00000005eDw-0tf5 for b43-dev@lists.infradead.org; Tue, 27 Oct 2026 19:25:53 +0000 Received: from fedora ([94.34.125.0]) by Aruba SMTP with ESMTPSA id Lmntx3q1VW41bLmntxqI5u; Tue, 27 Oct 2026 20:25:49 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mythread.it; s=a1; t=1793129149; bh=GDOI0xW3OjzJgooa36QpDQuuemC8QFwMBSGIM4ayZdI=; h=Date:From:To:Subject:MIME-Version:Content-Type; b=PX017VZBdHtuwgydU+pi0Jb/DqzK+cj1xCHoxJ69yoHDnjbuXSu7cQ3uu5BPfwVZ6 DDgQLLVzvDrkFfpw1dY73AoEnOmcQDrzQx4RuFt7AGleERiy9ssdsV80hKQu/DCgJ9 dWP2OZgW9jFSZ4u7ocDb5bjlg63aYWoOyyyJPggF/lc6ZJcyEbE8HYOnXV5s+Sbw7k mHvKB4M9Q7K4FlRWy0xDeA9K7N5tTYfo6y+zkD9jFEYrNfoRo4MXcohcJWyirry7sc ygJhEsqi71dXemfmzh+OERef/Z0C52Pz1H2M0mqU45PHKRb9yg0DYZcFdOiNd8vtjC cJ/T90Yuu1YHw== Date: Tue, 27 Oct 2026 20:25:48 +0100 From: Alessio Ferri To: Andreas Wendleder Cc: julian.calaby@gmail.com, kvalo@kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, b43-dev@lists.infradead.org, Michael Buesch , Johannes Berg Subject: Re: [PATCH wireless-next 1/2] wifi: b43: reprogram the MAC filter after an interface restart Message-ID: <20261027202548.704378e9@fedora> In-Reply-To: <20261027202151.7dcdfe4e@fedora> References: <20261014143225.82149-1-gonsolo@gmail.com> <20261014143225.82149-2-gonsolo@gmail.com> <20261027202151.7dcdfe4e@fedora> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) X-Archived-By: MIME-Version: 1.0 X-CMAE-Envelope: MS4xfPlu6URVniRZ4SPGlOnRS2FmnTO9SM12PPiq9x5/EKVvirC3WRbMvkUS4PHV3wSmPIyyiOflRoYooILKKBXuLQedXOkpTK8pOwLO+obzca1VSoMRrc4s mQ74Sfl2VWhVpMUpCqXjna8Yj439uNznjJk9GafkxMNJzDtwmdIeMO4srNgjVYzzZRQ34IghwfQr/inkALn9LMrWMcV0DHYsvIkold8QfkToPwZDVzTjZDHh OnsrXLjQruPtesXyx/w5Jjab+tdLbA8RPLuC10PWAdh2Xysu4WRO473bWSWPMiBsMcNhnncwCjEtzdkD4ukNUfKVu6dppZIMtP/49ZEKEITIkusi3GYf0/JS IGU5ZxZSJI2iAYPllaWgWe7HgxiE7FEtwgQPlD3LH1SNll3AVamE5l/DNHrleELgG8tdPxhI X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261027_122552_418549_C81BB9F4 X-CRM114-Status: GOOD ( 21.28 ) X-Spam-Score: -2.1 (--) X-BeenThere: b43-dev@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: b43/b43legacy Linux driver discussions List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "b43-dev" X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 Il giorno Tue, 27 Oct 2026 20:21:51 +0100 Alessio Ferri ha scritto: > Il giorno Wed, 14 Oct 2026 16:32:24 +0200 > Andreas Wendleder ha scritto: > > > b43_op_start() clears wl->filter_flags, but mac80211 computes > > @changed for b43_op_configure_filter() against the flags it cached > > from the previous run. After a down/up it can report no change, so > > b43_adjust_opmode() is not called and MACCTL keeps the cleared > > filter. > > > > Compare the requested flags with what the hardware was programmed > > with and add the difference to @changed. > > > > Signed-off-by: Andreas Wendleder > > --- > > drivers/net/wireless/broadcom/b43/main.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/net/wireless/broadcom/b43/main.c > > b/drivers/net/wireless/broadcom/b43/main.c index 8f4aff3..57a5935 > > 100644 --- a/drivers/net/wireless/broadcom/b43/main.c > > +++ b/drivers/net/wireless/broadcom/b43/main.c > > @@ -4318,6 +4318,14 @@ static void b43_op_configure_filter(struct > > ieee80211_hw *hw, FIF_OTHER_BSS | > > FIF_BCN_PRBRESP_PROMISC; > > > > + /* > > + * b43_op_start() zeroes wl->filter_flags, but mac80211 > > computes > > + * @changed against its own cached flags, so after an > > interface > > + * restart it reports no change and MACCTL kept the zeroed > > filter. > > + * Compare against what the hardware was actually > > programmed with. > > + */ > > + if (wl->filter_flags != *fflags) > > + changed |= wl->filter_flags ^ *fflags; > > wl->filter_flags = *fflags; > > > > if (changed && b43_status(dev) >= B43_STAT_INITIALIZED) > > Tested on DSL 3580L, with 4352 chip on 5Ghz, the chip transmit and no > dma error arise. Without the patch the dma engine report an error on > the descriptor. Earlier in June i wrongly asserted that the DMA on AC > chips was needing 64 Kb segments, it was a wrong conclusion: going > 64kb did stop the error, but for the wrong reason. > > Tested-by: Alessio Ferri > > _______________________________________________ > b43-dev mailing list > b43-dev@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/b43-dev Ops, i meant to send it for PATCH 2/2, sorry to all Sorry again Alessio _______________________________________________ b43-dev mailing list b43-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/b43-dev