Re: [PATCH v2 4/4] arm64: dts: mediatek: mt8188: Use access-controllers in the power controller

[Rob Herring <robh@kernel.org>]

On Sun, Oct 11, 2026 at 08:47:55PM +0200, Michał Kopeć wrote:
> List the blocks that the power controller accesses in access-controllers
> instead of the deprecated per-domain mediatek,infracfg phandles, and add
> MFGCFG, which the power controller needs to enable the GPU timestamp
> counter whenever it powers MFG1 on.
> 
> Signed-off-by: Michał Kopeć <michal@nozomi.space>
> ---
>  arch/arm64/boot/dts/mediatek/mt8188.dtsi | 22 +---------------------
>  1 file changed, 1 insertion(+), 21 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> index 14a320f0c70cb..cf0da77c5fd29 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> @@ -1000,6 +1000,7 @@ scpsys: syscon@10006000 {
>  			/* System Power Manager */
>  			spm: power-controller {
>  				compatible = "mediatek,mt8188-power-controller";
> +				access-controllers = <&infracfg_ao>, <&mfgcfg>;

Do these providers have #access-controller-cells? Doesn't look like it 
to me. You should have some cells here that define which access 
control in infracfg_ao (and mfgcfg) the power-controller uses. Looks 
like you are abusing the binding to me.

Rob