From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.70 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793140767; b=V4l4+Sk9ZHgnkBCIdV8ObXBI219LHs4++8y35qgssEiAnreWNy/eaggsNHYGltfeHfiP QeI76lW2l/f1IKqiBJCil7uc1nDnFjZ4/eeRJptd6pPJDegZZwnlyghkkT7JMoCNLFAA6 AuQuaEnfjKVCLz1ROTcmktDj29wRadSNGPyIIjVxi/mj15O8J85nymCgWsL9eHzSnLFna gNdDC0S6T3sNZHTiKJCMkzp+COvt/6EEPOz1+fIlhr/xcP4S07NYMLV69XkN66wjwcjXs ryqoRIBzLEsK8dPmFvZkp+DXe/EGttjE8yqv5XlxxYxRG2XTIA7iFAQWvqGCZWVROgw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793140767; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Received:Date:In-Reply-To: Mime-Version:References:X-Mailer:Message-ID:Subject:From:To:Cc: Content-Type; bh=4zou/7CSV4h/YwAlF7A1OL9kEnFb2HIoLHCAQS8LrD8=; b=EXOEur8pgh/Jh+RJcT08sqPbSabWtij81ZGvNs5krmRTug/fGco9/K1D4DJXWp8TqJ/V i2PMtUje6T0InLeHd2LszHWRfeK2q2Dk0HWHo4y8EfMNhrZEJC3VwW90RDmQ1OvEkqtvD 379ROM8XztUf657uQZzBRgNELwMTTXovwbqQKKiKFQ2ROe/hivZ7WNvL/C0cCunLCJkLB OkxLFiKuFFu/9MwzqABcnLgv+xWm/tA6ipHWI2sfrXMymAWjM1ol0K4yN3Mq82RegNzkG tv5ThFHf/CJvRkcmRraSBZBNyHqapuE/hW7ykeVI/Bj9N7cUSF+UpEmNGjwZomdVpOA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=liNe3HMy; arc=none smtp.remote-ip=74.125.82.70 Received: from mail-dl1-f70.google.com (mail-dl1-f70.google.com [74.125.82.70]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A0A360A382C for ; Tue, 27 Oct 2026 22:39:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9A0A360A382C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=liNe3HMy Received: by mail-dl1-f70.google.com with SMTP id a92af1059eb24-139b62317d0so1025597c88.0 for ; Tue, 27 Oct 2026 15:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140767; x=1793745567; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4zou/7CSV4h/YwAlF7A1OL9kEnFb2HIoLHCAQS8LrD8=; b=liNe3HMy55X9pJAx3yYfGsMeNT+e1JnZxB+AQx3A5J9VPGgN92YzVbYvd/za/Drr5k lst0PfcfRGocLlrgPC5UssnxEJctFzU+pQm+95FdUho7XQl8tD1ulM7rKwt/jNE+21Vf Z9LeRG62rYmnsPQmmg4JlXmw8+AffIjWCQze/e0A/NrbyHM8TP8o1608vrQLYJKc1eVF dF+siAZRQfjXJUi0LYKhvOuPmzmxcjf9I8fjPgny0U321qhAu1Pmw+Bv//U3MdnFtahJ 7n34bb7IiC2Le1ntE29Feez7T+/eMXs0L62grlkW9U2pgTYjfEQQlg6qoj1bz6MQC6fW lCEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140767; x=1793745567; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4zou/7CSV4h/YwAlF7A1OL9kEnFb2HIoLHCAQS8LrD8=; b=uemnSmhV4dauVOo5qpNAtIE/MkO3CT6+GWkwzUydDZ1tiO9GR7daa1cA3UAVKZNVGY 9dqpgJCKV0YBnwuSD9Yyu2/FXCApeNrg4klUXNqLy6kKSTLzVt1A1HlS7U+1MLkS2Oh7 5IE5xpUcfq4E1QCKe9O/WFr5SxeWL1BGUobXY+QHh3L0dTnYR5pPBulQLWCLgokgy3MW 2c4sH0hz7NytQFFlUTwsh+/s/3cCjrDtVCuTQxdPcebI8U3IJMC0iIdUmJLbTPi/e63U 65B3uxiZWeZuqbRpZ3/OQGmafOF/MN+mgoxk3KfoDOoQIbS7LglzceARvrDdymXj/gxP o6Ng== X-Forwarded-Encrypted: i=1; AKwUvBwloWbaHAN6g21rHEXfBxgOAH/PXWrRvImgahdj2q+QAHVX7pH4UOI7KnS4UwXFRPtOKAYmcGdqCjr9XjrDwwE=@vger.kernel.org X-Gm-Message-State: AFq9FYLROAR/uhMLfx+gm4VRlFFVOIyl9Un0p37Qtyh/QGbVx80JdeUn JR9Y0LRYiX1ng+aU5zjcI9Day8wVJlpqAYs4xVbtUuU3t+bvrI4K20XTRGw/9g7e8m1xv4BR7G4 Yz8EiWvOggg== X-Received: from dlbqq10.prod.google.com ([2002:a05:7022:ed0a:b0:1a0:a0b4:204c]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:f115:b0:1a3:6040:bf78 with SMTP id a92af1059eb24-1a6cc34d07bmr917417c88.11.1793140766453; Tue, 27 Oct 2026 15:39:26 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:41 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-7-irogers@google.com> Subject: [PATCH v2 6/9] xen/sys-hypervisor: Add release callback to hyp_sysfs_kobj_type From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jeremy Fitzhardinge Content-Type: text/plain; charset="UTF-8" hypervisor_init() in drivers/base/hypervisor.c creates hypervisor_kobj with kobject_create_and_add() (which allocates a dynamic kobject using dynamic_kobj_ktype), and hypervisor_subsys_init() in drivers/xen/sys-hypervisor.c then overwrites hypervisor_kobj->ktype with &hyp_sysfs_kobj_type, which had no .release callback. Add hyp_sysfs_release() calling kfree(kobj) to preserve the dynamic kobject release behavior. Fixes: cff7e81b3dd7 ("xen: add /sys/hypervisor support") Signed-off-by: Ian Rogers --- drivers/xen/sys-hypervisor.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c index 91923242a5ae..0e8a2cd69fd6 100644 --- a/drivers/xen/sys-hypervisor.c +++ b/drivers/xen/sys-hypervisor.c @@ -659,7 +659,13 @@ static const struct sysfs_ops hyp_sysfs_ops = { .store = hyp_sysfs_store, }; +static void hyp_sysfs_release(struct kobject *kobj) +{ + kfree(kobj); +} + static const struct kobj_type hyp_sysfs_kobj_type = { + .release = hyp_sysfs_release, .sysfs_ops = &hyp_sysfs_ops, }; -- 2.56.0.313.g2479322e68-goog From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA1C260A5BD4 for ; Tue, 27 Oct 2026 22:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=tKl6azeM; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20260707 header.b=gc1toDX8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Unsubscribe-Post:List-Owner; bh=Z9SlZjqcrxmliUdOTJSCVa1aJYv8Qov61BG2Brd89QI=; b=tKl6azeMtvLeh0oNhOBAzcgye0 T2AhlvLAEPKLq1sR42Jn7I4uRxJaxq/U640Bh5k06f25F8EOXwxQ37/bqd777aEhmpxB6ICaE1/LF ujK/pDuuO9BaFoQM2VezL7825ieGp5nzkaND6OSliTiN3+W3rh22T919iyXFCePTkuDe4NfUMR28K 0JKOEun3QZmgg3Y5yZRoKf4QzyVlCWna3ag9JkMfDTrO4bJDPcIekR0u++xzsF0Tn2fGh2XKIg6v+ dG3NXz9fPAnUhw/+5CDCbt4JD64U4q5nDDlJ9vwpvGfnnxR7iWNooyVGDOmreXKCBYqON021tAh0d 8LPmTRzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLppK-00000005r9R-2mMp; Tue, 27 Oct 2026 22:39:30 +0000 Received: from mail-dl1-x1248.google.com ([2607:f8b0:4864:20::1248]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLppI-00000005r66-2SyX for linux-mtd@lists.infradead.org; Tue, 27 Oct 2026 22:39:30 +0000 Received: by mail-dl1-x1248.google.com with SMTP id a92af1059eb24-139b62317d0so1025589c88.0 for ; Tue, 27 Oct 2026 15:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20260707; t=1793140767; x=1793745567; darn=lists.infradead.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4zou/7CSV4h/YwAlF7A1OL9kEnFb2HIoLHCAQS8LrD8=; b=gc1toDX8PpSdX8SEyQcawLKoDBr1gvwKQZjl6zon5uWx/tdGN19CYU2BKDb/ird+US ahIIocjL5p7yuekSSoj3vIAmrIQvdmQdsOoYsIz8QmJ5TK1TU16+EXS2R4qeSwH8GU1V xrL+P+aXITpRzCF5jGRaPGVKq1jfTHmLL4UdboqnJ9HFnCuRedrCLoZzQUfgqq62EOPT 9z02XPe9XflV4jaTbGKfyCJPSVTbRI+6PSQmUPC7fWF53OiVaaGmDKrJUEcPzj7jXZKe EX7GmV9H2iXBh8dSKJuTyOaWM9E1bWWOZMomeEoX067gcLDkVWsq9lKX0xFfi/VEhHQ6 D00w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793140767; x=1793745567; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4zou/7CSV4h/YwAlF7A1OL9kEnFb2HIoLHCAQS8LrD8=; b=QVbMLrEhOwHncqln8BfE0idziGGPbcU+VM5tKLrKGqJJp4MrZNYL+w2GA4AmbQ/hfC tYZzs+ODP0f5SX3CxDx56vGEqc9ivH87acQtoIiTvd7RupR6llWPHov1c09lyBHcOM9h 7jUTxcWilr6pZj1DvUgoYw6g6Sgy6ynPHjcX2Ye1LlbplhO3Uv17c7fxN2jVHUJ8axAY Zx8EXTsWBy+MhWMVH+M2MdJ+16kNwXwwNYNSuOjMvoWQGFvT3b0/uptmUdAW5lSBx+dC uPzDB3mk0s+ZOMT4fVdMjUAnJdEdEDPXSAHMieiikcv5WM/Gp17NEc5eDJxKWesz0BL3 /sHQ== X-Forwarded-Encrypted: i=1; AKwUvBww/l/fwGU4d/nVisHi7AP2LJVtAslyPB+TiAxQa2U9qeI/QrB5dw1X/o1ball61Dgn/UqHexRfoqI=@lists.infradead.org X-Gm-Message-State: AFq9FYIADRWb5a2eRNSHTnhvmiBEomrMxpMV4lc65AYabv3iiJGgfpL5 8jMuxqptw4krGbOMqbw7ndmU22jtZIVB4AXGEGgxcNNx556l2jbjh9OICuS5e8dnklUk3cORWaY 82h5rRB6shg== X-Received: from dlbqq10.prod.google.com ([2002:a05:7022:ed0a:b0:1a0:a0b4:204c]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:f115:b0:1a3:6040:bf78 with SMTP id a92af1059eb24-1a6cc34d07bmr917417c88.11.1793140766453; Tue, 27 Oct 2026 15:39:26 -0700 (PDT) Date: Tue, 27 Oct 2026 15:38:41 -0700 In-Reply-To: <20261027223847.652884-1-irogers@google.com> X-Archived-By: Mime-Version: 1.0 References: <20261027223847.652884-1-irogers@google.com> X-Mailer: git-send-email 2.56.0.313.g2479322e68-goog Message-ID: <20261027223847.652884-7-irogers@google.com> Subject: [PATCH v2 6/9] xen/sys-hypervisor: Add release callback to hyp_sysfs_kobj_type From: Ian Rogers To: Kees Cook , Greg Kroah-Hartman , Miguel Ojeda , "Rafael J . Wysocki" , Danilo Krummrich Cc: Nathan Chancellor , Nick Desaulniers , Miguel Ojeda , "=?UTF-8?q?Christian=20K=C3=B6nig?=" , Zhihao Cheng , Zhongqiu Han , Sumanth Korikkar , Bill Wendling , Justin Stitt , driver-core@lists.linux.dev, llvm@lists.linux.dev, linux-hardening@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, linux-s390@vger.kernel.org, gfs2@lists.linux.dev, xen-devel@lists.xenproject.org, linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ian Rogers , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jeremy Fitzhardinge X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261027_153928_631078_13205690 X-CRM114-Status: GOOD ( 10.55 ) X-Spam-Score: -9.5 (---------) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 hypervisor_init() in drivers/base/hypervisor.c creates hypervisor_kobj with kobject_create_and_add() (which allocates a dynamic kobject using dynamic_kobj_ktype), and hypervisor_subsys_init() in drivers/xen/sys-hypervisor.c then overwrites hypervisor_kobj->ktype with &hyp_sysfs_kobj_type, which had no .release callback. Add hyp_sysfs_release() calling kfree(kobj) to preserve the dynamic kobject release behavior. Fixes: cff7e81b3dd7 ("xen: add /sys/hypervisor support") Signed-off-by: Ian Rogers --- drivers/xen/sys-hypervisor.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/xen/sys-hypervisor.c b/drivers/xen/sys-hypervisor.c index 91923242a5ae..0e8a2cd69fd6 100644 --- a/drivers/xen/sys-hypervisor.c +++ b/drivers/xen/sys-hypervisor.c @@ -659,7 +659,13 @@ static const struct sysfs_ops hyp_sysfs_ops = { .store = hyp_sysfs_store, }; +static void hyp_sysfs_release(struct kobject *kobj) +{ + kfree(kobj); +} + static const struct kobj_type hyp_sysfs_kobj_type = { + .release = hyp_sysfs_release, .sysfs_ops = &hyp_sysfs_ops, }; -- 2.56.0.313.g2479322e68-goog ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/