From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Gregory Price <gourry@gourry.net>, Zi Yan <ziy@nvidia.com>,
Joshua Hahn <joshua.hahnjy@gmail.com>,
Rakie Kim <rakie.kim@sk.com>,
Ying Huang <ying.huang@linux.alibaba.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Michal Hocko <mhocko@suse.com>, Hugh Dickins <hughd@google.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Lukas Czerner <lczerner@redhat.com>,
Carlos Maiolino <cmaiolino@redhat.com>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Daniel Verkamp <dverkamp@chromium.org>,
Jeff Xu <jeffxu@google.com>, Muchun Song <muchun.song@linux.dev>,
Oscar Salvador <osalvador@suse.de>,
David Stevens <stevensd@chromium.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
William Kucharski <william.kucharski@oracle.com>,
Chris Li <chrisl@kernel.org>, Kairui Song <kasong@tencent.com>,
Nhat Pham <nphamcs@gmail.com>, Miaohe Lin <linmiaohe@huawei.com>,
Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
"David Hildenbrand (Arm)" <david@kernel.org>,
Eva Kurchatova <eva.kurchatova@virtuozzo.com>,
stable@vger.kernel.org, Pedro Falcato <pfalcato@suse.de>,
"Kiryl Shutsemau (Meta)" <kas@kernel.org>
Subject: [PATCH v3 05/15] hugetlbfs: enforce F_SEAL_EXEC in setattr
Date: Wed, 28 Oct 2026 10:55:03 +0100 [thread overview]
Message-ID: <20261028-fixes_shmem-v3-5-4ce3baf2db4b@kernel.org> (raw)
In-Reply-To: <20261028-fixes_shmem-v3-0-4ce3baf2db4b@kernel.org>
From: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
F_SEAL_EXEC is enforced by shmem_setattr(), but hugetlbfs_setattr() does
not check it. As a result, fchmod() can change the execute bits of a
sealed hugetlbfs memfd.
Use memfd_check_seals_mode() in hugetlbfs_setattr() to reject changes
to execute bits when F_SEAL_EXEC is set.
This also fixes the memfd_test hugetlbfs SEAL-EXEC subtest, where
fchmod() incorrectly succeeded after applying F_SEAL_EXEC.
Fixes: 6fd7353829ca ("mm/memfd: add F_SEAL_EXEC")
Cc: stable@vger.kernel.org
Signed-off-by: Eva Kurchatova <eva.kurchatova@virtuozzo.com>
Link: https://patch.msgid.link/20260629180247.2343229-1-eva.kurchatova@virtuozzo.com
Acked-by: Pedro Falcato <pfalcato@suse.de>
Acked-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Acked-by: Zi Yan <ziy@nvidia.com>
Tested-by: Gregory Price (Meta) <gourry@gourry.net>
Reviewed-by: Muchun Song <muchun.song@linux.dev>
[ david: use common helper; fixup Fixes:; check only regular files ]
Signed-off-by: David Hildenbrand (Arm) <david@kernel.org>
---
fs/hugetlbfs/inode.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c
index 01c4d6f44ebe..02e0a65d596d 100644
--- a/fs/hugetlbfs/inode.c
+++ b/fs/hugetlbfs/inode.c
@@ -28,6 +28,7 @@
#include <linux/folio_batch.h>
#include <linux/fs_parser.h>
#include <linux/mman.h>
+#include <linux/memfd.h>
#include <linux/slab.h>
#include <linux/dnotify.h>
#include <linux/statfs.h>
@@ -840,6 +841,13 @@ static int hugetlbfs_setattr(const struct mnt_idmap *idmap,
if (error)
return error;
+ if (S_ISREG(inode->i_mode) && (ia_valid & ATTR_MODE)) {
+ error = memfd_check_seals_mode(info->seals, inode->i_mode,
+ attr->ia_mode);
+ if (error)
+ return error;
+ }
+
trace_hugetlbfs_setattr(inode, dentry, attr);
if (ia_valid & ATTR_SIZE) {
--
2.43.0
next prev parent reply other threads:[~2026-10-28 9:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 9:54 [PATCH v3 00/15] mm/shmem: various (urgent?) fixes David Hildenbrand (Arm)
2026-10-28 9:54 ` [PATCH v3 01/15] mm/mempolicy: charge shared policy nodes David Hildenbrand (Arm)
2026-10-28 10:02 ` Balbir Singh
2026-10-28 10:06 ` David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 02/15] tmpfs: keep the quota soft limits of an unused id David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 03/15] tmpfs: preserve explicitly disabled quota limits David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 04/15] mm/shmem: honour F_SEAL_EXEC when an ACL is set David Hildenbrand (Arm)
2026-10-28 10:06 ` Balbir Singh
2026-10-28 20:37 ` David Hildenbrand (Arm)
2026-10-28 9:55 ` David Hildenbrand (Arm) [this message]
2026-10-28 10:51 ` [PATCH v3 05/15] hugetlbfs: enforce F_SEAL_EXEC in setattr Oscar Salvador (SUSE)
2026-10-28 9:55 ` [PATCH v3 06/15] mm/shmem: hold off eviction in shmem_writeout() David Hildenbrand (Arm)
2026-10-28 20:35 ` sashiko-bot
2026-10-28 20:51 ` David Hildenbrand (Arm)
2026-10-29 9:26 ` David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 07/15] mm/shmem: stop retrying folios that cannot be split David Hildenbrand (Arm)
2026-10-28 23:10 ` Balbir Singh
2026-10-28 9:55 ` [PATCH v3 08/15] mm/shmem: preserve data in clean folios when splitting fails David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 09/15] mm/shmem: discard whole new large folios on fallocate rollback David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 10/15] mm/shmem: rescan after nonuniform folio splitting David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 11/15] mm/shmem: fix truncate hang in large swap entry David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 12/15] mm/shmem: preserve allocation errors when swapping in large entries David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 13/15] mm/shmem: fix truncate loop after boundary swapin failure David Hildenbrand (Arm)
2026-10-28 17:14 ` Nhat Pham
2026-10-28 9:55 ` [PATCH v3 14/15] mm/shmem: fix accounting of swapin-error markers David Hildenbrand (Arm)
2026-10-28 9:55 ` [PATCH v3 15/15] mm/shmem: fix truncation of files containing only " David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028-fixes_shmem-v3-5-4ce3baf2db4b@kernel.org \
--to=david@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=chrisl@kernel.org \
--cc=cmaiolino@redhat.com \
--cc=dverkamp@chromium.org \
--cc=eva.kurchatova@virtuozzo.com \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=jeffxu@google.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kas@kernel.org \
--cc=kasong@tencent.com \
--cc=lczerner@redhat.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=nao.horiguchi@gmail.com \
--cc=nphamcs@gmail.com \
--cc=osalvador@suse.de \
--cc=pfalcato@suse.de \
--cc=rakie.kim@sk.com \
--cc=stable@vger.kernel.org \
--cc=stevensd@chromium.org \
--cc=vdavydov.dev@gmail.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.