From: Corey Smith <corsmith@gmail.com>
To: corsmith@gmail.com, Vijendar.Mukunda@amd.com,
venkataprasad.potturu@amd.com
Cc: linux-sound@vger.kernel.org
Subject: [PATCH 2/11] soundwire: amd: support ACP6x SoundWire managers
Date: Tue, 27 Oct 2026 22:05:43 -0400 [thread overview]
Message-ID: <20261028020552.35278-3-corsmith@gmail.com> (raw)
In-Reply-To: <20261028020552.35278-1-corsmith@gmail.com>
Rembrandt (ACP6x) uses the same SoundWire manager layout as ACP6.3:
the SDW0/SDW1 data-port register maps and the TX/RX port counts are
identical. Accept the ACP6x PCI revisions and reuse the ACP6.3
register maps and port counts.
This assumes the ACP6x SoundWire block is register compatible with
ACP6.3 and needs to be validated on hardware.
Assisted-by: LLM
Signed-off-by: Corey Smith <corsmith@gmail.com>
---
drivers/soundwire/amd_manager.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
index a3316ef..697ec93 100644
--- a/drivers/soundwire/amd_manager.c
+++ b/drivers/soundwire/amd_manager.c
@@ -559,6 +559,8 @@ static int amd_sdw_port_params(struct sdw_bus *bus, struct sdw_port_params *p_pa
dev_dbg(amd_manager->dev, "p_params->num:0x%x\n", p_params->num);
switch (amd_manager->acp_rev) {
+ case ACP6X_PCI_REV_ID:
+ case ACP6XR_PCI_REV_ID:
case ACP63_PCI_REV_ID:
switch (amd_manager->instance) {
case ACP_SDW0:
@@ -602,6 +604,8 @@ static int amd_sdw_transport_params(struct sdw_bus *bus,
u32 offset_reg, lane_ctrl_ch_en_reg;
switch (amd_manager->acp_rev) {
+ case ACP6X_PCI_REV_ID:
+ case ACP6XR_PCI_REV_ID:
case ACP63_PCI_REV_ID:
switch (amd_manager->instance) {
case ACP_SDW0:
@@ -674,6 +678,8 @@ static int amd_sdw_port_enable(struct sdw_bus *bus,
u32 lane_ctrl_ch_en_reg;
switch (amd_manager->acp_rev) {
+ case ACP6X_PCI_REV_ID:
+ case ACP6XR_PCI_REV_ID:
case ACP63_PCI_REV_ID:
switch (amd_manager->instance) {
case ACP_SDW0:
@@ -1100,6 +1106,8 @@ static int amd_sdw_manager_probe(struct platform_device *pdev)
amd_manager->bus.controller_id = 0;
dev_dbg(dev, "acp_rev:0x%x\n", amd_manager->acp_rev);
switch (amd_manager->acp_rev) {
+ case ACP6X_PCI_REV_ID:
+ case ACP6XR_PCI_REV_ID:
case ACP63_PCI_REV_ID:
switch (amd_manager->instance) {
case ACP_SDW0:
next prev parent reply other threads:[~2026-10-28 2:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 2:05 [PATCH 0/11] ASoC/soundwire: AMD ACP6x (Rembrandt) SoundWire speaker support Corey Smith
2026-10-28 2:05 ` [PATCH 1/11] soundwire: amd: add ACP6x PCI revision ids Corey Smith
2026-10-28 2:05 ` Corey Smith [this message]
2026-10-28 2:05 ` [PATCH 3/11] ASoC: amd: ps: " Corey Smith
2026-10-28 2:15 ` sashiko-bot
2026-10-28 2:05 ` [PATCH 4/11] ASoC: amd: ps: support ACP6x in the SoundWire DMA driver Corey Smith
2026-10-28 2:05 ` [PATCH 5/11] ASoC: amd: acp: add ACP6x (Rembrandt) SoundWire machine table Corey Smith
2026-10-28 2:05 ` [PATCH 6/11] ASoC: amd: acp-config: route HP Dragonfly Pro ONE through the ACP6x SDW stack Corey Smith
2026-10-28 2:05 ` [PATCH 7/11] ASoC: amd: ps: probe the ACP6x SoundWire stack Corey Smith
2026-10-28 2:20 ` sashiko-bot
2026-10-28 2:05 ` [PATCH 8/11] ASoC: amd: acp: add ACP6x SoundWire quirks and machine support Corey Smith
2026-10-28 2:22 ` sashiko-bot
2026-10-28 2:05 ` [PATCH 9/11] soundwire: amd: accept the legacy mipi-sdw-master-list property Corey Smith
2026-10-28 2:05 ` [PATCH 10/11] ASoC: amd: ps: harden the ACP interrupt path for ACP6x Corey Smith
2026-10-28 2:21 ` sashiko-bot
2026-10-28 2:05 ` [PATCH 11/11] soundwire: amd: provide defaults for the bus clock properties Corey Smith
2026-10-29 6:58 ` [PATCH 0/11] ASoC/soundwire: AMD ACP6x (Rembrandt) SoundWire speaker support Mukunda,Vijendar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028020552.35278-3-corsmith@gmail.com \
--to=corsmith@gmail.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=linux-sound@vger.kernel.org \
--cc=venkataprasad.potturu@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.