From: "Michael S. Tsirkin" <mst@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: sgarzare@redhat.com, pierrick.bouvier@oss.qualcomm.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH 0/2] vhost-user: drop support for postcopy+CONFIGURE_MEM_SLOTS
Date: Wed, 28 Oct 2026 08:38:40 -0400 [thread overview]
Message-ID: <20261028083556-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20260916182917.820031-1-vsementsov@yandex-team.ru>
On Wed, Sep 16, 2026 at 09:29:15PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> Hi all!
>
> The combination of postcopy and CONFIGURE_MEM_SLOTS is neither properly
> documented nor correctly implemented, see details in 01. I suggest to
> drop it for now, and document that fact.
>
> Vladimir Sementsov-Ogievskiy (2):
> vhost-user: drop postcopy support for CONFIGURE_MEM_SLOTS case
> vhost-user: drop extra "else" in vhost_user_set_mem_table_postcopy()
what I get, after reading 1: , memory hotplug is broken with this,
indeed. However, pretty much everyone negotiates CONFIGURE_MEM_SLOTS
so this would just break postcopy for everyone, no?
Not a good tradeoff.
How about we just fix the issues, or at least the major ones?
> docs/interop/vhost-user.rst | 30 +++-
> hw/virtio/vhost-user.c | 296 +++++++++++-------------------------
> 2 files changed, 116 insertions(+), 210 deletions(-)
>
> --
> 2.43.0
prev parent reply other threads:[~2026-10-28 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 18:29 [PATCH 0/2] vhost-user: drop support for postcopy+CONFIGURE_MEM_SLOTS Vladimir Sementsov-Ogievskiy
2026-09-16 18:29 ` [PATCH 1/2] vhost-user: drop postcopy support for CONFIGURE_MEM_SLOTS case Vladimir Sementsov-Ogievskiy
2026-09-16 18:29 ` [PATCH 2/2] vhost-user: drop extra "else" in vhost_user_set_mem_table_postcopy() Vladimir Sementsov-Ogievskiy
2026-10-28 12:38 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028083556-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.