All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
	"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Brian Masney" <bmasney+clk@redhat.com>,
	"Jerome Brunet" <jbrunet+clk@baylibre.com>,
	"Ulf Hansson" <ulfh@kernel.org>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 07/11] dt-bindings: clock: renesas,r8a78000-cpg: Add PWM clocks
Date: Wed, 28 Oct 2026 15:29:37 +0200	[thread overview]
Message-ID: <20261028132937.GL15441@killaraus.ideasonboard.com> (raw)
In-Reply-To: <e723696e02cfb34fb808e2ae3ccb6faf68528c00.1793026273.git.geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

On Mon, Oct 26, 2026 at 03:55:23PM +0100, Geert Uytterhoeven wrote:
> Add definitions for the clocks used by the PWM modules on R-Car X5H:
>  - R8A78000_CPG_SGASYNCD16_PERW_MAIN,
>  - R8A78000_CPG_S0ASYNCD8_PERW_MAIN.
> Include R8A78000_CPG_SGASYNCD8_PERW_MAIN for ordering consistency.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> This depends on "[PATCH 2/7] dt-bindings: clock: renesas,r8a78000-cpg:
> Add GPIO clocks"
> https://lore.kernel.org/624a9fb09e4ec74b1995797e5121b86e7206f5f2.1792776697.git.geert+renesas@glider.be
> ---
>  include/dt-bindings/clock/renesas,r8a78000-cpg.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/clock/renesas,r8a78000-cpg.h b/include/dt-bindings/clock/renesas,r8a78000-cpg.h
> index cd7192ccecd4e22c..8c30476d41448cf5 100644
> --- a/include/dt-bindings/clock/renesas,r8a78000-cpg.h
> +++ b/include/dt-bindings/clock/renesas,r8a78000-cpg.h
> @@ -28,5 +28,8 @@
>  #define R8A78000_CPG_SGD8_PERW_BUS		18
>  #define R8A78000_CPG_SGD32_PERW_BUS		19
>  #define R8A78000_CPG_S0D24_HSCN_OTHER		20
> +#define R8A78000_CPG_SGASYNCD8_PERW_MAIN	21
> +#define R8A78000_CPG_SGASYNCD16_PERW_MAIN	22

Could you also add R8A78000_CPG_SGASYNCD4_PERW_MAIN and
R8A78000_CPG_SGASYNCD32_PERW_MAIN for ordering consistency ? The
dependency patch should then also include R8A78000_CPG_SGD4_PERW_BUS and
R8A78000_CPG_SGD16_PERW_BUS, as well as
R8A78000_CPG_S0D{1,2,4,8,12,16}_HSCN_OTHER.

> +#define R8A78000_CPG_S0ASYNCD8_PERW_MAIN	23
>  
>  #endif /* __DT_BINDINGS_CLOCK_RENESAS_R8A78000_CPG_H__ */

-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2026-10-28 13:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26 14:55 [PATCH 00/11] arm64: renesas: r8a78000: Add PWM support Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH 01/11] dt-bindings: pwm: renesas,tpu-pwm: Add support for R-Car X5H Geert Uytterhoeven
2026-10-28 13:01   ` Krzysztof Kozlowski
2026-10-26 14:55 ` [PATCH 02/11] dt-bindings: pwm: renesas,pwm-rcar: " Geert Uytterhoeven
2026-10-28 13:06   ` Krzysztof Kozlowski
2026-10-26 14:55 ` [PATCH 03/11] pwm: rcar: Use FIELD_PREP() for PWMCR_CC0 access Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH 04/11] pwm: rcar: Add helper variable dev to rcar_pwm_probe() Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH 05/11] pwm: rcar: Parametrize cycle counter field size Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH 06/11] pwm: rcar: Add support for R-Car Gen5 Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH 07/11] dt-bindings: clock: renesas,r8a78000-cpg: Add PWM clocks Geert Uytterhoeven
2026-10-28 13:07   ` Krzysztof Kozlowski
2026-10-28 13:29   ` Laurent Pinchart [this message]
2026-10-28 14:43     ` Geert Uytterhoeven
2026-10-28 16:39       ` Laurent Pinchart
2026-10-29  9:08         ` Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH 08/11] arm64: dts: renesas: r8a78000: Add PWM nodes Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH/DNI 09/11] clk: renesas: r8a78000: Add PWM clocks Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH/DNI 10/11] pmdomain: renesas: r8a78000: Add PWM support Geert Uytterhoeven
2026-10-26 14:55 ` [PATCH/DNI 11/11] arm64: dts: renesas: ironhide: Enable PWM Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261028132937.GL15441@killaraus.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ukleinek@kernel.org \
    --cc=ulfh@kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.