From: Christoph Hellwig <hch@lst.de>
To: Yuho Choi <oss.patchbox@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] nvme-pci: shut down the controller if disabling the HMB fails on suspend
Date: Wed, 28 Oct 2026 15:56:29 +0100 [thread overview]
Message-ID: <20261028145629.GA15112@lst.de> (raw)
In-Reply-To: <20261022045828.1392332-2-oss.patchbox@gmail.com>
On Thu, Oct 22, 2026 at 12:58:18AM -0400, Yuho Choi wrote:
> This was found by code inspection as part of ongoing, not yet
> published research. It has not been reproduced on hardware.
> Compile-tested only (x86_64 defconfig with BLK_DEV_NVME=y, W=1).
Yeah, the only way this really should happen is a communication
failure. But your handling looks correct, so:
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2026-10-28 14:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 4:58 [PATCH v1] nvme-pci: shut down the controller if disabling the HMB fails on suspend Yuho Choi
2026-10-28 14:56 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028145629.GA15112@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=oss.patchbox@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.