[PATCH libftnl 08/12] src: set: clear field_len array before copying

[Florian Westphal <fw@strlen.de>]

LLM flagged:
      if (data_len > sizeof(s->desc.field_len))
          return -1;

      memcpy(&s->desc.field_len, data, data_len);
      for (s->desc.field_count = 0;
           s->desc.field_count < NFT_REG32_COUNT;
           s->desc.field_count++) {
          if (!s->desc.field_len[s->desc.field_count]) // here

i.e. it relies on the inital zero state.

If for any reason a 2nd call is made that shinks field_len
array, the loop would read stale count from previous
incarnation.

Signed-off-by: Florian Westphal <fw@strlen.de>
---
 src/set.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/set.c b/src/set.c
index 22fd4a839f80..fc50f3f28055 100644
--- a/src/set.c
+++ b/src/set.c
@@ -188,6 +188,7 @@ int nftnl_set_set_data(struct nftnl_set *s, uint16_t attr, const void *data,
 		if (data_len > sizeof(s->desc.field_len))
 			return -1;
 
+		memset(&s->desc.field_len, 0, sizeof(s->desc.field_len));
 		memcpy(&s->desc.field_len, data, data_len);
 		for (s->desc.field_count = 0;
 		     s->desc.field_count < NFT_REG32_COUNT;
-- 
2.55.0