Re: [PATCH net v6 3/6] nfc: nci: uart: quiesce callbacks during teardown

[Simon Horman <horms@kernel.org>]

On Sun, Oct 25, 2026 at 04:03:57AM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 0 (3) · Medium: 2 · Low: 1
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).

Hi Shubham,

The text above requests a response to this email, and similar ones sent
for other patches of this patch-set. And I would appreciate it if you could
provide such responses.

FWIIW, the Medium issue immediately below is of most concern to me.

> 
> - [Medium] When nci_uart_tty_close() tears down an NCI UART whose NCI
>   device is up, the NFC controller (NFCC) is left running in whatever RF…
> - [Medium] Baseline decision: fixed later in the series.
> - [Low] Baseline decision: not a bug in practice.
> 
> Pre-existing issues:
> - [High] Pre-existing problem, not introduced by this patch: during a
>   Marvell firmware download, the UART peer (NFCC) controls a 16-bit…
> - [High] Pre-existing problem, not introduced by this patch: the Marvell
>   firmware download copies from the firmware image at a peer-advanced…
> - [High] Baseline decision: pre-existing and fixed later in the series.
> 
> --

...