From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793208249; b=e08ppCZ2Gvb0FHtbPvgJWFk6F984P9vZdLPpYxdlIU+tjAdzZz/y0rOSHqDgVqONVGad 1NrYYR8dVXrTzG6epB5tygmxc8xcbtkGHrBeNetAaEw+CmdrXayI494229loKZfXiUGZe rSTjqH3ZDEuRL+pX9nLVdl9JhFxbMzweTQeXyNY97kxM3uHZkH7w1wePopbCukY11bY8V sEWgeLFflFzFGfNp06QN95gsOHF1yPxTnHqIxOHILBp8B9nYntxG9Li8uUjZvlg8vAyvQ HL9TNgZm3gkDRpGeb//2lgsvn4kAx32P43VFrAy6P7oFSiFMxCcP3xDLonntWl0I5MA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793208249; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=R/YmJDBNw6gDO1YHekHA+p0joJLwz1frODpzYj2BzBk=; b=n+uiXBMw4e77Mh7ZZklRP3yLmZS39dVrq36eisQGZatRl8tw3q+vYoykrQb1AVM1as+Q YRAU/evgR+N7P49gOtu6eedjuCvPG83qOpkPUVnaBzAQtrwlr5m1qlFRrMl7h4uqvy7IP QASfnUDec0fit8URhwenLA4fOpUksd7rZlAdiw7Ib6lF/uAKm6oA1KkZCY4Z0lCNd8TV1 13nzzQLXtY3nuDxUvtL1XIS2pWUAVwbE9IvN7bNaqxGYS6ovRrSUgMyzrreRKEk3JzNlT rT7/FyW4DV1Q1fCbtR+EXq6JX18QRGexo6mk5mpfQ6QE4rvb9WRB2gGzXDnCd/CvQdQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=b6FRRn2e; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C85D606A31C; Wed, 28 Oct 2026 17:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=b6FRRn2e Received: by smtp.kernel.org (Postfix) with ESMTPSA id 731B91F01825; Wed, 28 Oct 2026 17:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793208249; bh=R/YmJDBNw6gDO1YHekHA+p0joJLwz1frODpzYj2BzBk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=b6FRRn2erQYvzow8JTFYDMmroU2FNm4FFzG5DnTcZcrPmJKRFxab8rjyEzAIxTNDv oDiT0QAEMqZ63q7w9ulCN3Kxp6pK9MI+RQJwhWyrFYo8CtcHLNug8XT2pcqyPBZt7c A4vuyjdnObKdLFO3ArSYC3S6NZmoFd9rSCGzsgWA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joseph Qi , Heming Zhao , Mark Fasheh , Joel Becker , Junxiao Bi , Changwei Ge , Jun Piao , Andrew Morton , Sasha Levin Subject: [PATCH 5.10 010/516] ocfs2: validate dx_root extent list fields during block read Date: Wed, 28 Oct 2026 17:52:42 +0100 Message-ID: <20261028170003.772199816@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170003.522232767@linuxfoundation.org> References: <20261028170003.522232767@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joseph Qi [ Upstream commit 775c17386a6fd695f999d4cda90e3931386570dd ] Patch series "ocfs2: consolidate extent list validation into block read callbacks". ocfs2 validates extent list fields (l_count, l_next_free_rec) at various points during extent tree traversal. This is fragile because each caller must remember to check for corrupted on-disk data before using it. This series moves those checks into the block read validation callbacks (ocfs2_validate_dx_root and ocfs2_validate_extent_block), so corrupted fields are caught early at block read time. Redundant post-read checks are then removed. This patch (of 4): Move the extent list l_count validation from ocfs2_dx_dir_lookup_rec() into ocfs2_validate_dx_root(), so that corrupted on-disk fields are caught early at block read time rather than during directory lookups. Additionally, add a l_next_free_rec <= l_count check to prevent out-of-bounds access when iterating over extent records. Both checks are skipped for inline dx roots (OCFS2_DX_FLAG_INLINE), which use dr_entries instead of dr_list. Link: https://lkml.kernel.org/r/20260403090803.3860971-1-joseph.qi@linux.alibaba.com Link: https://lkml.kernel.org/r/20260403090803.3860971-2-joseph.qi@linux.alibaba.com Signed-off-by: Joseph Qi Reviewed-by: Heming Zhao Cc: Mark Fasheh Cc: Joel Becker Cc: Junxiao Bi Cc: Changwei Ge Cc: Jun Piao Signed-off-by: Andrew Morton Stable-dep-of: bc70726ddad5 ("ocfs2: validate directory-index entry counts when reading metadata") Signed-off-by: Sasha Levin --- fs/ocfs2/dir.c | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c index f7a7239a69cfa..b74775e56bb2f 100644 --- a/fs/ocfs2/dir.c +++ b/fs/ocfs2/dir.c @@ -582,7 +582,7 @@ static int ocfs2_validate_dx_root(struct super_block *sb, mlog(ML_ERROR, "Checksum failed for dir index root block %llu\n", (unsigned long long)bh->b_blocknr); - return ret; + goto bail; } if (!OCFS2_IS_VALID_DX_ROOT(dx_root)) { @@ -590,8 +590,32 @@ static int ocfs2_validate_dx_root(struct super_block *sb, "Dir Index Root # %llu has bad signature %.*s\n", (unsigned long long)le64_to_cpu(dx_root->dr_blkno), 7, dx_root->dr_signature); + goto bail; + } + + if (!(dx_root->dr_flags & OCFS2_DX_FLAG_INLINE)) { + struct ocfs2_extent_list *el = &dx_root->dr_list; + + if (le16_to_cpu(el->l_count) != ocfs2_extent_recs_per_dx_root(sb)) { + ret = ocfs2_error(sb, + "Dir Index Root # %llu has invalid l_count %u (expected %u)\n", + (unsigned long long)le64_to_cpu(dx_root->dr_blkno), + le16_to_cpu(el->l_count), + ocfs2_extent_recs_per_dx_root(sb)); + goto bail; + } + + if (le16_to_cpu(el->l_next_free_rec) > le16_to_cpu(el->l_count)) { + ret = ocfs2_error(sb, + "Dir Index Root # %llu has invalid l_next_free_rec %u (l_count %u)\n", + (unsigned long long)le64_to_cpu(dx_root->dr_blkno), + le16_to_cpu(el->l_next_free_rec), + le16_to_cpu(el->l_count)); + goto bail; + } } +bail: return ret; } -- 2.53.0