From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793208605; b=0nshgA6TTOtLzoyD4xJF+EvvgV9N/lm2hdEEO0y94D5w+nhxdObZnnjlECoFuw/98565 iJLG4h2PdygdSNWRXNQip4fhkbdYTsRd3dgR8m4T4lT9xmZPVoN4lVu+9szG3T24wiArp +IZF7nf0F8R4/+Acst+arZEG8xPsdXaPyU0in6BZPdZTQTbYBuXkLS7/Mtae5HAiAK7nP 40ktKKE8++DXGSfa/HWDUbTt2kXpZDNpobEN3P6mLgW2Q/EtIhNGrWEtUfxMAYaxyO+HN canQCkRV99kYHsCOn1z8Y8nkoAH8H2TUTIhqNWD4d1r+FFxksIAgMud4tKbqLkVXcTQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793208605; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=/EMOEK+G5x2HNhQYtjorG9M3Q8h3hBo7pr/8HijV9N4=; b=KM+aTF391EvRfZUms4AW58ALxxHBNGtHiRJ45fxFOPpYzK+8QWUhsvuQBjlRUdnC5KU9 jJJYUl1cDRNB45o35W7SrWXT7K+hrdwfQ8VGsOWz6vBqFAf9aKDCC4M9kq74gtfPjHNpf vOmOeR5VMeE/BCmNCgi60HAiztRszYogUpMM9vVTqXsQb0oen0wV9ILL9AQxtu17SSgg3 8x+nf+ubq5dJMz9UVmnT4zoiok3zoJjq+WG0a8jq4V57VkAk8zJOt75FPRv8pP7w4NzyX CdOLoK+PIER9xNGRWP7T/gp+R8gA9TdkZcW+8Pl/KecPY6SztmxquBE7jZHrrzxTGbA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wzp6VyAi; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F406B606A31D; Wed, 28 Oct 2026 17:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=wzp6VyAi Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5071C1F01825; Wed, 28 Oct 2026 17:30:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793208604; bh=/EMOEK+G5x2HNhQYtjorG9M3Q8h3hBo7pr/8HijV9N4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wzp6VyAipUUms1i/wUiSc8ZYLY6ZQLeo1ShBJdK/2T9fKlRungvPbHAXrzK9pYl/d EgT4sjkdtv1OX8Iu6LGnQNMLUbjH64gW/7JCzoH8Jj8ogu0oHkrPYsvY0IErFxg5e+ brXB1GGqyTLsoFENZHDf3t9gyHGcqQ9vYkJKereI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+9408fbe0e6452a12e9ab@syzkaller.appspotmail.com, Eric Dumazet , Xuanqiang Luo , Ido Schimmel , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 177/516] ipv6: sr: use skb_get_hash_net() in seg6_make_flowlabel() Date: Wed, 28 Oct 2026 17:55:29 +0100 Message-ID: <20261028170007.698596848@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170003.522232767@linuxfoundation.org> References: <20261028170003.522232767@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Eric Dumazet [ Upstream commit 8ec454dcd00ce3375119111c6394964455b36d0d ] Since commit d58e468b1112 ("flow_dissector: implements flow dissector BPF hook") __skb_flow_dissect() needs a net pointer, either from skb->dev, skb->sk, or since commit 3cbf4ffba5ee ("net: plumb network namespace into __skb_flow_dissect") a caller provided pointer. syzbot was able to reach seg6_make_flowlabel() with an skb having neither skb->dev nor skb->sk set: a TIPC UDP bearer sends a discovery message through an IPv4 route using seg6 encap, while net.ipv6.seg6_flowlabel is set to 1. seg6_make_flowlabel() already has a net pointer, use skb_get_hash_net(). WARNING: net/core/flow_dissector.c:1131 at __skb_flow_dissect+0x910/0x5368 net/core/flow_dissector.c:1126, CPU#0: syz.0.17/4930 Call trace: __skb_flow_dissect+0x910/0x5368 net/core/flow_dissector.c:1126 (P) __skb_get_hash_net+0xe0/0x29c net/core/flow_dissector.c:1903 skb_get_hash include/linux/skbuff.h:1663 [inline] seg6_make_flowlabel+0xcc/0x1ec net/ipv6/seg6_iptunnel.c:132 __seg6_do_srh_encap+0x320/0xbf4 net/ipv6/seg6_iptunnel.c:161 seg6_do_srh+0x4b4/0xa44 net/ipv6/seg6_iptunnel.c:431 seg6_output_core+0x164/0x688 net/ipv6/seg6_iptunnel.c:681 seg6_output+0x44/0x1ac net/ipv6/seg6_iptunnel.c:744 lwtunnel_output+0x3d0/0x664 net/core/lwtunnel.c:356 dst_output include/net/dst.h:470 [inline] ip_local_out+0x110/0x148 net/ipv4/ip_output.c:131 iptunnel_xmit+0x50c/0xd38 net/ipv4/ip_tunnel_core.c:97 udp_tunnel_xmit_skb+0x220/0x348 net/ipv4/udp_tunnel_core.c:187 tipc_udp_xmit+0x75c/0x9c0 net/tipc/udp_media.c:202 tipc_udp_send_msg+0x214/0x374 net/tipc/udp_media.c:274 tipc_bearer_xmit_skb+0x260/0x3b0 net/tipc/bearer.c:576 tipc_enable_bearer net/tipc/bearer.c:366 [inline] __tipc_nl_bearer_enable+0xc90/0xfb0 net/tipc/bearer.c:1048 tipc_nl_bearer_enable+0x2c/0x48 net/tipc/bearer.c:1057 genl_family_rcv_msg_doit+0x1e4/0x2d4 net/netlink/genetlink.c:1114 Fixes: d58e468b1112 ("flow_dissector: implements flow dissector BPF hook") Reported-by: syzbot+9408fbe0e6452a12e9ab@syzkaller.appspotmail.com Closes: https://lore.kernel.org/netdev/6abac2eb.3654fce1.1bec97.0000.GAE@google.com/ Signed-off-by: Eric Dumazet Reviewed-by: Xuanqiang Luo Reviewed-by: Ido Schimmel Link: https://patch.msgid.link/20260928194524.3617299-1-edumazet@kernel.org Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/ipv6/seg6_iptunnel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/seg6_iptunnel.c b/net/ipv6/seg6_iptunnel.c index 5da46c76d335a..1e640967e6928 100644 --- a/net/ipv6/seg6_iptunnel.c +++ b/net/ipv6/seg6_iptunnel.c @@ -113,7 +113,7 @@ static __be32 seg6_make_flowlabel(struct net *net, struct sk_buff *skb, u32 hash; if (do_flowlabel > 0) { - hash = skb_get_hash(skb); + hash = skb_get_hash_net(net, skb); hash = rol32(hash, 16); flowlabel = (__force __be32)hash & IPV6_FLOWLABEL_MASK; } else if (!do_flowlabel && skb->protocol == htons(ETH_P_IPV6)) { -- 2.53.0