From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793208685; b=3zAcTXW1AJWO+fVxWwPtcy7AQspxBG2n+3Xj3ADWTzNUL7NLGSVsafnb+xUeij3FU5xi m/lBEnzv1mMcDnjfFVhpshKYHnriK/uq0GI8HZsSq7R12xM+IpPLkDIKSZYsrG4abPYXv QdUSyJzM6jR4rzJ03uUta2hHPvzeJVePZglTfnB8EwHsG0guJaRRSKiaw8zgfivBbV6kK IWlCij/8XQiXvkKwEFnmv87/69PWcimp3qKRy2YCa0wvXCPTHMnaV1xGkRGDPnT4lOczH pkKIQDtth0gxc0X8d4RluH4HCm+E0l/pOVUq5xefuSwK5KmlvAbA+3T6nl1cJSnMwag== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793208685; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=CDOkHLAoUsrGQF7Y9Kexmc4CC6bdriON1Pkf8lFoJOM=; b=QWxpO2QB08YWeVuTTK2UwDrOssLz/YTkt/pJiLAMXblTIciIebMJ6H60dpBwVaYIeqNy ipZ+/CGIEua0n2HKPUDY23rOOPaOuBkXDyBSxyyXIWxfcy3YYfw0D4KzDCAtHL5RiRgHB 8zY/3fkdEzmUAYejxmm3QPjQUSQZOcsW/RcdU1JhndcODwcukNuwpkxey3nSDWhP6raxZ 6tanEHXQYkSwkXK17cWZum4aNVG1TuYhmu/kZUA6uV7cCq/FSesxWU3KccKxFx81i0RFm uZgEqDby9QEBF2sqTcJGLILLXHq8NoxvVoXaorPv1Dg3WJd7ty2CjhaW7iJm1IancKw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=vOkkonjC; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16BBD606A32F; Wed, 28 Oct 2026 17:31:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=vOkkonjC Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2603A1F01825; Wed, 28 Oct 2026 17:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793208684; bh=CDOkHLAoUsrGQF7Y9Kexmc4CC6bdriON1Pkf8lFoJOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=vOkkonjC25eCdA6CRbgGF7OF8AIghiCQUzrIB1cF25chNpCeZhqv+oGU08HxNTpCq sGCXebnlzQq7fhEXK1/S923L0ytP1OqzkoYc5FzG/OT9yJuvr/2Oa772LgioaM//Yq x4ONeKkGxGzkm5FlbBUrbhWl3+MwUhe9xvsR/eQQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Syed Labeeq Sajid Bukhari Subject: [PATCH 5.10 189/516] usb: storage: sierra_ms: reject short SWoC info transfers Date: Wed, 28 Oct 2026 17:55:41 +0100 Message-ID: <20261028170007.980031536@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170003.522232767@linuxfoundation.org> References: <20261028170003.522232767@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Syed Labeeq Sajid Bukhari commit 8a0200d14acd9db388b85cd016e68a4e60d900ec upstream. sierra_get_swoc_info() requests sizeof(struct swoc_info) (60) bytes from the device via usb_control_msg(), but its callers only treat a negative return value as failure. A device that answers the vendor-specific GetSwocInfo request with a short IN transfer is therefore accepted, leaving the tail of the freshly allocated (kmalloc(), non-zeroing) swoc_info buffer uninitialized. truinst_show() subsequently prints swocInfo->rev, swocInfo->LinuxSKU and swocInfo->LinuxVer from that buffer into the world-readable (0444) "truinst" sysfs attribute. An emulated/malicious USB device (VID 0x1199, PID 0x0fff) can exploit this to disclose up to 5 bytes of stale kernel heap memory (kmalloc-64) to unprivileged userspace, once per sysfs read, indefinitely. On kernels built without init_on_alloc this leaks recently freed heap contents. Only accept the transfer when the full structure was received. sierra_ms_init() already retries failed queries, so well-behaved devices are unaffected. Fixes: 32fe5e393455 ("USB Storage Sierra: TRU-Install feature update") Cc: stable Signed-off-by: Syed Labeeq Sajid Bukhari Assisted-by: Kimi:K2 [Kimi Code CLI] Link: https://patch.msgid.link/20260910140343.49371-1-syedlabeeq@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/sierra_ms.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/usb/storage/sierra_ms.c +++ b/drivers/usb/storage/sierra_ms.c @@ -77,6 +77,13 @@ static int sierra_get_swoc_info(struct u sizeof(struct swoc_info), /* __u16 size */ USB_CTRL_SET_TIMEOUT); /* int timeout */ + /* + * A short IN transfer leaves the tail of swocInfo uninitialized; + * only a full transfer is valid. + */ + if (result != sizeof(struct swoc_info)) + return -EIO; + swocInfo->LinuxSKU = le16_to_cpu(swocInfo->LinuxSKU); swocInfo->LinuxVer = le16_to_cpu(swocInfo->LinuxVer); return result;