From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793210741; b=JoqZFhcab+8Z7xq0QE3cCirknxOdQ2rNWU9yS9fSKgdUYndJPUlKWSyTQA80Xzdc+BFu BMMi4H/UMuR5XdmpoDAsSN3GqgbbdJ2sckEHRHesqfPoHC4F7HG+/x8VsL4yZEwUj2RT/ iNoHDroO0CGoZdZ7l0V7hwHEDuL2VsV6PoMpUqAfbyie3xXzQtbXCi8wkx0SPcTwkTsUh p7nQYF3c1h1AFg478jKAzwxYc8VG6Uh0SS8FO7W2yUlv42FyxNbpOJPKMccvY2uVhlNtV qA2SgFVPqoUq1hMNDCnaJgqH8z26odqWU3D6rZCAx/1UORlDpIkTSZTqCLY37WcC/KQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793210741; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=C/wsGbBJLBiGLpicr2kY1tXMOgdcmAEiN+hs1AWGe8A=; b=NIMqzBnMmXg2nNegiusAHj0rqftLgxEoCC5Ps9t6r7hGeeja6XkP3c58viPzVuTBdo6R w3uNDADyRp9RXfvpB8qsWXZ7CJHZYUcoVqg/DLyjT+x825DpeVFF5gPJSVqfEoIUE5Nrg IZJm9erQvt7Fnfr8X1bXFodYT5BCKuAMed/01lflTMKIIKEZmHBZOY3wleR4CnzDmb7r2 5UtuFXuSYh8T62w4CDFGKB6XRCvpnKYhUrUQJxC3sYcWa3kLu90O0cxu6i71JL+yHK3iW GnDuqINunfrL+qr5NFz12puEIgj0CMa05hDG9Gj5J1OmbLhk7UlpWbjkcaKl5hw+zVw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=l1Q60Nk+; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C51B606A31D; Wed, 28 Oct 2026 18:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=l1Q60Nk+ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E1CE1F01825; Wed, 28 Oct 2026 18:05:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793210740; bh=C/wsGbBJLBiGLpicr2kY1tXMOgdcmAEiN+hs1AWGe8A=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=l1Q60Nk+tcdj3qZ/62IcIqBYxi89YzNMwxCIDjIpMRSUsEB9RpBvCvg16QJQMApQ4 tEMxM1vDIhpFQYXLjNFrkJ5sFOMvB4UFBUmO7BoVEJFapngN8Rc9mPeMhHBohHiIid +KRGCpce1DM47BoxODiUYcZmmtpJS3GNM00LN6q8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Nilesh Javali , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 5.15 088/571] scsi: qla2xxx: Use memset_io() to clear QLAFX00 request ring slot Date: Wed, 28 Oct 2026 17:53:55 +0100 Message-ID: <20261028170010.113188716@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170008.009143722@linuxfoundation.org> References: <20261028170008.009143722@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali [ Upstream commit 626e44f3d8a924a97a3848a9fd45833947e081e9 ] For QLAFX00 the request ring is ioremapped device I/O memory (ha->iobase + req_que_off), not DMA-coherent RAM, which is why the rest of the FX00 path accesses it through memcpy_toio() and the wrt_reg_* helpers. __qla2x00_alloc_iocbs() however zeroed the producer slot with a plain memset(). On architectures such as ARM64 a regular memset() may emit unaligned or block-zeroing instructions (e.g. DC ZVA) that are invalid on Device memory, leading to a synchronous external abort. Use memset_io() to clear the slot for QLAFX00, matching the I/O accessors used elsewhere on this ring. Other adapters keep the plain memset() on their DMA-coherent rings. The zero-fill is retained for FX00 because its IOCB builders (e.g. qlafx00_fxdisc_iocb()) copy only part of the entry and rely on the unused tail being pre-zeroed. Fixes: 8ae6d9c7eb10 ("[SCSI] qla2xxx: Enhancements to support ISPFx00.") Cc: stable@vger.kernel.org Reported-by: Sashiko Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-12-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) [ replaced qla_req_ring_slot() and qla_req_entry_size() with req->ring_ptr and REQUEST_ENTRY_SIZE. ] Signed-off-by: Sasha Levin --- drivers/scsi/qla2xxx/qla_iocb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_iocb.c b/drivers/scsi/qla2xxx/qla_iocb.c index 7bccd525ee19b..f080e19529272 100644 --- a/drivers/scsi/qla2xxx/qla_iocb.c +++ b/drivers/scsi/qla2xxx/qla_iocb.c @@ -2347,11 +2347,13 @@ __qla2x00_alloc_iocbs(struct qla_qpair *qpair, srb_t *sp) /* Prep packet */ req->cnt -= req_cnt; pkt = req->ring_ptr; - memset(pkt, 0, REQUEST_ENTRY_SIZE); if (IS_QLAFX00(ha)) { + memset_io((void __iomem __force *)pkt, 0, + REQUEST_ENTRY_SIZE); wrt_reg_byte((u8 __force __iomem *)&pkt->entry_count, req_cnt); wrt_reg_dword((__le32 __force __iomem *)&pkt->handle, handle); } else { + memset(pkt, 0, REQUEST_ENTRY_SIZE); pkt->entry_count = req_cnt; pkt->handle = handle; } -- 2.53.0