From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793209120; b=U6j373ply8GwnyUZ8bb56VFHyZuStJeXvT8zNlwrOu121kCxlN+OcttHu1fruIRj5KjQ 1JAncOZip/UmtRJEOyCMW9vlCDmI1xbG1b2dc+L6yHbJZm2uclgQUg/fmyWXTmj2SQjMV SZkYKUlX8k1CDRgImK72TUPB3JAsOCiHrSmhLGSpoBLq48yVphXV0BmwziXf73H7NPgga B3YGxFuRRbfWZAKbZKrHdNCGgMZeYsYgHOjL47el9rrymUdqFyPG8Ke9O60jxo2ZVH9OK 5aJbrcEh+fz6TVyO2WsMdVGpgRsAAUPdT6PdVhIQOP+GY2viZq8fdTwwaTdQPEhqGmg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793209120; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=r29QZjGy1Abe0lG9xZkIgYALtCa1GRy+yyEWl0q9byM=; b=LqcA/C7YfvXvo8iv7aC+9dpsMSjGwIeTiZiXqL2rner4YP4N8pUA9IWw+Cv7XhzlAOx+ bxPKWwj/1RPQyTCzQ4KuNCjpOr37n7IAiFJr1XB285T0mYlCo3yYm5E3eYyi+LrK+3t6h Ztj/3k74JefMLp9/r0p4+XEiP9BzoKEZMYt41cTk4AdJe0p3CcAsP5G7MeZens57mcGuS rH8DnVB2pSTqihmn8/2K65+n0uqxTWnWOXZQdrBKakAOpo67fnrTuJlTcP9MOH+aWVCom E2HqX35jCFVlCj8Fut7II/Nmisctr9mYkDym4bm6uTEHOByWPhSXEJl78kqaHlc1Tnw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=T1AkpXZ2; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1D70606A322; Wed, 28 Oct 2026 17:38:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=T1AkpXZ2 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C84021F01825; Wed, 28 Oct 2026 17:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793209119; bh=r29QZjGy1Abe0lG9xZkIgYALtCa1GRy+yyEWl0q9byM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=T1AkpXZ28KulP+ZvkXHJ0mBMMHZTOR/VfI7k9uCbXtO9eeWVz8na/r5gSdoazJgBa LPAUexgC8tiRvicDFhjhu104toI/XZp8QWHgRhLuT7wn6b386tvv5w172TCTridRJM VQxXHlOa12e183pNtt24VzyVEwzu42UXE71saiLo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Marek Szyprowski , Mark Brown , Sasha Levin , "Claude Opus 5.5" Subject: [PATCH 5.10 358/516] ASoC: samsung: i2s: enable op_clk in probe to balance runtime PM Date: Wed, 28 Oct 2026 17:58:30 +0100 Message-ID: <20261028170011.967619560@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170003.522232767@linuxfoundation.org> References: <20261028170003.522232767@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Marek Szyprowski [ Upstream commit 7529254014764ae0b8c33d5c61a58f36c65b1a1c ] The probe function puts the device into the runtime PM active state with only the "iis" bus clock enabled, but it also sets priv->op_clk to the parent of the RCLK_SRC mux without enabling it. The runtime PM suspend callback disables both clocks, so the first runtime suspend after probe disables op_clk once more than it was enabled. On Exynos5250 Arndale both clocks resolve to the same EXYNOS_I2S_BUS gate, so this triggers the following warning during boot: WARNING: drivers/clk/clk.c:1270 at clk_core_disable+0xe4/0x23c, CPU#0: kworker/u8:3/45 i2s_bus already disabled ... Workqueue: pm pm_runtime_work Call trace: ... clk_core_disable from clk_disable+0x28/0x34 clk_disable from i2s_runtime_suspend+0x58/0x68 [snd_soc_i2s] i2s_runtime_suspend [snd_soc_i2s] from genpd_runtime_suspend+0xc4/0x298 genpd_runtime_suspend from __rpm_callback+0x48/0x18c __rpm_callback from rpm_callback+0x4c/0x50 rpm_callback from rpm_suspend+0xf4/0x718 rpm_suspend from pm_runtime_work+0x9c/0xa0 ... Fix this by enabling op_clk in probe right after getting it, so the clock state matches the runtime PM active state, and by disabling it in remove. Fixes: 48279c53fd1d ("ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access") Assisted-by: Claude Opus 5.5 Signed-off-by: Marek Szyprowski Link: https://patch.msgid.link/20261002092116.585466-1-m.szyprowski@samsung.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/samsung/i2s.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index df53d4ea808fe..68898e30fe198 100644 --- a/sound/soc/samsung/i2s.c +++ b/sound/soc/samsung/i2s.c @@ -1528,9 +1528,16 @@ static int samsung_i2s_probe(struct platform_device *pdev) goto err_disable_pm; priv->op_clk = clk_get_parent(priv->clk_table[CLK_I2S_RCLK_SRC]); + ret = clk_prepare_enable(priv->op_clk); + if (ret < 0) { + priv->op_clk = NULL; + goto err_unregister_clk; + } return 0; +err_unregister_clk: + i2s_unregister_clock_provider(priv); err_disable_pm: pm_runtime_disable(&pdev->dev); err_del_sec: @@ -1553,6 +1560,7 @@ static int samsung_i2s_remove(struct platform_device *pdev) i2s_unregister_clock_provider(priv); i2s_delete_secondary_device(priv); + clk_disable_unprepare(priv->op_clk); clk_disable_unprepare(priv->clk); pm_runtime_put_noidle(&pdev->dev); -- 2.53.0