From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793209367; b=YVSry0CQP8hruJ6BDnF9C1h0gmEaeIJr/6Ua0pG5tat22STramc2kgQ3GM7tbyYNMQ/O 4Y1iDBUlkAYjV7QAwUYdWD1niYgFra+QCjy2B8D2eGUZHQsWtjnCr1gReFDDsn+21wPbu Jt8oseTCUnG3S8Cy+0zIdxN6NQcDqcB5dl7Cz93FJDJ3Xg7OIPlHcygVDRZzppUnjDFul VpZ0gVdo+y94lAQYibvR7DaW/c/RtPCrBD4Hf1CoqeBl52JJme8TNaEiIGMKv1wry+2b9 ev/6/8mrPzzYXdVIEawZP8PCtADFembqSBE4IGT+ErcMvYZRxK+8wvaRis032neyRqQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793209367; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=cxMdapTVbyF7ODDTVncyRysWqrdWdEji9VSwNncEpB0=; b=vZdttML64/UBzaj/jKYgiTyyYXs5K3bGjGL/YFrApZHZyFg3ALG9AVSj8pUjWk8SvH1x DYYuxHdwcJpZVMyTj6ZMrL3UF2swX/CPZ3H/eJ6W262tiTvlUd1oO7cSHDn59fbOJlA5H wPfb6IikcXdlNsLuerRgrkYqrlPtstnet7enqP3lBMFDfs3LT172o0zjeDndga21HUdEB dZKZWQf5rfm57EJsQ5GS6RPmeIprx1EOV7i7mxQSgAuSOE2Oi7OJ2jzHE0pBeFbvTcoB6 y950js3fkbYpU+dw8/UkWLtCGcSTKwvs23yaXcZDyyTo/Mr4Cyll30WLDYeVZ6SbLHg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=RB549wiv; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4CD8606A31A; Wed, 28 Oct 2026 17:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=RB549wiv Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13DE91F01825; Wed, 28 Oct 2026 17:42:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793209366; bh=cxMdapTVbyF7ODDTVncyRysWqrdWdEji9VSwNncEpB0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RB549wivCQISTK5wkCNsEeF6rKDewJrVQOzDze0YBff6tS9bjfhBBYk071CshqRAd YvdpndzJxZ8dHMK6A6tavxSz1z9yKJEGJO4md0attEeg4CmHu6uwCbcRnOZZPTd9C7 ELT2wQ/XC39qoyIPapjdyT3Aq9pbdhr207ljttGA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kyle Zeng , "Christian Brauner (Amutable)" , Sasha Levin Subject: [PATCH 5.10 446/516] pipe: preserve existing fasync readers on writer setup failure Date: Wed, 28 Oct 2026 17:59:58 +0100 Message-ID: <20261028170014.047281488@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170003.522232767@linuxfoundation.org> References: <20261028170003.522232767@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kyle Zeng [ Upstream commit 40bb03d3ea6f6a915218508819ecc4d7a7fa260d ] F_SETFL and FIOASYNC decide whether to invoke ->fasync() before pipe_fasync() takes pipe->mutex. Two enables of one O_RDWR FIFO can therefore both enter the callback. fasync_helper() allocates before checking for an existing entry. If the first enable installs both entries, a second enable can update the reader entry and then fail the allocation for the writer entry. The error path removes the pre-existing reader entry, clearing FASYNC while the writer entry remains registered. __fput() then skips ->fasync(), so a later pipe notification can dereference the freed file or its f_owner. An unprivileged memory-pressure reproducer triggers a KASAN slab-use-after-free in send_sigio() through this path. Keep the reader helper's result and undo the registration only if this call added it. The pipe mutex serializes changes to both lists, so a failed new registration still removes its reader, while a failed duplicate preserves the existing registrations and FASYNC. Successful duplicate enables continue to update fa_fd as before. Fixes: 76398425bb06 ("Move FASYNC bit handling to f_op->fasync()") Signed-off-by: Kyle Zeng Signed-off-by: Christian Brauner (Amutable) Signed-off-by: Sasha Levin --- fs/pipe.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/pipe.c b/fs/pipe.c index 588fe37d8d955..2a3d673fe3d63 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -742,9 +742,11 @@ pipe_fasync(int fd, struct file *filp, int on) if (filp->f_mode & FMODE_READ) retval = fasync_helper(fd, filp, on, &pipe->fasync_readers); if ((filp->f_mode & FMODE_WRITE) && retval >= 0) { + int read_ret = retval; + retval = fasync_helper(fd, filp, on, &pipe->fasync_writers); - if (retval < 0 && (filp->f_mode & FMODE_READ)) - /* this can happen only if on == T */ + /* Undo only a reader entry added by this call. */ + if (retval < 0 && read_ret > 0) fasync_helper(-1, filp, 0, &pipe->fasync_readers); } __pipe_unlock(pipe); -- 2.53.0