From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793209549; b=dHxnHOgVTLAJn+8vJGtIf4qBBVGENqnwvM3duEGwZT1C65pGGJCFhPNPAtwM13H42cxi TifhIxSSn81HY68tGym+MyJbK/G1yNy67fTSiHIjwztf5iTTm/yKYd7bWf0wcJWSJtstB l5gyL89IgmxxCHs+XLd/REGJSQWoZPaQqZ6DClkBdPOmxNu1s2BM1Apf0nzzqO2Z1SALg fDYSjz/ulhFBye8HbzB+JS9fFl0a0nR0KWjLETeS2m589coWXYaPuft8KhLoWwQ2+3tLz px9X8XnkFci0Y9fZOPh7B8j+e6zdEkXcxCb3FZQJ4jG6fD6QEO70a0sAZOC7OGcfjqw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793209549; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=8XOPz8/Qd6xBUBbpqUWysAZAgGXx6yBcQAJhbGXr5Eo=; b=jkDfdFHGoCbyqlHzjxbVP1dOnWCqEaXvtE49xcs1Wkr1gSBvsIb9FJBshXD92AxSmBPQ k3fCaYgwjIkbfeQeq/4v5IajnNgltzzQVCC/Nu+/a6baG11RWpNppgybBWh/mdLP+GmTz LS6wsQZ82DiNzMlI9jdtT1aIObc6Qb7jCvppSnmltpDT6wuY+p6tPDxZWyI9GIyEqLW+W j7X/B2FV+hLA+0xOlXYrZRzswSvPRK52M+xC6FkOaj+0UNFw8PEGeGJN2noeGybE5ITZB FvfMPEYj0rjnRHyIKjhQK4eDTZZzIdOdpXGktAsTx8fM/X4MkYcMtPfSeRzrfr3Pd9g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=nTi3gEu5; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A96F3606A31C; Wed, 28 Oct 2026 17:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=nTi3gEu5 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 065941F01825; Wed, 28 Oct 2026 17:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793209548; bh=8XOPz8/Qd6xBUBbpqUWysAZAgGXx6yBcQAJhbGXr5Eo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nTi3gEu5ZchDMO8fuXYomjBn0poezeCXuTSN/B4pClayzW3FL8Jy7HitPT/aNYzo+ GJ7JQklR7aExZs3FbiqY5yObn37KcEYXnzltvdJLgEdF6ksz/sx5r3aFLHTHTMUbgv OibitWZUpa3eZpRWSuYOodXMPj0rDvn8ATsEOd1g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot@kernel.org, Donggeun Yoo , Steven Rostedt Subject: [PATCH 5.10 508/516] tracing: Unregister field variable histograms when the command fails Date: Wed, 28 Oct 2026 18:01:00 +0100 Message-ID: <20261028170015.511078490@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170003.522232767@linuxfoundation.org> References: <20261028170003.522232767@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Donggeun Yoo commit 91c14d6c13096091c56304120aaa26e479130b8b upstream. An action that names a field on another event needs that field as a variable, so create_field_var_hist() registers a second hist trigger on that event to provide it, and records it in target_hist_data->field_var_hists[]. If a later part of the same command fails, create_actions() returns an error and event_hist_trigger_parse() jumps to out_free. The write fails with -EINVAL and sched_switch gets no trigger, but: # echo 'hist:keys=pid:ts0=common_timestamp.usecs' >> \ events/sched/sched_waking/trigger # echo 'my_synth u64 lat; int a; int b' >> synthetic_events # echo 'hist:keys=next_pid:wakeup_lat=common_timestamp.usecs-$ts0:\ onmatch(sched.sched_waking).my_synth($wakeup_lat,prio,nosuchfld)'\ >> events/sched/sched_switch/trigger # cat events/sched/sched_waking/trigger hist:keys=pid:vals=hitcount:ts0=common_timestamp.usecs:sort=hitcount:size=2048:clock=global [active] hist:keys=pid:vals=hitcount:synthetic_prio=prio:sort=hitcount:size=2048 [active] The second histogram is the one created for 'prio'. It is still active and still counting. out_free reaches destroy_field_var_hists(), which frees the field_var_hists[] entries, but never unregister_field_var_hists(), which is what removes the triggers and runs only from event_hist_trigger_free(). The entry is freed and the trigger is left with nothing tracking it. Unregister the field variable histograms in out_free as well, and record each one as soon as its trigger is registered rather than after the lookup that follows it, so no exit can leave a registered trigger untracked. The entry then belongs to field_var_hists[] and is released by destroy_field_var_hists(), so freeing it on that exit would be a double free. Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260914104036.1768529-1-donggeunyoo.kernel@gmail.com Fixes: 02205a6752f2 ("tracing: Add support for 'field variables'") Reported-by: sashiko-bot@kernel.org Closes: https://lore.kernel.org/all/20260913204302.DB2551F000FF@smtp.kernel.org/ Signed-off-by: Donggeun Yoo Assisted-by: Claude:claude-fable-5 Signed-off-by: Steven Rostedt Signed-off-by: Greg Kroah-Hartman --- kernel/trace/trace_events_hist.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -2568,20 +2568,18 @@ create_field_var_hist(struct hist_trigge kfree(cmd); + n = target_hist_data->n_field_var_hists; + target_hist_data->field_var_hists[n] = var_hist; + target_hist_data->n_field_var_hists++; + /* If we can't find the variable, something went wrong */ event_var = find_synthetic_field_var(target_hist_data, subsys_name, event_name, field_name); if (IS_ERR_OR_NULL(event_var)) { - kfree(var_hist->cmd); - kfree(var_hist); hist_err(tr, HIST_ERR_SYNTH_VAR_NOT_FOUND, errpos(field_name)); return ERR_PTR(-EINVAL); } - n = target_hist_data->n_field_var_hists; - target_hist_data->field_var_hists[n] = var_hist; - target_hist_data->n_field_var_hists++; - return event_var; } @@ -5865,6 +5863,8 @@ enable: kfree(trigger_data); + unregister_field_var_hists(hist_data); + destroy_hist_data(hist_data); goto out; }