From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793211598; b=RyGdAopAtJhGQUSiecQelCGsn9ESRDiw891B/OBcVgJLBUjXsmRJCILHaC8JJ/rNCemS 9a1yYaWLgi3+S/t2W/zZFH7bhm6vpeAh8cnV6UwmAaKonCOtGJJycY3R7IF/cSiGxxgKD OnqAGLmO3/Q34XVPqOv5pt32pfDKgY0luOvICA/hyabT7p2noGNwsx+qi8UeE6wcYJgWJ 2N3m4Mnzj2eYLMvkQz8NSO9TdP0Rk8FBphXqbemGVAOYh2FJMNNWGG9aM3PPEoSsr868t CrodBk98dpF2xKNja3uwQdUEKucgcXJgqXr3Dns+I4onWkcfGtlSZay3wIhG0CkwA7g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793211598; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Transfer-Encoding; bh=WOz0SJ80SY6pPZ+knZB6LTNE3t3Qd0ZCXY4IoNrQXoY=; b=4qW+H3JHE9HZweLc7vMX3n1duycHeM4SAYq26+WIrtfLN4gNYlaV3+ijQB4EvearlpCP 4Lt9XtQ0ML6CjR3FrQ2RBztzhLZ1DmQ9oHkam0F7dPsCLoInP7uL9SjgeDos9AlIcZPmu 7mJ4IrJS7Ar8qDYxCwZsPZXA+scUtzhNLUsTe8MShe0CcZmXWccaHdDqk0BmszMBPD58m fa2/hxrD4vUncAe5Lb7ayYjzbSomiYAwIPUI+dzibjjBstzZ7MlIVj8Uafhq4OY3YNYve i9LWdccg91AiSQPjYl8BO4Tcp47FF/7sqztKfu2dvfU/7bggIn563XItpK6TBKN4lIA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=W2waaOLG; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71E2B606A31D; Wed, 28 Oct 2026 18:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=W2waaOLG Received: by smtp.kernel.org (Postfix) with ESMTPSA id C36C21F01825; Wed, 28 Oct 2026 18:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793211598; bh=WOz0SJ80SY6pPZ+knZB6LTNE3t3Qd0ZCXY4IoNrQXoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=W2waaOLGHSrbETScRdryqy9EJNnLDLNjHnGSqEPEntbCJ9ChoWp33wM5REvhmKh48 vemtSh6yOjqtxHBJ1oFMYGgYL5C9kW9bEwcybmPiMUBPMWAZHDCeD1hErAtudod1vY 0T5y46+LAE9/cxlTXoZElaBi/TyRtImWsK3qjh/s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, co+2cf741c3005abc20@bugs.sh, Weiming Shi , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 434/571] net: team: stop reusing skb after queue override Date: Wed, 28 Oct 2026 17:59:41 +0100 Message-ID: <20261028170018.317783789@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170008.009143722@linuxfoundation.org> References: <20261028170008.009143722@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Weiming Shi [ Upstream commit b7454f1940c5e6d92e753853c476a769e452f30a ] A nonzero dev_queue_xmit() result does not return ownership of the skb. When an override port's qdisc drops it, the queue override helper used to try another port or the mode transmit op with the freed skb. Return the handoff decision separately from transmit success. Select only the first override port under RCU and stop after handing it the skb, regardless of the lower transmit result. Keep the existing success and drop accounting. BUG: KASAN: slab-use-after-free in sk_skb_reason_drop Write of size 4 by task poc/5040 sk_skb_reason_drop (net/core/skbuff.c:1240) dev_kfree_skb_any_reason (net/core/dev.c:3470) ab_transmit (drivers/net/team/team_mode_activebackup.c:49) team_xmit (drivers/net/team/team_core.c:1849) __dev_direct_xmit (net/core/dev.c:4934) Freed by task 5040: __tcf_kfree_skb_list (net/sched/sch_generic.c:43) __dev_queue_xmit (net/core/dev.c:4831) team_xmit (drivers/net/team/team_core.c:1846) Kernel panic - not syncing: KASAN: panic_on_warn set ... Cc: stable@vger.kernel.org Fixes: 8ff5105a2b9d ("team: add support for queue override by setting queue_id for port") Reported-by: Signed-off-by: Weiming Shi Link: https://patch.msgid.link/20261001182326.572045-2-bestswngs@gmail.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/team/team.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c index 367ef5dd6205a..8c9b56c40f702 100644 --- a/drivers/net/team/team.c +++ b/drivers/net/team/team.c @@ -817,7 +817,8 @@ static struct list_head *__team_get_qom_list(struct team *team, u16 queue_id) /* * note: already called with rcu_read_lock */ -static bool team_queue_override_transmit(struct team *team, struct sk_buff *skb) +static bool team_queue_override_transmit(struct team *team, struct sk_buff *skb, + bool *tx_success) { struct list_head *qom_list; struct team_port *port; @@ -825,11 +826,11 @@ static bool team_queue_override_transmit(struct team *team, struct sk_buff *skb) if (!team->queue_override_enabled || !skb->queue_mapping) return false; qom_list = __team_get_qom_list(team, skb->queue_mapping); - list_for_each_entry_rcu(port, qom_list, qom_list) { - if (!team_dev_queue_xmit(team, port, skb)) - return true; - } - return false; + port = list_first_or_null_rcu(qom_list, struct team_port, qom_list); + if (!port) + return false; + *tx_success = !team_dev_queue_xmit(team, port, skb); + return true; } static void __team_queue_override_port_del(struct team *team, @@ -1754,8 +1755,7 @@ static netdev_tx_t team_xmit(struct sk_buff *skb, struct net_device *dev) bool tx_success; unsigned int len = skb->len; - tx_success = team_queue_override_transmit(team, skb); - if (!tx_success) + if (!team_queue_override_transmit(team, skb, &tx_success)) tx_success = READ_ONCE(team->ops.transmit)(team, skb); if (tx_success) { struct team_pcpu_stats *pcpu_stats; -- 2.53.0