From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793214097; b=M1tjD2mq0Uz2AsFSliQrioHmBJsemwsWDhv3xm9ubW6yIEjuDQSsCRjRR4iBndzCCVfL nlVhkyA0swJ9yGf8TIxFW4N33mSUD1UENiWjFxAzZ0WRwJuGjqV8IEFBORB81wyBxJB8w ZfkcAkYS47A/pc1h8P/AeqxMLDUD4CTai4NK9qgyo9QeOkoqxxv4w2rho4FG8U5128Sk2 uosgJBgvVuExNkyuNPGBhGgAroPX1yxeNRLUWutFTry76hN6jTRta+j00WdmXHdeeSKuc YrhOatDDIzCe8ZFI74a+uV/5F+sSZbp856qTXIw2P3Uy8R4CyHYVln3aHEi4rxOcMFw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793214097; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:User-Agent:X-stable:X-Patchwork-Hint: MIME-Version:Content-Type:Content-Transfer-Encoding; bh=5m7Ti3QPkPlUSJ9Km0dAazQe2KN3OUSG/b2ww+5ZVO0=; b=vNVoj26Hkrf7RYIDAagWUuSCXdJBVDa+F0XSatZpqj1K7Qsv7GIDyll4vjKelTzXWSj2 dTKO8Za0QK/LQHbuejh8m63nsdi6l5ELILSjji903FyXgjaFo1qG6oo+xdxwBVciKLiZU OzqsxU/LD+99z0I0Xg8lgcZ8RY0poMWIN/1hZlVGQ/ly2QjS4Bh/pg5So6HZHqK6ye0da 1+Ddsqyj1BurMNFf1om5kYW/XdOYGcq8+7MJOH7CZ6Q3h+XbD75RfeKAQ9teg5CBn2s2q XrP1vsl+Wklx1NooGVoqT2s5pbmgFt0rBDXuf7ntQT9Hx0WyIAVLDgGzapJv6CuC4Ow== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=S3qEQL0b; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4288606A31A; Wed, 28 Oct 2026 19:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=S3qEQL0b Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9F6E1F01825; Wed, 28 Oct 2026 19:01:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1793214096; bh=5m7Ti3QPkPlUSJ9Km0dAazQe2KN3OUSG/b2ww+5ZVO0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=S3qEQL0btVnsrDMhALMTcyO8+vQcE6Ume6QEHcoCibsyQKV3X2M1X31Rq1Pg2/tPz rrxpDZHh5JiegH52Dy7oN/hGYmDicQckJe9bs20ElNhVFrcnjxhXKj42NXd/AwDWwt +rvyyyBYkOCcrDo3YXx1MB5FWPwKI6joKISRgbfc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Claudiu Beznea , Kory Maincent , =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Paolo Abeni , Sasha Levin Subject: [PATCH 6.1 0738/1887] net: ravb: Fix missing rtnl lock in suspend/resume path Date: Wed, 28 Oct 2026 17:47:14 +0100 Message-ID: <20261028170516.241189706@linuxfoundation.org> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028170459.200466217@linuxfoundation.org> References: <20261028170459.200466217@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore X-Mailing-List: patches@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kory Maincent [ Upstream commit 2c2ebb2b49573e5f8726112ad06b1dffc3c9ea03 ] Fix the suspend/resume path by ensuring the rtnl lock is held where required. Calls to ravb_open, ravb_close and wol operations must be performed under the rtnl lock to prevent conflicts with ongoing ndo operations. Without this fix, the following warning is triggered: [ 39.032969] ============================= [ 39.032983] WARNING: suspicious RCU usage [ 39.033019] ----------------------------- [ 39.033033] drivers/net/phy/phy_device.c:2004 suspicious rcu_dereference_protected() usage! ... [ 39.033597] stack backtrace: [ 39.033613] CPU: 0 UID: 0 PID: 174 Comm: python3 Not tainted 6.13.0-rc7-next-20250116-arm64-renesas-00002-g35245dfdc62c #7 [ 39.033623] Hardware name: Renesas SMARC EVK version 2 based on r9a08g045s33 (DT) [ 39.033628] Call trace: [ 39.033633] show_stack+0x14/0x1c (C) [ 39.033652] dump_stack_lvl+0xb4/0xc4 [ 39.033664] dump_stack+0x14/0x1c [ 39.033671] lockdep_rcu_suspicious+0x16c/0x22c [ 39.033682] phy_detach+0x160/0x190 [ 39.033694] phy_disconnect+0x40/0x54 [ 39.033703] ravb_close+0x6c/0x1cc [ 39.033714] ravb_suspend+0x48/0x120 [ 39.033721] dpm_run_callback+0x4c/0x14c [ 39.033731] device_suspend+0x11c/0x4dc [ 39.033740] dpm_suspend+0xdc/0x214 [ 39.033748] dpm_suspend_start+0x48/0x60 [ 39.033758] suspend_devices_and_enter+0x124/0x574 [ 39.033769] pm_suspend+0x1ac/0x274 [ 39.033778] state_store+0x88/0x124 [ 39.033788] kobj_attr_store+0x14/0x24 [ 39.033798] sysfs_kf_write+0x48/0x6c [ 39.033808] kernfs_fop_write_iter+0x118/0x1a8 [ 39.033817] vfs_write+0x27c/0x378 [ 39.033825] ksys_write+0x64/0xf4 [ 39.033833] __arm64_sys_write+0x18/0x20 [ 39.033841] invoke_syscall+0x44/0x104 [ 39.033852] el0_svc_common.constprop.0+0xb4/0xd4 [ 39.033862] do_el0_svc+0x18/0x20 [ 39.033870] el0_svc+0x3c/0xf0 [ 39.033880] el0t_64_sync_handler+0xc0/0xc4 [ 39.033888] el0t_64_sync+0x154/0x158 [ 39.041274] ravb 11c30000.ethernet eth0: Link is Down Reported-by: Claudiu Beznea Closes: https://lore.kernel.org/netdev/4c6419d8-c06b-495c-b987-d66c2e1ff848@tuxon.dev/ Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support") Signed-off-by: Kory Maincent Tested-by: Niklas Söderlund Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/renesas/ravb_main.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c index dcacd691b2efd..40b82f00e6e55 100644 --- a/drivers/net/ethernet/renesas/ravb_main.c +++ b/drivers/net/ethernet/renesas/ravb_main.c @@ -3028,10 +3028,12 @@ static int __maybe_unused ravb_suspend(struct device *dev) netif_device_detach(ndev); + rtnl_lock(); if (priv->wol_enabled) ret = ravb_wol_setup(ndev); else ret = ravb_close(ndev); + rtnl_unlock(); if (priv->info->ccc_gac) ravb_ptp_stop(ndev); @@ -3083,12 +3085,16 @@ static int __maybe_unused ravb_resume(struct device *dev) ravb_ptp_init(ndev, priv->pdev); if (netif_running(ndev)) { + rtnl_lock(); if (priv->wol_enabled) { ret = ravb_wol_restore(ndev); - if (ret) + if (ret) { + rtnl_unlock(); return ret; + } } ret = ravb_open(ndev); + rtnl_unlock(); if (ret < 0) return ret; ravb_set_rx_mode(ndev); -- 2.53.0