From: Simon Horman <horms@kernel.org>
To: Nicolai Buchwitz <nb@tipi-net.de>
Cc: Doug Berger <opendmb@gmail.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Justin Chen <justin.chen@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3 2/2] net: bcmgenet: restore the Tx coalescing setting when the rings are rebuilt
Date: Wed, 28 Oct 2026 17:23:32 +0000 [thread overview]
Message-ID: <20261028172332.GC257209@horms.kernel.org> (raw)
In-Reply-To: <20261022-nb-genet-fini-dma-net-v3-2-6e9fc89c0156@tipi-net.de>
On Thu, Oct 22, 2026 at 10:54:07AM +0200, Nicolai Buchwitz wrote:
> bcmgenet_set_coalesce() writes tx_max_coalesced_frames straight into
> DMA_MBUF_DONE_THRESH and keeps no copy of it, while
> bcmgenet_init_tx_ring() programs a fixed 1. An ifdown and ifup or a resume
> then puts the Tx coalescing back to one frame per interrupt.
>
> Rx keeps its value per ring and reapplies it on init. Do the same for Tx.
>
> Fixes: 2f9130709d2c ("net: bcmgenet: Implement TX coalescing control knobs")
> Signed-off-by: Nicolai Buchwitz <nb@tipi-net.de>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-10-28 17:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 8:54 [PATCH net v3 0/2] net: bcmgenet: fixes for a failed resume and the ring rebuild Nicolai Buchwitz
2026-10-22 8:54 ` [PATCH net v3 1/2] net: bcmgenet: recover from a failed resume Nicolai Buchwitz
2026-10-23 11:55 ` netdev-bot+sashiko
2026-10-23 12:04 ` Nicolai Buchwitz
2026-10-28 17:23 ` Simon Horman
2026-10-22 8:54 ` [PATCH net v3 2/2] net: bcmgenet: restore the Tx coalescing setting when the rings are rebuilt Nicolai Buchwitz
2026-10-28 17:23 ` Simon Horman [this message]
2026-10-28 17:25 ` Florian Fainelli
2026-10-26 23:36 ` [PATCH net v3 0/2] net: bcmgenet: fixes for a failed resume and the ring rebuild Jakub Kicinski
2026-10-27 22:53 ` Florian Fainelli
2026-10-28 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028172332.GC257209@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nb@tipi-net.de \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.