From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.44 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793208682; b=Meq1CQNkgtVhX1GIE7eTCMA/44FMqILGeZ6/KnUXO7XTCEhVcSGQC5eHvGnC9Tu2epCY U60b+H88PCe16ePZXayIrcg3A6NRPce//Az1H6vy+1CkXQi0nHSDNRdVLiBffMFHNOUTh K2kmYQftses6isopui+ma0kr1yU2P5t4Wpu2mvTFzSFQ2wuwHGGw6UIaxTSZ9iOEYFKIO 2YGVQDjkRfEiXdj4FkuTPZl2h0s67BVe5kqRHU8P25f9iG4FbakDp6sAwMC5aKQh/kHJL 8+c69hfLl/S9sZ/lHNWEduFAjedC9QNNigM3X3vQ/JCKwt0tvXVyju3/CbT/9g4Lzfg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793208682; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=tTbN8QdJzbNFg7HFB2EoFWXNNo+FJ0ZvprR3p/0DA4Q=; b=GBoLG1AIG1M8pKSFe+r4XEQ+8zIVXBviQPWQEyND+bERi/J4HZoAz6LRUJ1bkwG2zeFw GaDFHvvf68PkDJkC79iJQWpEdb66Twcyjj5UUGx8MNy0A+xZtWOdu1RC328QENfu4aC9/ I22DqEoZcAM1j7TNQjl/s95InpycJeaRjs97u5rlJ7AldhlAvqam0K0TurwKqe5Zuvb55 16iU/3WoY+5SiR8N9U7F6hkmv/tOxFV47cxfD+d5t02DrNLwZghNtaqtJSS2W06T9hgsz XQLxl2Xsko9eNzJukglSUaibLf4+z8OnJ2CV6pmsw451U41J/wg3QcM3Wl8I5qPEeQw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Rj5AXwlI; arc=none smtp.remote-ip=209.85.128.44 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85F02606A325 for ; Wed, 28 Oct 2026 17:31:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 85F02606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=Rj5AXwlI Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4a9a8d6cea8so11568785e9.1 for ; Wed, 28 Oct 2026 10:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793208681; x=1793813481; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tTbN8QdJzbNFg7HFB2EoFWXNNo+FJ0ZvprR3p/0DA4Q=; b=Rj5AXwlIRL1sM/sCWx/9TgqY1uZioctwcdwe23Su+an66Dqioq2hXH34IGZMtMjlNZ c6HbI5Xmhd+ZP7Hx+cWqoi3dAjlmxXVC7112rgscq4+HMiIJfKSx/VQEKYCCOUBqlwGC jHFBJeolrICukui6tBM3wuMTuKAcFUABKr41L84uYmWOSobC1okBV45oSHMP3bsdJSiB TZtr3QzQC9aLP5v8PgFq/XoD662rug3mQtnh2w0Tpn0ADA2Ad3eFdht2hOUY/8mDvavl yuGhdRax/mp5lm6KtXyqMkEsnAWnfZWLE84MspzN2kgfK0YIDikLfZwBTP6ZxuSfqdmV fYSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793208681; x=1793813481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tTbN8QdJzbNFg7HFB2EoFWXNNo+FJ0ZvprR3p/0DA4Q=; b=c+WaG4hO8uJY6WneQwvdjsryCWuhZ8mpzfYFuPAA/h2D+PaCHkdBr9VCK0Eu08hr6P ly7CbSyKJQUp5mZVgF017MNX+0iU6crA+T4ExJ6SfHVclH1bShR2nsJtP9cH0b2soYb+ w6xo0gv4sDDaGv9jVeDiRfFsTC+vlyXmZPoRCp0F0qfTbdMQ37xn/ytpIdT8RdOU9sI4 Vu3AB7LCJMGs/2IeylYb2gN6g8X7iSJS934tRAgtE3Icz/o7zzimCdPKWdTd19FGuDGU iyToGoEkX79wS8gM9xTj8ss5M2Q8Hm8WE6po/uWstkrtaunVQq/9YCyCT6UtrT0d1e6z dlvg== X-Forwarded-Encrypted: i=1; AKwUvBzEtvWwFdm8ZlrZj/sO+o+M7Cq6AaHMTo+51EmWdrm/hfAQJWDSp6mMWaXvE40cmqCAmJvsYflMEH8=@vger.kernel.org X-Gm-Message-State: AFq9FYJbImkoQkl6+8KHCgeNcjtKF7Sl+YIcgisMlz8QIetBykvvGsqT cWkTqVjg/qU7fwzJDIQoPnNwG3qk3AVzJJEasxFGTfmxy4gQiDL8qDm1 X-Gm-Gg: AYBFou1kmriw3jm24hNYhV/f7iRBYQIZ+YDgXzJA0mHuBsz8k6y5GLn8cwO0Nzli8/D D7k4XLcce9JKvCyfEiJyKU4F27OWdTQDhbp/lEY1einQpkL/xeSsn5Q7cqNNvhCLABu9GG88oPF phBZ+dxzWmGRCxUDFk8wQVj8ytN0rdrJXpgq6T8KndbcC4D0TgwdzZd4H2fwiLVRMidtv5MJi+8 c5glzTNk8nxNKajgNjq6XonyoaI0HUQiFFwNwd9EWo2Cy7UAeDPRrgdvqenZ1pAtKasoPHHIKdN qoxrfAqjaeSMs3WIo8sNrQyO4zwBPte9pwaSr0SphmQ7pu64fCYypxYpeDQRKC8bixltqySLUNX hXvmNPK51QbPZJVqAOS1f1vjduxH7OthRK1QUYdDQX4MqdpIhk0WREQyHaQkKKPR/HjqgOWxUZe eEh+A7yar2x5VuyInUry9Q9n0Wt5Yit01ApJ4Snks1LHYhSz6DXo3afr9X3y6bjUp1c+iK1e/rC Ter1IBs3ZUJ+5VA2WXaTP8pNt50CyvW6y//gvC1fGCLFVv8wWv82grmiRy/Xjq8uHG2+B4JUdqN og++dEyPLYpJcWCBu4ImY41SAPO8W0uRaaK7Deys5JPpllC6oGh1BZz/lomGkzFpGrjRcueTbMl uim7IA9jcW7Tf6zQHoFq3ukyFbYd04i75f67pxTkt0AVsmA== X-Received: by 2002:a05:600c:1546:b0:49e:6581:7baf with SMTP id 5b1f17b1804b1-4aa86a42518mr6057825e9.2.1793208680690; Wed, 28 Oct 2026 10:31:20 -0700 (PDT) Received: from tachyon.internal (2.155.41.158.dyn.user.ono.com. [2.155.41.158]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4aa80285b2dsm6496175e9.13.2026.10.28.10.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:31:19 -0700 (PDT) From: =?UTF-8?q?Enrique=20Hern=C3=A1ndez=20Bello?= To: iav@iav.lv Cc: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, robh@kernel.org, heiko@sntech.de, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 0/2] PCI: rockchip-host: Retry training and hot-reset a JMB585 on RK3399 Date: Wed, 28 Oct 2026 17:31:17 +0000 Message-ID: <20261028173117.3457220-1-ehbello@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: References: <20261024-rockchip-pcie-resume-v1-0-58e54a5cf5f1@iav.lv> <4316c1da-f7ff-4fa5-a330-512800474e45@rock-chips.com> <20261026-rockchip-pcie-shawn-reply-1@iav.lv> X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit You said both SErrors and synchronous external aborts occur. In my logs which of the two you get tracks the cluster the access runs on, which might be worth a look before you move the hook. Every asynchronous SError in rockchip_pcie_rd_conf landed on CPU4 or CPU5, the A72s, across six boots on two different kernels. The one time the same read aborted synchronously it was on CPU3, an A53. They also carry different ISS: 0xbf000002 for these config-read aborts, against 0xbf000000 for the unrelated runtime SErrors on this board. That is one synchronous case, so not a law, but it is cheap for you to test: pin enumeration to an A53 and see whether your aborts all become synchronous. It matters because only the synchronous form can be repaired. When it arrives as an SError the load has retired and there is no destination register left to write all-ones into, so no fixup can help. I prototyped the synchronous half in September: an exception-table entry consulted from do_sea(), with the driver substituting the all-ones the PCI core expects rather than only surviving. arm32 has had that for years -- imx6q_pcie_abort_handler() in dwc/pci-imx6.c decodes the faulting instruction and makes a read look like all-ones, under #ifdef CONFIG_ARM -- and arm64 has no equivalent path. It only ever worked for me with enumeration pinned to an A53, which is what made me look at the cluster in the first place. Not proposing anything, and not reviving that prototype. Yours if any of it is useful. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1547A606A31F for ; Wed, 28 Oct 2026 17:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=TeCJBPIN; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=wrRuukdP DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=xr7ZzbKi3Yqyp3yT/qReZ2d1lmjzqgOXS2kFbsuIlcA=; b=TeCJBPINt+yvIgmb8kshA4hyoa yi5HY7D+DzTjy7Rlki7Dr5acVD8/p2N6XxvIXsjWHt07Oxha5bInevrQV23a+o6ZS59hSTBJ5EDaG q0+8iQYEEQDCRbwM6KqS9xj8dGMzXK0wZPN322K1mA2LIwEofMWbQ81ajlfRKhNWPq9Z9Ub4ICLoq m/mnPL/TWPeDyO0+aPbnwa45FY2XW6hZKTFn09jRZ72lSvvJL4KkTsiGe02Y0mjMV3/l3KAwctbBL OJm8mZ/sesQ+uz3PdmKtnILKWlp0XI0MmXROQ3W++nbIqeJ730dc+HrjS/G4X12dgH27obONQ//ic +WrQawLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM7Us-00000007fSL-1zed; Wed, 28 Oct 2026 17:31:34 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xM7Uh-00000007fJS-1Nor for linux-rockchip@lists.infradead.org; Wed, 28 Oct 2026 17:31:24 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-4a549cd7fd2so12057185e9.0 for ; Wed, 28 Oct 2026 10:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793208681; x=1793813481; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tTbN8QdJzbNFg7HFB2EoFWXNNo+FJ0ZvprR3p/0DA4Q=; b=wrRuukdPOHhZ9ETo4kDnDH+fIvT6FpVWIiuZSs11rixaLuavFnjwC6Akx5ypLcT51N Og0j6BgBIvpglWU3x/cqBWMjUFLK9fUHFNe+NqgeY3a4EGLbCWwqm3j6RRvXY9TNg0CK uF7NH0Ri+imaKMDC/Xy1sm0rkCdI2Vjf1uC44Oz63JcN3ML7Wsg794uBG+EkZ2E6HuQX 1ZkBrqJ/7LMDTNJRChoigpKwfUCuIwpCIXr6L4Zp+ccphIBmYw6ntq+kHqg1H4ribmdI hHAgpVAWgA9AZLBa8ozk7q+lEwRm55CPj1FVBJTFs4poHPVsbps8SPDgN6P2GjRPrIy1 vBRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793208681; x=1793813481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tTbN8QdJzbNFg7HFB2EoFWXNNo+FJ0ZvprR3p/0DA4Q=; b=roDY0Ua4QrpM1AyPVfIH2B3Cx5qsCs9RU8d70/D0KMJ+S/TbJ4fOIF0iGKRMeYx7pq 05MtdXSBPrwmc3SXoMf0oRKCtgY8xr7avaQxi+VrSdh1w/Nypa9NTSccltyR3bBQvWEc nMRMC8c+r9HG4nNSw/ZDxyeao2DXVPXLM3Y3Raco1b5XNcX5QVgFr+29eiQ69Cv+eVGV dTyylEzhPzm1TsDONSEHL0kpEeFFZzgM5/2QnonEkYcrUplC4/tR4N4ERzgF53ChqVQH sogBazylA5MIVjIdTg9bIG4k8x2BTCXodhjghnUbvmeR+vgRPy2Q9+DX5wSO0ccmUKKD sTfw== X-Forwarded-Encrypted: i=1; AKwUvBx/BeunAk8OR18w+SVMwKGYE14FEHN1yAMNukLAqxkYBi8P+QLcUUwHHtVUl82DvedqzhrA1rSmXwG5w3BeRg==@lists.infradead.org X-Gm-Message-State: AFq9FYJ6pnPFT3W2rDKEPreCYNN4M9IaTtlls3esD11GlnpHcKpIoLrx i+JLveOxj3xvISsJ7n6jqeq6mfgk6fgMGomDDw0oPLAIfwk018oEuadF X-Gm-Gg: AYBFou1vSJKgt3uYf5eyI5vckAz3Q9Z7stdSxU0WCZyyAOAOSn4crwgPUUZ4VZ7ty5M qL4a3JzXj/4xDxthU/jH01275HiOX/gFqg7f5ZrCAOgKR6uAhB0p0qIohKutA6bCLopMoUsNuUc uyoAllCWdOYz5Hj58SzkV8S+hCJNtOtZm/3HZO0/MYWIbmsVPYNeisaInIjf6Im8UL76lGbwXkD AvEfJFxO9Sjk1nWSyV3vBRWXxugHxt1MadmoF00BhXxjEM1GwwfZY1SH3fw0qd9gQSbm5yN24FU 7w+zgysJ+z5UOklyDM2xUpW3P1zxIVnqVpzONkSzuGE58dQ59oI0CGwaIAgtZ4165FNrpeewtpF gfDFEutkf/hgo6WzhG0oRhQoaXKLnJjb0Z4GaQIaaQrcy/2DwY5eazti2ogykorWybq88w0fJAz 2w1ONYLq1qNjbbm1eqtx7bunCaZmboi2xFyz2/aftQapO6p+Fh4bJLXFD/N8qNayChQP1zw/d5w U/LjVhD0AQdM7vqEibPNsT3yvvhMTXf62cWOen25aycsBfj0kYxPlOPXvWbLSysiLaMyKwKEiXp i8rKT40TxL3Ffy0lkefq8EeuynIEDG2HwQR9ZWiR9O/0zW9pSR7gAA7kl4I+T7XhEsLxRbMW2mc m+f5MNqgAR+dQQfJCWYuxLKLY60fsdmf8A+QGlXNWwPkEKg== X-Received: by 2002:a05:600c:1546:b0:49e:6581:7baf with SMTP id 5b1f17b1804b1-4aa86a42518mr6057825e9.2.1793208680690; Wed, 28 Oct 2026 10:31:20 -0700 (PDT) Received: from tachyon.internal (2.155.41.158.dyn.user.ono.com. [2.155.41.158]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4aa80285b2dsm6496175e9.13.2026.10.28.10.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:31:19 -0700 (PDT) From: =?UTF-8?q?Enrique=20Hern=C3=A1ndez=20Bello?= To: iav@iav.lv Cc: shawn.lin@rock-chips.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, robh@kernel.org, heiko@sntech.de, linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC 0/2] PCI: rockchip-host: Retry training and hot-reset a JMB585 on RK3399 Date: Wed, 28 Oct 2026 17:31:17 +0000 Message-ID: <20261028173117.3457220-1-ehbello@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: References: <20261024-rockchip-pcie-resume-v1-0-58e54a5cf5f1@iav.lv> <4316c1da-f7ff-4fa5-a330-512800474e45@rock-chips.com> <20261026-rockchip-pcie-shawn-reply-1@iav.lv> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261028_103123_412418_A67C0BDC X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 You said both SErrors and synchronous external aborts occur. In my logs which of the two you get tracks the cluster the access runs on, which might be worth a look before you move the hook. Every asynchronous SError in rockchip_pcie_rd_conf landed on CPU4 or CPU5, the A72s, across six boots on two different kernels. The one time the same read aborted synchronously it was on CPU3, an A53. They also carry different ISS: 0xbf000002 for these config-read aborts, against 0xbf000000 for the unrelated runtime SErrors on this board. That is one synchronous case, so not a law, but it is cheap for you to test: pin enumeration to an A53 and see whether your aborts all become synchronous. It matters because only the synchronous form can be repaired. When it arrives as an SError the load has retired and there is no destination register left to write all-ones into, so no fixup can help. I prototyped the synchronous half in September: an exception-table entry consulted from do_sea(), with the driver substituting the all-ones the PCI core expects rather than only surviving. arm32 has had that for years -- imx6q_pcie_abort_handler() in dwc/pci-imx6.c decodes the faulting instruction and makes a read look like all-ones, under #ifdef CONFIG_ARM -- and arm64 has no equivalent path. It only ever worked for me with enumeration pinned to an A53, which is what made me look at the cluster in the first place. Not proposing anything, and not reviving that prototype. Yours if any of it is useful. _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip