From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.167.169 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793209435; b=bbxUy8V5ceOrksIOvWAc/DcRa2mw7QAliq0V69Cq2NAzntIQmfsoP7fi7WpJqJyK/MZE i1zligMXcJrxx1OffNWEKM6uYq/B0o9zXJUBJ/o2sPxO/RQ2R3+/+qab6SWfxKLmnp8tB OrR0zYskTNYFrxbf5HX6R//VRTNh6bHYdZ0EWc6YqvwEAeCya26l9AP9YPU4xj3DmXBiR 23/R55QAbkUjCD9MuEM87oaLJHwAcwGsDFG0vG/jYys6icGxvwpk4NAhsl0tjDbAzXZsE sZXBPN+pxjwTtzY5iYT9gQJBimFvZ0QCciJvA9j6aWbCtBZsENUEmroNf3q7/5tDV+Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793209435; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=C7bPJOiOxWmpQxwy7s6DX34z4VIYYp5wKziJM3UDTWA=; b=BQ2656iB/+YqGm0BNQgKaQyK5LuBH7TLJeEOJ1YfACoAhp2hmgtjTHP2xPwdZ+5CCSSs Py+kvP+yHoVr1F/w6qGVbzAG6Pt3MImLE3neVWw26zQYyqptMXiDX4bNU/RGdJwhwgWQ8 Wa8wUAdddaszOvIseqV98QqDqNFNJLHQ7ylExOgNUXqfMVpsR/2eNoW7gyalqVJsjzYvu CYrfgISR9POpXet2cNA1n0BPTYIO6GVbEn+47PstW8KtKFl2Um9SQVNjSDqpaPegnZpFf 0cdpsjt178TTW13Z93P+4o8Q4UygyjM1dFlnwnjC4iuvVV+egI009lHVEh7Y9oyzbIw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=JJYiJJn4; arc=none smtp.remote-ip=209.85.167.169 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2B58606A330 for ; Wed, 28 Oct 2026 17:43:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C2B58606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=JJYiJJn4 Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-54cd7de2d42so811445b6e.0 for ; Wed, 28 Oct 2026 10:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1793209434; x=1793814234; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C7bPJOiOxWmpQxwy7s6DX34z4VIYYp5wKziJM3UDTWA=; b=JJYiJJn4JkWCZeEc6Eis2ekHoap8cCzGqHyN7y9E0/bmhYY6SeOMj9wXaDxYGCF9W4 rg6+zkS0FgWnliPYuAGh09K7H+ciIbzVpwopLnTlrKjr3K1sgsRTinNnSJQqI16KG2ME zRD0FXl/xMNfcTSFf1Vw2j92iw2g9/DbY79Xu4A8/Aq0YonF6eSIBpGbs52puEJc1gfO XgehVrwlBeXP9hXhhcZGLFYKkB5r6tuHGlTnxEV9n3iHFz7LB76f2WflVwH1DxlH0Y1z MhGYvLVap0OCNB+iO3pgZimqvW9FhewVuq4G40TkNci7ysBcRx2Wz1rnVlGNFCMfP2Ug +i/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793209434; x=1793814234; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=C7bPJOiOxWmpQxwy7s6DX34z4VIYYp5wKziJM3UDTWA=; b=zM2JGYdq3tIISTcZ1gM9Uu4Yz4Jb/m9H/XltLBvc0ObDJQVPSuFk19FznGkXPXF1rV YZtXsGxbtXjq57NFcxB5IzTB8kgXJru85r5zFt3p218SAgWl4IZBSJv2nZLnYXsrGFXJ BjjOP409lKDpm1yBNPohxZQWdS2nvY1sqg2TukCC+/E99yxRvvumtaXIXXGdqqSJIsNx CvrbHPAxW9TH1AdmGgU4Rovk9CPGX1aPsM3jOlMsuwZ7bkvNTcvR4JMLwlIR5VI7TXvr wafjD5Xdolf05nX7YaUdf0SXZmiRehHP3kNLKcNaskgHYlXe1WV6MIs0Dlt1jbU23Tej 6m1A== X-Forwarded-Encrypted: i=1; AKwUvBxzf+OgbRP6BphXJ31aLtW0e/IlsUmRvFf/RMd6iDOetEtQ6JADBRSwhL6if25oKaKoYAVGwjGm8H9L@vger.kernel.org X-Gm-Message-State: AFq9FYJuDuckgqquAnqT4W83d5JPqFhAV2iU205MRjuF2z5wAOsKhiM3 a/tBzjnzZWvOkfM/sPhD2T/8BKVmHUGPCfD0jsXkPWNLoFCADU5Jga5e X-Gm-Gg: AYBFou3kfSnzhRiB6Pjzfo+nu52GPtjNGMXcGeln0zyXz6ciMz9a9slbWLNf0HcwAWt Z8WMIROhEXr7gYU2t538yQ8Wn6qQnij0eiJkXpl7n3KQpxjksUidFecMM3A/iWjPtd3fd+77pjG AxyZD1WclYm5d850V+DtxOUx3usZgVQRYfygYyZasnn5avHYOvhM3XF+MT1cDPV+tf3tEZc+KU4 RU91acfgc157TYkw+ei/sp4K46Gcj3naVOiSUCMss0uD+6jq0+8evAtrNmMwG9MPx4E6+I/PRAL BeBDu+Yf2vjRx+aLIbWHb+IfU7xlj1puEztvHzc8+ghcrgKYggVZRRismpNI4YBqi2tYDwPEGYQ C+LUsfpH70yM/ymxQ4sweTNrcPgJMRCFsIE89vF0j0k7TnT6sWQNXWlB4vwQfD9yn9yJnphLZNZ YCrSKeCD2CIPwwi0VIKGdK0CkAQMw2TziHW9H5UPZdNxrVNPpaYb19nw/NI+WiNJfgsaq7rFGzA 7S+6OQeNXCb2+trY57mS1zO+vj065/C+bOKcYBTPVBqy2/TcRBX4mH7DgG5xViaMrNv27ZB7yv5 21dbk7KtPHgEUPBCCqlMxwMG7xtgFW/cs/f0rowbEk9i0Lbk+JupxubUD9rniLa6Mu8Pdzt7Srk iAiPcS8mR94kdeyki X-Received: by 2002:a05:6808:bd6:b0:4d6:9283:1dec with SMTP id 5614622812f47-56384c81150mr2067708b6e.58.1793209433737; Wed, 28 Oct 2026 10:43:53 -0700 (PDT) Received: from archlinux.lan ([136.34.156.120]) by smtp.gmail.com with ESMTPSA id 5614622812f47-563c5a4d8b7sm1612114b6e.8.2026.10.28.10.43.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:43:52 -0700 (PDT) From: Danish Khateeb To: Lee Jones , Pavel Machek Cc: Andrew Davis , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Danish Khateeb , stable@vger.kernel.org Subject: [PATCH v3 1/2] leds: tca6507: Fix use-after-free on unbind Date: Wed, 28 Oct 2026 12:43:47 -0500 Message-ID: <20261028174348.64014-2-danishkhateeb03@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261028174348.64014-1-danishkhateeb03@gmail.com> References: <20261028174348.64014-1-danishkhateeb03@gmail.com> X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since the LEDs are registered with devm_led_classdev_register(), they are unregistered only after tca6507_remove() has cancelled the work. Unregistering an LED that is on turns it off, which queues the work again from led_assign(), and the work then runs after devres has freed the chip: BUG: KASAN: slab-use-after-free in assign_work+0x414/0x5b0 Read of size 8 at addr ffff888010d5c0c0 by task kworker/1:2/65 ... Last potentially related work creation: ... queue_work_on+0xb6/0xc0 led_assign+0x223/0x340 [leds_tca6507] led_classdev_unregister+0x26b/0x340 release_nodes+0xb3/0x140 devres_release_group+0x247/0x470 i2c_device_remove+0xbf/0x1b0 Set up the work with devm_work_autocancel() before the LEDs are registered, so that devres cancels it after they are gone, and drop tca6507_remove(). Fixes: 1b5c2fa7081c ("leds: tca6507: Use devm_led_classdev_register() to simplify remove path") Cc: stable@vger.kernel.org Acked-by: Andrew Davis Signed-off-by: Danish Khateeb --- drivers/leds/leds-tca6507.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c index 9afe2722986c..0f987e551f03 100644 --- a/drivers/leds/leds-tca6507.c +++ b/drivers/leds/leds-tca6507.c @@ -71,6 +71,7 @@ * not recognised when matching. */ +#include #include #include #include @@ -735,9 +736,11 @@ static int tca6507_probe(struct i2c_client *client) return -ENOMEM; tca->client = client; - INIT_WORK(&tca->work, tca6507_work); spin_lock_init(&tca->lock); - i2c_set_clientdata(client, tca); + + err = devm_work_autocancel(dev, &tca->work, tca6507_work); + if (err) + return err; for (i = 0; i < NUM_LEDS; i++) { struct tca6507_led *l = tca->leds + i; @@ -766,20 +769,12 @@ static int tca6507_probe(struct i2c_client *client) return 0; } -static void tca6507_remove(struct i2c_client *client) -{ - struct tca6507_chip *tca = i2c_get_clientdata(client); - - cancel_work_sync(&tca->work); -} - static struct i2c_driver tca6507_driver = { .driver = { .name = "leds-tca6507", .of_match_table = of_match_ptr(of_tca6507_leds_match), }, .probe = tca6507_probe, - .remove = tca6507_remove, .id_table = tca6507_id, }; -- 2.56.0