From: Herve Codina <herve.codina@bootlin.com>
To: Simon Glass <sjg@chromium.org>
Cc: Devicetree Compiler <devicetree-compiler@vger.kernel.org>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 5/6] dtc: Report an error for a delete in an overlay fragment
Date: Wed, 28 Oct 2026 19:17:09 +0100 [thread overview]
Message-ID: <20261028191709.0a304dd8@bootlin.com> (raw)
In-Reply-To: <20261028093620.3705074-6-sjg@chromium.org>
Hi Simon,
On Wed, 28 Oct 2026 03:36:12 -0600
Simon Glass <sjg@chromium.org> wrote:
> An overlay cannot encode a /delete-property/ or /delete-node/, since
> applying an overlay only adds or updates nodes and properties. So a
> delete in an overlay fragment has no effect on the base tree, yet dtc
> drops it without complaint, which suggests that it works. A delete which
> removes something earlier in the same fragment is fine, since the
> fragment is compiled without it.
>
> Report an error for a /delete-property/ or /delete-node/ in a fragment
> which does not delete anything within the fragment, naming it. Record in
> apply_deletes() which placeholders delete something, and add
> find_unapplied_delete() to look for one which does not. Do this for each
> of the three ways in which a plugin creates a fragment.
>
> Drop the deletes with nothing to delete from the overlay test, and add
> tests which check for the error, one for each way of creating a
> fragment.
>
> Note: This breaks the build of two overlays in Linux v7.3-rc7, whose
> deletes have never taken effect:
>
> imx8mn-tqma8mqnl-mba8mx-usbotg.dtso
> imx8mp-tqma8mpql-mba8mp-ras314-imx219.dtso
>
> Linux needs to remove these deletes. Where the result matters, the base
> dts must change instead, e.g. by moving the property or node to the
> boards which need it, so that the overlay only adds to the tree.
>
> Suggested-by: David Gibson <david@gibson.dropbear.id.au>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
/delete-node/ &label;
We can probably delete a node defined in the overlay but in an other
fragment.
Is than handled ?
Best regards,
Hervé
next prev parent reply other threads:[~2026-10-28 18:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 9:36 [PATCH v2 0/6] dtc: Fix deletes within a section and before a redefinition Simon Glass
2026-10-28 9:36 ` [PATCH v2 1/6] dtc: Apply deletes in the section which has them Simon Glass
2026-10-28 9:36 ` [PATCH v2 2/6] dtc: Remove a deleted node or property from the tree Simon Glass
2026-10-28 9:36 ` [PATCH v2 3/6] dtc: Clarify when delete placeholders are dropped Simon Glass
2026-10-28 17:56 ` Herve Codina
2026-10-29 8:59 ` Simon Glass
2026-10-28 9:36 ` [PATCH v2 4/6] tests: Allow dtc-fatal.sh to check the error message Simon Glass
2026-10-28 18:02 ` Herve Codina
2026-10-29 7:21 ` Herve Codina
2026-10-29 9:01 ` Simon Glass
2026-10-28 9:36 ` [PATCH v2 5/6] dtc: Report an error for a delete in an overlay fragment Simon Glass
2026-10-28 18:17 ` Herve Codina [this message]
2026-10-29 9:04 ` Simon Glass
2026-10-28 9:36 ` [PATCH v2 6/6] doc: dts-format: Describe later definitions and deletes Simon Glass
2026-10-28 18:25 ` Herve Codina
2026-10-29 9:06 ` Simon Glass
2026-10-29 2:49 ` [PATCH v2 0/6] dtc: Fix deletes within a section and before a redefinition David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261028191709.0a304dd8@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-compiler@vger.kernel.org \
--cc=sjg@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.