From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793306424; b=3biuYt52yFJ4sa8cKdxCxD1YAsHIF+fe/h13ylLbgPHKrx+rkLBFEdX8lE5pLMGRFs// 2mGvL55OQjx07MnqPJm91YSKmEer2N+7wqhgTB4I8++0R+OPaoI5GxJh+r+Oom9NsP2yt tUGMTbZ69OVp84zYh67qlYFYuoTfRXuuAZpy1RGWHtZGo7crqrROYAATXEPiceYJXy7s2 6d7xeITYxEErrJQPG6WelhxUsceQMmp5IxvqobbQuHSbh3MJrX3GXBe55J6uNwRcpHds3 em2wYVW5nbd62uJ2sE4H2BbjOGTF/lFOZsFP6beYdspLh1KL4wIEsA8iaIUmr7RPtHw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793306424; h=Received:DKIM-Signature:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:References:In-Reply-To:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=smP21MNlcpMNK0fftG0qIJjRHMGZkCrdRDzn60iqOt8=; b=HEJur8RG3OIOgcFLiYi26hU7tui7ixBWhJoJ2oqfc1+yVviOy0kb7ZIB4VXHL5Hgk6Z8 rfMZNHups8GGyakFRZRun+Ar0e/nH9xuxeHXzEiVp7+xDVCtUAo7/bnX8zq2QEnRm/o30 hS1CyscZqvF5D/pSUUUfVPtIV/SL8aMdKChNQBUZ0f2mH6/xMDRbyVf95+45O9+oXnSlj AVJ5jq6ybPvu25cp0h6/FZsOuDDD/Vz2eJY+poFM/UCOdvR9qaVlq1mWKu4gDtgniXJoP F2KIUbCaLOtEe0dTRUfl5LX+TmPw9xX38gX2mqBExX3ynXPQ+E/gh/ugCqbSKbqJ08g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Fg9rhh+A; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3873606A31C; Thu, 29 Oct 2026 20:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Fg9rhh+A Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B5921F01825; Thu, 29 Oct 2026 20:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793306423; bh=smP21MNlcpMNK0fftG0qIJjRHMGZkCrdRDzn60iqOt8=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=Fg9rhh+AMA4eoEvT+YS9smXN/Jw8jNkYUjlh2/WTvhUvRfWpGqVIUbws/nOVgTKcH JmnLtzTywSkKc+tveOiqNJ6sAaVzMCrSBLWOJdYLEPFobnUHjtdPYBFN2THMnyCyVi PHyEgjRW1DEo+LWLMNJptKFTSjq/0eTcrs+9Ajj7tKT++gUkfNirE2kDH09ux5Sv8z mhGvyubr7mt7sR0Wbytg8XF6t3CPX+P+JGjmV2jQWuePXnKYTwkQ/kF0/q6mjtOKtZ 2yz2nJlMMeRtr1tWauVtwW/Xm2qaAAW03XxA6ePXGgPASmS5F5R4zEZixe4DeMWgj7 VqbGB1iSp0JeQ== From: "David Hildenbrand (Arm)" Date: Thu, 29 Oct 2026 21:33:23 +0100 Subject: [PATCH v2 28/47] mm/mmu_notifier: finish non-blocking interval invalidation on error X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261029-fixes_core-v2-28-a64ce7f83abb@kernel.org> References: <20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org> In-Reply-To: <20261029-fixes_core-v2-0-a64ce7f83abb@kernel.org> To: Andrew Morton , Johannes Weiner , Michal Hocko , Qi Zheng , Shakeel Butt , Lorenzo Stoakes , Kairui Song , Barry Song , Axel Rasmussen , Yuanchu Xie , Wei Xu , Baoquan He , Baolin Wang , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Kees Cook , Peter Zijlstra , Jann Horn , Pedro Falcato , Hugh Dickins , Pasha Tatashin , Pratyush Yadav , "Matthew Wilcox (Oracle)" , Jan Kara , Zi Yan , Lance Yang , Rik van Riel , Harry Yoo , Alistair Popple , Nico Pache , Ryan Roberts , Dev Jain , Usama Arif , Kiryl Shutsemau , Matthew Brost , John Hubbard , Peter Xu , Will Deacon , "Aneesh Kumar K.V" , Nick Piggin , Oscar Salvador , Minchan Kim , Muchun Song , Xu Xin , Chengming Zhou , Chris Li , Kemeng Shi , Nhat Pham , Youngjun Park , Gregory Price , Joshua Hahn , Rakie Kim , Ying Huang , Jason Gunthorpe Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-cxl@vger.kernel.org, Josef Bacik , stable@vger.kernel.org, "David Hildenbrand (Arm)" X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3102; i=david@kernel.org; h=from:subject:message-id; bh=l+fGHD3i9bA+Hs3jbwzxEm0UnsFEqJuA4y7L3ttzpgI=; b=owGbwMvMwCF2/OVpCdfQ3ZWMp9WSGLIer21/ytZ3UVrk43nXrzP3PFV7v/ejwcct57Ujb0oFB PP7rvPc2VHKwiDGwSArpsgSFHzf4OXLdbXVbnzMMHNYmUCGMHBxCsBEmC0ZGTZNDxBhjO2a81A+ i3OF0eHLq9KU+XwOrDaVypHJYvOV/MnwP9ggYv7qttlnXwRlzdJus1/57fI//zOXnS/a69/6sZ5 nHy8A X-Developer-Key: i=david@kernel.org; a=openpgp; fpr=1BD9CAAD735C4C3A460DFCCA4DDE10F700FF835A From: Josef Bacik When an ordinary MMU notifier rejects a non-blocking invalidation, the interval invalidation started beforehand is left unfinished: the caller skips mmu_notifier_invalidate_range_end(). Subsequent interval notifier operations can then wait forever. The only in-tree trigger is nouveau SVM, which uses both notifier types and rejects non-blocking invalidations. Reaping via the OOM reaper or process_mrelease() can therefore leave the GPU fault worker stuck, holding a reference that prevents the dying process's address space and memory from being freed. End the interval invalidation when an ordinary notifier fails a non-blocking invalidation, like mn_itree_invalidate() already does when an interval notifier fails. Make that handling clearer in the documentation of mmu_notifier_invalidate_range_start_nonblock(). Fix generated by an LLM and sent by Josef Bacik in private. Fixes: 99cb252f5e68 ("mm/mmu_notifier: add an interval tree notifier") Cc: stable@vger.kernel.org Signed-off-by: Josef Bacik [ david: simplify description, update function doc ] Acked-by: Lorenzo Stoakes (ARM) Signed-off-by: David Hildenbrand (Arm) --- include/linux/mmu_notifier.h | 3 ++- mm/mmu_notifier.c | 17 +++++++++++++---- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/include/linux/mmu_notifier.h b/include/linux/mmu_notifier.h index a11a44eef521..5db78e5761c5 100644 --- a/include/linux/mmu_notifier.h +++ b/include/linux/mmu_notifier.h @@ -483,7 +483,8 @@ mmu_notifier_invalidate_range_start(struct mmu_notifier_range *range) /* * This version of mmu_notifier_invalidate_range_start() avoids blocking, but it * can return an error if a notifier can't proceed without blocking, in which - * case you're not allowed to modify PTEs in the specified range. + * case you're not allowed to modify PTEs in the specified range or call + * mmu_notifier_invalidate_range_end(). * * This is mainly intended for OOM handling. */ diff --git a/mm/mmu_notifier.c b/mm/mmu_notifier.c index df69ba6e797f..2e20f88e162d 100644 --- a/mm/mmu_notifier.c +++ b/mm/mmu_notifier.c @@ -569,16 +569,25 @@ int __mmu_notifier_invalidate_range_start(struct mmu_notifier_range *range) { struct mmu_notifier_subscriptions *subscriptions = range->mm->notifier_subscriptions; - int ret; + const bool has_itree = subscriptions->has_itree; + int ret = 0; - if (subscriptions->has_itree) { + if (has_itree) { ret = mn_itree_invalidate(subscriptions, range); if (ret) return ret; } if (!hlist_empty(&subscriptions->list)) - return mn_hlist_invalidate_range_start(subscriptions, range); - return 0; + ret = mn_hlist_invalidate_range_start(subscriptions, range); + + /* + * On error, the non-blocking caller is not allowed to call + * invalidate_range_end(), as in mn_itree_invalidate(). + */ + if (ret && has_itree && !mmu_notifier_range_blockable(range)) + mn_itree_inv_end(subscriptions); + + return ret; } static void -- 2.43.0